From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.9738.1679304912821050261 for ; Mon, 20 Mar 2023 02:35:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W+SajNhK; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679304911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O2rfP3QUEHpPoDC3xPw0P5pUDwJJIGLTL61C/XsGm24=; b=W+SajNhKKwatgMfvQIkeomgHuA5nrY9mvifL/dQy22MkEXGR6jRqVhCAPiOeIcuZzwYKwd rqu68F4Kz9oTTxVu5b2asEqSONe1MJtgAfJpPqHG7+iktHJoDV5RD0Omq8OdPBnwUcGZ8i EIWgXhrdhJt8bjR88fYZxstSpUPDlMU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-WOQ-5v-LPQ-t8imOY4pxCg-1; Mon, 20 Mar 2023 05:35:07 -0400 X-MC-Unique: WOQ-5v-LPQ-t8imOY4pxCg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB9AA889047; Mon, 20 Mar 2023 09:35:06 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3B2F18EC6; Mon, 20 Mar 2023 09:35:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 42FED1800081; Mon, 20 Mar 2023 10:35:04 +0100 (CET) Date: Mon, 20 Mar 2023 10:35:04 +0100 From: "Gerd Hoffmann" To: Rebecca Cran Cc: devel@edk2.groups.io, quic_rcran@quicinc.com, Andrew Fish , Leif Lindholm , Michael D Kinney , Bob Feng , Liming Gao , Yuwei Chen , Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX= Message-ID: <20230320093504.fgwcnencpk7a6ehx@sirius.home.kraxel.org> References: <20230217035101.880854-1-rebecca@quicinc.com> <20230217035101.880854-2-rebecca@quicinc.com> <20230315100742.umho6xek26kv5t6i@sirius.home.kraxel.org> <602780c3-7915-2fb0-177c-9d6dacad22a3@bsdio.com> MIME-Version: 1.0 In-Reply-To: <602780c3-7915-2fb0-177c-9d6dacad22a3@bsdio.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Mar 17, 2023 at 04:43:24AM -0600, Rebecca Cran wrote: > On 3/15/23 4:07 AM, Gerd Hoffmann wrote: > > > Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC > > > and BUILD_CXX) and using the standard name 'LDFLAGS' instead of > > > 'LFLAGS'. This allows clang to be used by running > > > 'make -C BaseTools CC=clang CXX=clang++'. > > Hmm, not sure this is a good idea. I suspect there was some reason to > > use BUILD_CC instead of CC in the first place ... > > It looks like the change to use BUILD_CC was introduced by Liming in: > > >     BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ > prefix > >     To avoid the conflict with the default GCC flag name, BUILD_ prefix is > added. > >     Cc: Giri P Mudusuru >     Cc: Yonghong Zhu >     Contributed-under: TianoCore Contribution Agreement 1.0 >     Signed-off-by: Liming Gao >     Reviewed-by: Yonghong Zhu >     Reviewed-by: Giri P Mudusuru > > > I don't understand how that would help, and I'm wondering if it was perhaps > the result of a misunderstanding. Hmm, neither the commit message nor the patch itself have any hints of actual problems fixed. The "conflict" notion indeed hints this might have been a misunderstanding. So, going back to just use CC + CFLAGS + friends looks fine to me. The suggestion to simply not set CC stands stands. take care, Gerd