From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.9864.1679305462962736889
 for <devel@edk2.groups.io>;
 Mon, 20 Mar 2023 02:44:23 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MOWMoDB0;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1679305462;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=jmC6HahRtn/lRqj9FNKYf9Gm6l4bLScO+zFURpX8rgk=;
	b=MOWMoDB0jbZMBJ7z4XWslCjJhjkim2uDd93cGgAL/v/XUDWk3sPr5Psq2o/caxG8vCr6HB
	Z8Uy1o0gmgmQbykAqQ3KzAer/r6E47hSkG+5ovFkjdryTAmt1viX/ZlzV2tvhv/aWsj5W/
	HDfK8j9RBPJpyskL4wtp2AdT8tSO8CU=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-611-Vxfl9rfDPJq53Zq8a8ldTQ-1; Mon, 20 Mar 2023 05:44:20 -0400
X-MC-Unique: Vxfl9rfDPJq53Zq8a8ldTQ-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 72264101A54F;
	Mon, 20 Mar 2023 09:44:19 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.144])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 47DCE40C83B6;
	Mon, 20 Mar 2023 09:44:19 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 110E21800081; Mon, 20 Mar 2023 10:44:18 +0100 (CET)
Date: Mon, 20 Mar 2023 10:44:17 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, Michael.Roth@amd.com
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	Jiewen Yao <jiewen.yao@intel.com>, ray.ni@intel.com,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>
Subject: Re: [edk2-devel] [PATCH RESEND 2/4] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition
Message-ID: <20230320094417.xd5apppic6un7h4u@sirius.home.kraxel.org>
References: <20230315215747.1543837-1-michael.roth@amd.com>
 <20230315215747.1543837-3-michael.roth@amd.com>
MIME-Version: 1.0
In-Reply-To: <20230315215747.1543837-3-michael.roth@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 15, 2023 at 04:57:45PM -0500, Roth, Michael via groups.io wrote:
> The Confidential Computing blob defined here is intended to match the
> definition defined by linux guest kernel. Previously, both definitions
> relied on natural alignment, but that relies on both OVMF and kernel
> being compiled as 64-bit. While there aren't currently any plans to
> enable SNP support for 32-bit compilations, the kernel definition has
> since been updated to use explicit padding/reserved fields to avoid
> this dependency. Update OVMF to match that definition.
> 
> While at it, also fix up the Reserved fields to match the numbering
> used in the kernel.
> 
> No functional changes (for currently-supported environments, at least).
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> Acked-by: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>