From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.9937.1679305769190257098
 for <devel@edk2.groups.io>;
 Mon, 20 Mar 2023 02:49:29 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MseIK4DW;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1679305768;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=je4RLJa1tM//zjzfbOKWxHhMsCtcd0b9DXeEkQC1D9o=;
	b=MseIK4DW9N1CD0Ear3TBMZBQrGHvTCfzjyYIKXaSFyZcoSSCatZx3LWX72D4zIuMaOrC73
	w0L6weL0t80NNzMFCBKWe46XQzS9PIpgS6fK7tISqEZKyo31SNW/XmqOFEX7qqxECqSgP+
	+oBe0Tmz8OPuxv38EHa1Uy+PJuvJnwU=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-471-NcmStqtaNjS-yWneCc-BWA-1; Mon, 20 Mar 2023 05:49:10 -0400
X-MC-Unique: NcmStqtaNjS-yWneCc-BWA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 51482800B23;
	Mon, 20 Mar 2023 09:49:10 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.144])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A70618EC6;
	Mon, 20 Mar 2023 09:49:10 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id C48A81800081; Mon, 20 Mar 2023 10:49:08 +0100 (CET)
Date: Mon, 20 Mar 2023 10:49:08 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Michael Roth <michael.roth@amd.com>
Cc: devel@edk2.groups.io, Tom Lendacky <thomas.lendacky@amd.com>,
	Jiewen Yao <jiewen.yao@intel.com>, ray.ni@intel.com,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>
Subject: Re: [PATCH RESEND 4/4] OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP
Message-ID: <20230320094908.fe7xhfoyjtfuihhn@sirius.home.kraxel.org>
References: <20230315215747.1543837-1-michael.roth@amd.com>
 <20230315215747.1543837-5-michael.roth@amd.com>
MIME-Version: 1.0
In-Reply-To: <20230315215747.1543837-5-michael.roth@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 15, 2023 at 04:57:47PM -0500, Michael Roth wrote:
> Currently OVMF tries to rely on the base size advertised via the CPUID
> table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will
> generally work for KVM guests, but might not for other SEV-SNP
> hypervisor implementations. Make the handling more robust by simply
> using the base area size documented by the APM.
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> Acked-by: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>