From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ardb+tianocore@kernel.org>,
<quic_llindhol@quicinc.com>, <kraxel@redhat.com>,
<pierre.gondois@arm.com>, <Alexei.Fedorov@arm.com>,
<Matteo.Carlini@arm.com>, <Akanksha.Jain2@arm.com>,
<Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH v1 1/4] DynamicTablesPkg: Reduce log output from TableHelperLib
Date: Mon, 20 Mar 2023 14:05:54 +0000 [thread overview]
Message-ID: <20230320140557.40348-2-sami.mujawar@arm.com> (raw)
In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com>
Reduce the log output from Configuration Manager Object Parser
in TableHelperLib by enabling the logs only if DEBUG_INFO is
enabled.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 28 ++++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
index 5e4b88e8cc754ea72157ea4a0c6d0f5b9eae2495..99d6032510a5e912c9189df82c4d2b4398458d2d 100644
--- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
+++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
@@ -1,7 +1,7 @@
/** @file
Configuration Manager Object parser.
- Copyright (c) 2021 - 2022, ARM Limited. All rights reserved.<BR>
+ Copyright (c) 2021 - 2023, ARM Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -787,7 +787,7 @@ PrintOemId (
)
{
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
(Format != NULL) ? Format : "%C%C%C%C%C%C",
Ptr[0],
Ptr[1],
@@ -855,7 +855,7 @@ PrintCmObjDesc (
*RemainingSize -= Parser[Index].Length;
if (*RemainingSize < 0) {
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
"\nERROR: %a: Buffer overrun\n",
Parser[Index].NameStr
));
@@ -865,11 +865,11 @@ PrintCmObjDesc (
// Indentation
for (IndentIndex = 0; IndentIndex < IndentLevel; IndentIndex++) {
- DEBUG ((DEBUG_ERROR, " "));
+ DEBUG ((DEBUG_INFO, " "));
}
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
"%-*a :",
OUTPUT_FIELD_COLUMN_WIDTH - 2 * IndentLevel,
Parser[Index].NameStr
@@ -879,20 +879,20 @@ PrintCmObjDesc (
} else if (Parser[Index].Format != NULL) {
switch (Parser[Index].Length) {
case 1:
- DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT8 *)Data));
+ DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT8 *)Data));
break;
case 2:
- DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT16 *)Data));
+ DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT16 *)Data));
break;
case 4:
- DEBUG ((DEBUG_ERROR, Parser[Index].Format, *(UINT32 *)Data));
+ DEBUG ((DEBUG_INFO, Parser[Index].Format, *(UINT32 *)Data));
break;
case 8:
- DEBUG ((DEBUG_ERROR, Parser[Index].Format, ReadUnaligned64 (Data)));
+ DEBUG ((DEBUG_INFO, Parser[Index].Format, ReadUnaligned64 (Data)));
break;
default:
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
"\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n",
Parser[Index].NameStr,
Parser[Index].Length
@@ -901,7 +901,7 @@ PrintCmObjDesc (
} else if (Parser[Index].SubObjParser != NULL) {
SubStructSize = Parser[Index].Length;
- DEBUG ((DEBUG_ERROR, "\n"));
+ DEBUG ((DEBUG_INFO, "\n"));
PrintCmObjDesc (
Data,
Parser[Index].SubObjParser,
@@ -912,14 +912,14 @@ PrintCmObjDesc (
} else {
ASSERT (0);
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
"\nERROR: %a: CANNOT PARSE THIS FIELD, Field Length = %d\n",
Parser[Index].NameStr,
Parser[Index].Length
));
}
- DEBUG ((DEBUG_ERROR, "\n"));
+ DEBUG ((DEBUG_INFO, "\n"));
Data = (UINT8 *)Data + Parser[Index].Length;
} // for
}
@@ -978,7 +978,7 @@ ParseCmObjDesc (
for (ObjIndex = 0; ObjIndex < ObjectCount; ObjIndex++) {
DEBUG ((
- DEBUG_ERROR,
+ DEBUG_INFO,
"\n%-*a [%d/%d]:\n",
OUTPUT_FIELD_COLUMN_WIDTH,
ParserArray->ObjectName,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2023-03-20 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 14:05 [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool Sami Mujawar
2023-03-20 14:05 ` Sami Mujawar [this message]
2023-03-20 14:05 ` [PATCH v1 2/4] DynamicTablesPkg: Fix parsing of serial port node Sami Mujawar
2023-03-20 14:05 ` [PATCH v1 3/4] ArmVirtPkg: " Sami Mujawar
2023-03-20 14:05 ` [PATCH v1 4/4] ArmVirtPkg: Fix depex in kvmtool guest Rtc library Sami Mujawar
2023-03-21 13:54 ` [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool PierreGondois
2023-03-29 10:49 ` Sami Mujawar
2023-03-29 11:55 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320140557.40348-2-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox