From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.48]) by mx.groups.io with SMTP id smtpd.web11.14924.1679321177143263334 for ; Mon, 20 Mar 2023 07:06:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=MZ+FTpQk; spf=pass (domain: arm.com, ip: 40.107.7.48, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TROFG8ok0pN94vZiyw4yRqDJ6l/AGW6io+FJjUqgCd8=; b=MZ+FTpQkzWbxzD5IDwHxk4tzOIrj46WzDZX749dt1YT/SmN0/m1YZ0Ezk1vyClFJC1LMpkvQNOrjngjzxAqXi4N96NeWFK7Ati7qAzLyJYrygj3bypJXlldG8nZfPdB/r4Sb6fQmyRt8FDKfKsnXEi5Ty9mXzgsIIeXGZky/dd8= Received: from DU2PR04CA0056.eurprd04.prod.outlook.com (2603:10a6:10:234::31) by DB9PR08MB8625.eurprd08.prod.outlook.com (2603:10a6:10:3d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.36; Mon, 20 Mar 2023 14:06:12 +0000 Received: from DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::20) by DU2PR04CA0056.outlook.office365.com (2603:10a6:10:234::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT015.mail.protection.outlook.com (100.127.142.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:12 +0000 Received: ("Tessian outbound b29c0599cbc9:v135"); Mon, 20 Mar 2023 14:06:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a6542e2f8f3442bf X-CR-MTA-TID: 64aa7808 Received: from a38c4ea37dec.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5650A64C-687C-4D8A-B203-78C519D1E9D4.1; Mon, 20 Mar 2023 14:06:04 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a38c4ea37dec.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Mar 2023 14:06:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dy60x+xtlbh7WfFr9wnsf8uniOrU/JcYhYxddee7kpNhYsdth5YY93QV7CBJItXxnp8uqm3t3FUe0aNmWo4RLWlfaCg5+LuLkJct4kl7Q9qskhFmGdZy9a8VcXWxJwqMeQCljmiK957Y8KOE1J5iKhgfVI5/3OVq4jWZr6MH4spxCiHb0Hm/nhUD2RpNad8W8ohpE+b5QJoV8FGMWcBWqPNww0QudpTy9RcMJelBoOcqGQl23gKxpYmvJkPf6PNOig4D7KeQhXfKLoKaWZIuwsmq505TO44KaX/UMy7HuBYcO6X1XPXOagXVhoICY+K1JGkYH6xw4x5B58/mfGwZzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TROFG8ok0pN94vZiyw4yRqDJ6l/AGW6io+FJjUqgCd8=; b=Xr2h8BDePhnSO3cqwzuiWi+o//fnmi/MpJJsJ96cwNV5FU8ObWsnI7Dfwbx17C5C0guFmUOXRd+DC8ebenNVK7B5zu51SqzkHYMUrjckFI/oZHiJfb4Q7nH4VoiRSjevD1UBplK12g6wbyWLZmtB3v7RLgVTRqktxiwA4dfQrxto+Zw7sANtgmuDXUWql9y9THb8/+jY/f8f2dAKkCcRgnIb/ZQnFnJ6fRfGJepaDAcpXfXrilb07l9okd7JwVMVdM+3KUhQ7Vl+fZM6kuv/LARKR9BBod0CcJX7E95/pQqS2iQ2ZWtHK0x4rZYFIxpT2YdclOFeJjSBTGxlCzRG4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TROFG8ok0pN94vZiyw4yRqDJ6l/AGW6io+FJjUqgCd8=; b=MZ+FTpQkzWbxzD5IDwHxk4tzOIrj46WzDZX749dt1YT/SmN0/m1YZ0Ezk1vyClFJC1LMpkvQNOrjngjzxAqXi4N96NeWFK7Ati7qAzLyJYrygj3bypJXlldG8nZfPdB/r4Sb6fQmyRt8FDKfKsnXEi5Ty9mXzgsIIeXGZky/dd8= Received: from AM6PR10CA0061.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::38) by PAVPR08MB9259.eurprd08.prod.outlook.com (2603:10a6:102:307::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:06:02 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::55) by AM6PR10CA0061.outlook.office365.com (2603:10a6:209:80::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 14:06:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:06:02 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Mar 2023 14:05:59 +0000 Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Mon, 20 Mar 2023 14:05:59 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , , , , Subject: [PATCH v1 2/4] DynamicTablesPkg: Fix parsing of serial port node Date: Mon, 20 Mar 2023 14:05:55 +0000 Message-ID: <20230320140557.40348-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20230320140557.40348-1-sami.mujawar@arm.com> References: <20230320140557.40348-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT032:EE_|PAVPR08MB9259:EE_|DBAEUR03FT015:EE_|DB9PR08MB8625:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dc7478e-66be-4a19-03f4-08db294c4326 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f4f/VFBkXiNWp7vtCFPY7imbQtNw3FfOTFW1shjGyl9Bk4xfWKdcGwEmreDhjJr0dXpU4g5KNw5nwJrXvDFcufFgbA4tM4NhG3EshD6YnzafsMQpiTwwJewmgL0DWiYEe26sb4zc0JM4c8bemppheZtmrrvLHt5B6aYP4z+3TocF5cgaTWiSwLvdBudpjrGfegDMy7jj7NsXSeEz1a9T/KzxJUezf26LtXBDAWeWEue7p2efTVHzlr7rD4aL1q0f+FNqq5f1wZEpRvakgvwKQbebyOb0OVwwfFAPeRAhu224aSTrE9X84md0OVmjWKIiwHWdYegObo0P7U2yAacgOnDZrD2KduogPWaRV1pleFtWWc5qg57RILElxkv4oRv4gQc3Px/ZdGks0BC8Iybdqo4SPbEgPZoAs/CG79ShkIcV8AJp9DMsUKbQNBSgDODcYpKH9LW+LEP6mSMlaLOPakTUyGHnQoLrXgRhnpmX1xeaB6Vg8OQl5TeUQj1E6+/G2rV7xoBOOGO4DybRLXHYOdfDnlyYU5jL8kQe7WTi0xpsAGL9qiINb+5n89iAwl75J4tcJj9FnPvV/MoYLTMX2NDjKyBm4Q+u0TElqOlCtBKp1ibK/JzhEnxYlvG65XGSAQEa2eTuokYBmfb9LX1V7Yfv2HpiV4oxjPQollTe/WkENTnoT24iNFWVyJYY006FNbLGbDhfdAHwkPHMYxaEkdqwYYazUwfoCPk3IXpEjPI= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199018)(40470700004)(36840700001)(46966006)(41300700001)(36860700001)(70586007)(70206006)(4326008)(8676002)(6916009)(8936002)(356005)(40480700001)(2906002)(81166007)(86362001)(82310400005)(36756003)(44832011)(5660300002)(40460700003)(82740400003)(7696005)(47076005)(426003)(186003)(1076003)(26005)(336012)(6666004)(316002)(478600001)(54906003)(2616005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9259 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57a97419-163a-46fa-8f3e-08db294c3d6c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V0QprAXvh7BgJJHsQXWuDQ/0CDSqthvhSvLrQLSb+4ax8bG5dH9dyQt1ViD/PgNM0pEcJQJ7v+PACKGzUetI8+d0JB5l1aYoGIep+c7yDgPYGJkPy4CBxy1wyjh1rnZpTHcuXluZ7mGzgea864ssAjXW8jEcMd8cocSwXHbS5KyGcfUIKgKSS94MkouNz9eCOwVI4YxChLhIqhG6BIR22yKPZsnVFCrDt3E30YiXOClGD52WsAf8BWYaYXfhiDnUwbCCapH8ru7SDosq67cGznvGgD5BC757u25utfgBrd5OEfG/4Dn4wgkptdvkNhJpZ0uw1g6DB7xJxT0NpSe4VNCqYq7TwuhjeD/EJc0RGsw+kwMUqGL+To2saTGeVRN1u35fhp+cZAMWWgyuDoD4RXEtWhNo6qBQb2R2bn53Y8waZ4i5EjPj4QDjVzidUIJqgUaGHrigeciivjn5CsiuTq6mLpFIdueIi6JDkcBjDALuXxLAiaY8rIDFhfTnQYhuf1gV+kixf21JfeGFyR5GpFHdr5AfLwbuDsFa+98GwEi5LHOMPSOERftOjjwETvfHgLTWE97r48nloUFIejB3m7L4IYv/M2zCZ1geItD8nuyQUpBph8S2rC4duV9z63xZ6zUQI3FYH1AjHIGfGnY1DXxsoxI5wqcASogBCE0p/YPEqn5lVcFWMhXyJliD22xyiYUdBs7ka5BVh6rnOioDTA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199018)(46966006)(40470700004)(36840700001)(316002)(40480700001)(83380400001)(41300700001)(36756003)(2906002)(40460700003)(336012)(54906003)(82310400005)(2616005)(6916009)(70586007)(8676002)(4326008)(70206006)(5660300002)(44832011)(8936002)(426003)(47076005)(186003)(7696005)(86362001)(6666004)(81166007)(82740400003)(1076003)(478600001)(36860700001)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 14:06:12.3719 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc7478e-66be-4a19-03f4-08db294c4326 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8625 Content-Type: text/plain When scanning for the Serial Port in the device tree, the length and value parameters to ScanMem8() are not in the right order. This results in the serial port not being detected if the chosen node in the device tree has additional elements. Therefore, pass the parameters to ScanMem8() in the correct order to fix this issue. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c index cfd032df4d746ad2a414a0258d99fe670f1928a2..732b482eebe3754543167e45737e48242fddf065 100644 --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c @@ -1,7 +1,7 @@ /** @file Arm Serial Port Parser. - Copyright (c) 2021, ARM Limited. All rights reserved.
+ Copyright (c) 2021 - 2023, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @par Reference(s): @@ -290,7 +290,7 @@ GetSerialConsoleNode ( } // Determine the actual path length, as a colon terminates the path. - Path = ScanMem8 (Prop, ':', PropSize); + Path = ScanMem8 (Prop, PropSize, ':'); if (Path == NULL) { PathLen = (UINT32)AsciiStrLen (Prop); } else { -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'