From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.25400.1679430038527149542 for ; Tue, 21 Mar 2023 13:20:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=amZXZAFm; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: mateusz.albecki@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679430038; x=1710966038; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LIy08M82JoLFygdHujrGmhQ1kdRj6mVCqvho5fiZ6UA=; b=amZXZAFm7lNB9hGZu1MNnZgYb7mnLPbLtX2p/JNQF0ClkzobJGb8JP4V lwAUgUKouNj15Nw8s8IsktL9JR23gMe8ZsKq8eaZ0vqkZbno3LONLiTvX Y50npW8DJbcBKCE5vmNvMj7qFSkKy6LHZdHJ5i0kHvripZhH93i6/lrOq 9D2//AgHk2cQtFACT6dSQACECPLLV0Jl0tEbt9PsFFNHqafd+C3j6Qluu lG3afq6F0Q9eG8dxonBSQav4Mq5HbfadCUNWpnVsLRaAIkiS1Z3Uw9V0j 48bqTaPu2YnwwNVvymGwbmAeraF+o4eh909USilPSyDqw1xkFWDyeZHYI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="401623757" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="401623757" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 13:20:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="1011100994" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="1011100994" Received: from malbecki-mobl1.ger.corp.intel.com ([10.213.7.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 13:20:31 -0700 From: "Albecki, Mateusz" To: devel@edk2.groups.io Cc: Mateusz Albecki , Hao A Wu , Ray Ni , Hunter Chang Subject: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors Date: Tue, 21 Mar 2023 21:20:14 +0100 Message-Id: <20230321202015.1877-1-mateusz.albecki@intel.com> X-Mailer: git-send-email 2.39.1.windows.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Fix for the recovery logic which causes hdd unlock to fail if user supplies incorrect password. Every failed packet used to be recovered which is causing the incorrect password to be tried multiple times. This patch series fixes the logic to only retry commands that failed due to CRC error. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 Github pull: https://github.com/tianocore/edk2/pull/4157 Tests: - tested basic linux boot from AHCI on qemu - tested basic linux boot from AHCI on custom qemu which will fail 50% of the DMA commands with CRC error. Observed that all of the packets that failed were successfully retried. Custom Qemu: https://github.com/matalbec/qemu/tree/sata_dma_50p_fail - additionally Hunter Chang tested and confirmed that the password issue is no longer observed. Cc: Hao A Wu Cc: Ray Ni Cc: Hunter Chang Mateusz Albecki (1): MdeModulePkg/Ahci: Skip retry for non-transient errors .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 69 +++++++++++++++++-- .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 3 +- 2 files changed, 67 insertions(+), 5 deletions(-) -- 2.39.1.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.