From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.42128.1679490207031895436 for ; Wed, 22 Mar 2023 06:03:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=I4RrZnQ+; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679490206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+r0Aw6vCTtsH6OxjHwc3zqO87jikLh2MNJ5bkD6L3c=; b=I4RrZnQ+0UGTzfr2MVRgFqDXIpghXt08U4UypmodM614LjbqUIMWYu4UOYOsRTjz7umHe9 zr4aIL9l+Mg1Ck0KWIEQ0/v9IbtzOghbTk49QQcQ/5PpERCOLlHZ5AF+Oi+67KioalssB6 ZTZZx0jE+E/69j+ioBImBn3olaXjoFU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-RR_izbc4MKeBRJwixizJ7w-1; Wed, 22 Mar 2023 09:03:22 -0400 X-MC-Unique: RR_izbc4MKeBRJwixizJ7w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CCC5A884347; Wed, 22 Mar 2023 13:03:21 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 367FC40C6E68; Wed, 22 Mar 2023 13:03:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B499818000A3; Wed, 22 Mar 2023 14:03:19 +0100 (CET) Date: Wed, 22 Mar 2023 14:03:19 +0100 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: Rebecca Cran , devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Ard Biesheuvel , Jordan Justen Subject: Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38 Message-ID: <20230322130319.nh2eobdudgjbm7uf@sirius.home.kraxel.org> References: <20230322013040.3322865-1-rebecca@bsdio.com> <20230322013040.3322865-4-rebecca@bsdio.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 22, 2023 at 01:32:01PM +0100, Ard Biesheuvel wrote: > On Wed, 22 Mar 2023 at 13:28, Rebecca Cran wrote: > > > > On 3/22/23 5:49 AM, Ard Biesheuvel wrote: > > > > > The reason I added CLANG3x support for ARM in the past is to ensure > > > compatibility with the ARM proprietary, Clang based toolchain. At the > > > time, we went with GNU ld, but I would actually prefer if we could > > > make this work with LLD as well. > > > > > > I can work around this issue locally by doing > > > > > > --- a/OvmfPkg/OvmfPkgX64.dsc > > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > > @@ -297,7 +297,7 @@ > > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf > > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf > > > -!if $(TOOL_CHAIN_TAG) == "XCODE5" > > > +!if $(TOOL_CHAIN_TAG) == "XCODE5" || $(TOOL_CHAIN_TAG) == "CLANGDWARF" > > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/Xcode5SecPeiCpuExceptionHandlerLib.inf > > > !else > > > > > > Can you please check whether this works for you as well? > > > > Thanks, that works here too! > > > > Do we still need to keep CLANG35 and CLANG38 toolchains for > > compatibility with the ARM toolchain? Or have things moved on so they > > _can_ be removed? > > > > No, please go ahead and merge all of those - the 35/38 naming is so > out of date it is likely to confuse people, so we should rename those > in any case. Same goes for all the GCC4x toolchains I guess ... take care, Gerd