From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: "Leif Lindholm" <quic_llindhol@quicinc.com>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Bob Feng" <bob.c.feng@intel.com>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Chao Li" <lichao@loongson.cn>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Yuwei Chen" <yuwei.chen@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Oliver Steffen" <osteffen@redhat.com>,
"Daniel Schaefer" <git@danielschaefer.me>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH 0/8] BaseTools: remove duplicate includes.
Date: Thu, 23 Mar 2023 12:17:25 +0100 [thread overview]
Message-ID: <20230323111733.690211-1-kraxel@redhat.com> (raw)
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over to use the include files in
MdePkg instead. It also cleans up some (apparently) obsolete code and
adapts BaseTools code in a few places to work with the MdePkg version of
the include files.
take care,
Gerd
Gerd Hoffmann (8):
BaseTools: remove WinNtInclude.h
BaseTools: remove duplicate includes: <arch>/ProcessorBind.h
BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h
MdePkg/PeImage.h: add bits from BaseTools version
BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks
BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*
BaseTools: remove duplicate includes: IndustryStandard/PeImage.h
BaseTools: remove duplicate includes: IndustryStandard/*.h
BaseTools/Source/C/Common/WinNtInclude.h | 66 --
BaseTools/Source/C/EfiRom/EfiRom.h | 14 +-
.../Source/C/Include/AArch64/ProcessorBind.h | 148 ----
.../Source/C/Include/Arm/ProcessorBind.h | 147 ----
.../Source/C/Include/Ia32/ProcessorBind.h | 155 ----
.../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
.../C/Include/IndustryStandard/Acpi1_0.h | 285 -------
.../C/Include/IndustryStandard/Acpi2_0.h | 520 ------------
.../C/Include/IndustryStandard/Acpi3_0.h | 668 ---------------
.../C/Include/IndustryStandard/Bluetooth.h | 56 --
.../C/Include/IndustryStandard/EfiPci.h | 51 --
...emoryMappedConfigurationSpaceAccessTable.h | 39 -
.../C/Include/IndustryStandard/PeImage.h | 778 ------------------
.../Source/C/Include/IndustryStandard/pci22.h | 536 ------------
.../Source/C/Include/IndustryStandard/pci23.h | 18 -
.../Source/C/Include/IndustryStandard/pci30.h | 38 -
.../C/Include/LoongArch64/ProcessorBind.h | 80 --
.../Source/C/Include/Protocol/DevicePath.h | 2 +-
.../Source/C/Include/RiscV64/ProcessorBind.h | 85 --
.../Source/C/Include/X64/ProcessorBind.h | 183 ----
MdePkg/Include/IndustryStandard/PeImage.h | 31 +
BaseTools/Source/C/Common/BasePeCoff.c | 51 +-
BaseTools/Source/C/Common/Decompress.c | 1 +
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 43 +-
BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +-
BaseTools/Source/C/GenFw/Elf64Convert.c | 12 +-
BaseTools/Source/C/GenFw/ElfConvert.c | 2 -
BaseTools/Source/C/GenFw/GenFw.c | 18 +-
BaseTools/Source/C/Makefiles/header.makefile | 15 +-
BaseTools/Source/C/Makefiles/ms.common | 13 +-
30 files changed, 112 insertions(+), 4068 deletions(-)
delete mode 100644 BaseTools/Source/C/Common/WinNtInclude.h
delete mode 100644 BaseTools/Source/C/Include/AArch64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/Arm/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/Ia32/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi1_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi2_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi3_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Bluetooth.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/EfiPci.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeImage.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci22.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci23.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci30.h
delete mode 100644 BaseTools/Source/C/Include/LoongArch64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/RiscV64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/X64/ProcessorBind.h
--
2.39.2
next reply other threads:[~2023-03-23 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 11:17 Gerd Hoffmann [this message]
2023-03-23 11:17 ` [PATCH 1/8] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-03-23 11:17 ` [PATCH 2/8] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-03-23 13:17 ` [edk2-devel] " Chao Li
2023-03-23 11:17 ` [PATCH 3/8] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-03-24 15:31 ` Sunil V L
2023-03-23 11:17 ` [PATCH 4/8] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-03-23 11:17 ` [PATCH 5/8] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-03-23 11:17 ` [PATCH 6/8] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-03-23 13:19 ` [edk2-devel] " Chao Li
2023-03-23 11:17 ` [PATCH 7/8] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-03-23 13:29 ` [edk2-devel] " Chao Li
2023-03-23 11:17 ` [PATCH 8/8] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323111733.690211-1-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox