From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.1342.1679675543650324347 for ; Fri, 24 Mar 2023 09:32:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=T8kr3kAh; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C67BC5C0199; Fri, 24 Mar 2023 12:32:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 24 Mar 2023 12:32:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1679675542; x=1679761942; bh=AZTxI7dA8P e5/CIkwhbalSF71Xdj81VlOJQ2+3DkLRI=; b=T8kr3kAhvpoUou9iWp8dT0YHFg sDue6JyA6K7YkuZJil2Huy9NyhMl/nr2pVr+19MRfzIfVmnE/W/AZ/FIJivrF6P9 lGXDXzMm/R9h0zkVbgBeqjvBv7Kr9RSAs5wgMtZKoOUmjHp99RYVlaRXjsteNdsg 9IBw2i95PKEYawZsv4je9V0235jNO06EP4aYICeRkyY1HsINsIb/9FGMCjK1w+ES gmz/tqoD7m7izGaeBIifIHK4EkzHtoGJaXuiQieNXMhzP3oUjh/S/t/tkTRdxCEd bEg8Wgw7OAfV8SWKkLgAHCWoo0Bizlz/nw7aOEAdZjHr477dSuLF+AyezRKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679675542; x=1679761942; bh=AZTxI7dA8Pe5/ CIkwhbalSF71Xdj81VlOJQ2+3DkLRI=; b=Rr2nSS92Z5Stck3eAiu0vsB0T1Jp+ rHPc0vR8324n6O4o/9H81n3aTBZaNvErYoP2FkGMN59r1LJfgRjo2NYJLRhRnOiB /LH+Z6RP7Dz+C+dl6TDZOxFeqtuD7+7A8I/mzN1drdxgt+yFq0EG0WkAmVUhPhKd 9Nb6S0P15hhxAQAYnlocKs0IOAefS5ls2dQVrAy4a31MHrHZZxtHtHGyxNw/boj8 2SbgGNcRRr/ZqQPiuWXKPkge/z4YsfgXtZG2Q20279Q52As+btu6OszOF3HxHqeZ XDH0c8cLl8wYoKTimngN0p4FB0PFrYE8/1NXfs3kajjbdk531uGHvXRoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheptfgvsggvtggt rgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrthhtvg hrnhepuedvkedtleekueekgfejjeettefftdduiefffeehveefgfevueelgffhleelgfdv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsg gvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 12:32:20 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen , Michael D Kinney Cc: Rebecca Cran Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for *.makefile Date: Fri, 24 Mar 2023 10:32:16 -0600 Message-Id: <20230324163216.2123281-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When checking for Makefiles, in addition to Makefile and GNUmakefile, also check for *.makefile: this allows {header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be detected and avoid having PatchCheck.py complain about tab characters. Signed-off-by: Rebecca Cran --- BaseTools/Scripts/PatchCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index fcdabfc8acea..3910015d173e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,8 @@ class GitDiffCheck: self.force_crlf = False self.force_notabs = False if os.path.basename(self.filename) == 'GNUmakefile' or \ - os.path.basename(self.filename) == 'Makefile': + os.path.basename(self.filename) == 'Makefile' or \ + os.path.basename(self.filename).endswith("makefile"): self.force_notabs = False elif len(line.rstrip()) != 0: self.format_error("didn't find diff command") -- 2.34.1