From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mx.groups.io with SMTP id smtpd.web11.6068.1679685413151417896 for ; Fri, 24 Mar 2023 12:16:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=GwPJ+bgI; spf=pass (domain: bsdio.com, ip: 64.147.123.21, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7D5643200077; Fri, 24 Mar 2023 15:16:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 24 Mar 2023 15:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1679685411; x=1679771811; bh=Y8rm3kdGWj ydXFa1PTnP30WQph1KbEGTjwdDSC4DtoA=; b=GwPJ+bgIG7cE7XlaRdIPxk2BQC 5eBMgutdp37KqJ5TyGE1DycgEACbLFZwwLdqs47CHVvIwIEAvAl5+/uYE83pMVM5 ioTV6v+YgXZbPNmGihSo3JXZG+nAeE/B97gHfSbxtGF2nJL8d+QzF9cQstELsSbb rMQ6LzC3lt8bynaun5zqisb1wLAMUUpqL7ayoHKb69xctqkMBO8PBcp9C5Yl+tQj 51/KR/l1dmX2qNO7EkEQBJI3WEeTE9elevn+R18/xkvLeh6qctevV0EMOV5a60ek PK0vFoZy0p8jTZWSofhqaB/H36bjR5RbeK0nHJ1PPiywqBHSZxI5d9NnLXUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679685411; x=1679771811; bh=Y8rm3kdGWjydX Fa1PTnP30WQph1KbEGTjwdDSC4DtoA=; b=TkQeakWqmDD0pniIb9Ap2LTuVm+1p qoxG4uQZ/G4mJFr9PQnc3V1oYp710AVM5EcFDxlD6FLzL1gLat59miuM1wpl8RR4 uhG7ffi/EYEumnDlmT2AiBdQYGG7I5kVMSyWkR9JDvcuw1H3m/WJ0erC3kCgA0sc oYk66OqBzSDyRReLZakNcDv4dH8kngy1MwPOtLQ24gp++Klx5sIEXDJ2HbKyal/v SYLsMSmyKqjhYgQKo6ZZ8xOb7cZc8qmX3lpt9W+4aFnbLLURuxE0m7GxrJZWrjW1 HK8rBYsm55VCuwz6eP180AInBrXVsIkYLtm7xMU+ey3YTNHjT5N8S4qSA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeftvggsvggt tggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrghtth gvrhhnpeeuvdektdelkeeukefgjeejteetffdtudeiffefheevfefgveeulefghfellefg vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvg gsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 15:16:49 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen , Michael D Kinney Cc: Rebecca Cran Subject: [PATCH v2 1/1] BaseTools/Scripts/PatchCheck.py: Improve check for Makefiles Date: Fri, 24 Mar 2023 13:16:44 -0600 Message-Id: <20230324191644.2534459-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When checking for Makefiles, also check for *.makefile: this allows {header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be detected and avoid having PatchCheck.py complain about tab characters. Also, change the check for "Makefile" to be case-insensitive since there are some Makefiles named 'makefile' instead of 'Makefile'. Signed-off-by: Rebecca Cran --- BaseTools/Scripts/PatchCheck.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index fcdabfc8acea..241467f10ea5 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -383,7 +383,8 @@ class GitDiffCheck: self.force_crlf = False self.force_notabs = False if os.path.basename(self.filename) == 'GNUmakefile' or \ - os.path.basename(self.filename) == 'Makefile': + os.path.basename(self.filename).lower() == 'makefile' or \ + os.path.splitext(self.filename)[1] == ".makefile": self.force_notabs = False elif len(line.rstrip()) != 0: self.format_error("didn't find diff command") -- 2.34.1