From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.57]) by mx.groups.io with SMTP id smtpd.web10.59616.1679983173226833198 for ; Mon, 27 Mar 2023 22:59:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=BUJ5P4AW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.237.57, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ihWrUtAkPFG3YvQi5Q38q4G47rHFc/xNxlpziwcfkWRln2ZT+rd4hs3qIkT5p7NX5ERR96Rv0/WvKgnzWHVZoykH/pvHZWvknXv8IfI7nmqA1OYZf8KVf28bEYs+tibh9kHEbwMctcEFRdB1uMqctBMQSzyM43HCVpODG6+KAGEs+xEtIqNrLP+YzBAshEJhg249RDYUPqfdBEJSwg3t5nfYwyAH2oU/OAfU7fYJEfs3bmpnhRNRWjwrK0VapSjy7N13sYdEc4WS8z2lPAQqY8Kk5SfFHzryuaZ243xgde0CmBXATpyi1u8iU5RxTAWSv+BgiAGNg9L8BWBc56DKJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/wjNNEmQk+odo61HDvxOweXosOETU8j+2sOf8AcsrGo=; b=ZZbL1EBsE43vwkd7Ti0RTFO03Q5OETeC2BpY8sdQmQmXOwLgfTIedmtuqgr7Cp6sBd7eNAI+hRRfkPPHu5dv+UruTT5Srm0FBxCOVg2bIy0jocVHSHlGGje0+wtdciIEpMMZNqMK8DlLWD88WY1PpVHREyUSkk9/y1fDZGJFzoo65lk9kZQovU87xVbL28ILwtxzvVZIbhyidVBSqmYEsWertHmTaFigTvQymUrZl9Gl9Yhb1EkjEPw/iKNnGNU0SLH8laYcc+3VD1MGVphc50n27sIW2Fpxou00AimU7lyWrNoLpAfRyxTXhrYg+ujtNqY2WIH3yJUh3iy+5RqfgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/wjNNEmQk+odo61HDvxOweXosOETU8j+2sOf8AcsrGo=; b=BUJ5P4AWfXSwV54u093FbS+oCQUDMJTRwhXPt7Sq8fkYkwy61SxYKK5vfKLIhKz4fuwAXoAoRgM0rdbxF6Dmy0EsG2KAKd2dxAzhikzn73jA/fyLEbF80bPbYw5rpx9vDyX+zvSfBvGVSGY94scX91D5BRsoRNEEHo63aocWflPT0VHIMITJrq9Pi1LVI+R91jNqNaKIxuI1KuU7HiLiFiOp3g0zm+cb3rLemEJXiRri5SlhCFUTBSg7ZLrRpG5k3vnH/AadLI4FJG4xzBDME+7Cacx4QO5XP2Qf3tNZ0i2wuvyKDqk4ZGFaYvpRHMciaTlbmRxLfDvyLLTy97dJ+w== Received: from DM5PR07CA0120.namprd07.prod.outlook.com (2603:10b6:4:ae::49) by MN0PR12MB6247.namprd12.prod.outlook.com (2603:10b6:208:3c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.31; Tue, 28 Mar 2023 05:59:30 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::e1) by DM5PR07CA0120.outlook.office365.com (2603:10b6:4:ae::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.43 via Frontend Transport; Tue, 28 Mar 2023 05:59:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.22 via Frontend Transport; Tue, 28 Mar 2023 05:59:30 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 27 Mar 2023 22:59:20 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 27 Mar 2023 22:59:19 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Mon, 27 Mar 2023 22:59:18 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH 3/3] RedfishPkg: fix config handler driver issues Date: Tue, 28 Mar 2023 13:59:19 +0800 Message-ID: <20230328055919.267-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|MN0PR12MB6247:EE_ X-MS-Office365-Filtering-Correlation-Id: 5677ba36-018b-4896-9ae9-08db2f5198ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SSAHXcOn3/Kp/bLIDErkdhDQIbZJtH7wr/Zlp1SsE8b4a2s9Y3TA/LuMnB/L7sFOYM/lkCQuHs0Zew7XKTJ+iIKcK/8jfocWIg93YIzdI7h8YxZg+K8pjjLML6sB0GhbA4hBoq6Y1VaNYF5i4ALRgnKTjbLiZXLY3WBPunU21krL6GuIvN6T7ULRfZmFkd4/QtInbT0AVP58A50NHvA9CwynOS2KzY5M/wfvbZnW+QZV1ldiymI0Dqulbbm0GQ7d3so6bty7evPEpT0rpwE4zvE2MmXS4U8O94P4Dlx7VWkO4snn+kPdN1fZ+tLAYXIDDx8pe4IlANgSCDJHPn2Sd4QLEiT57Po3BVjrPD+5efTB9SNXRioQE5poVRZ1zZ1bK5sWBdsNetUq/QJr5vMHtu0BYfwy4OBjaiAHKDi6oROxtFvyu6kqyvJeafOAznVTheGtFdMBUK8kXVz7YuMjOYvEKN6qrRZwpKnhExv2VPxmjNg5z/mgeyVFUJrvAFnOnosJWeQ9aKuLaXS57BrLaQyF9eN+ZYdA3p9O1UVYcA/GE4b6ifT+31XPC+LvMHSYCHvw0zOKm0og6Gv8U1W6APopByjnt5pLil4V1KOLHoEu38RyDuX7eLU4va1EqrFpgcBFCfYNr0EhrvZHpEhQ7z0ZGonMTOT4aVr535gAy1lSd+WleFPP3EEY0hKLcibpHupzgi7/tjtl09KX7ahdoxf9VA2hvyGrxr0/vWfYD1lGu/IAz0b13tiXdQS6ox5k15NNeMQFr6xpQ4bXuFP3YkdDR5aivLYG2KoPATli6+c= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199021)(36840700001)(46966006)(40470700004)(107886003)(186003)(8936002)(356005)(7636003)(83380400001)(336012)(426003)(2616005)(47076005)(86362001)(26005)(1076003)(7696005)(2906002)(82310400005)(40460700003)(5660300002)(478600001)(40480700001)(82740400003)(6916009)(70206006)(70586007)(316002)(4326008)(41300700001)(8676002)(36756003)(34020700004)(36860700001)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 05:59:30.7395 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5677ba36-018b-4896-9ae9-08db2f5198ff X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6247 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Bug fix: - function stack fault - config handler driver requires the dependency of Redfish Credential Protocol - incorrect caller id installation when failed to perform init() - fix typo Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigHandlerDriver.inf | 4 ++-- .../RedfishConfigHandler/RedfishConfigHandlerCommon.c | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf= b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf index def91c7531..b167c6e1ee 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf @@ -4,6 +4,7 @@ # # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -56,5 +57,4 @@ gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event =20 [Depex] - TRUE - + gEdkIIRedfishCredentialProtocolGuid diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c index c3a7efd796..96aac125ee 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c @@ -2,6 +2,7 @@ The common code of EDKII Redfish Configuration Handler driver. =20 (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,7 +10,7 @@ =20 #include "RedfishConfigHandlerCommon.h" =20 -REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one Redfish se= rvice supproted +REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one Redfish se= rvice supported // on platform for the= BIOS // Redfish configurati= on. EFI_EVENT gEndOfDxeEvent =3D NULL; @@ -34,7 +35,7 @@ RedfishConfigOnEndOfDxe ( =20 Status =3D gCredential->StopService (gCredential, ServiceStopTypeSecureB= ootDisabled); if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop servic= e on EndOfDxe: %r", Status)); + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop servi= ce on EndOfDxe: %r", Status)); } =20 // @@ -62,7 +63,7 @@ RedfishConfigOnExitBootService ( =20 Status =3D gCredential->StopService (gCredential, ServiceStopTypeExitBoo= tService); if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop servic= e on ExitBootService: %r", Status)); + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop servi= ce on ExitBootService: %r", Status)); } } =20 @@ -225,7 +226,7 @@ RedfishConfigHandlerInitialization ( UINTN NumberOfHandles; EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; UINTN Index; - UINT32 Id; + UINT32 *Id; =20 Status =3D gBS->LocateHandleBuffer ( ByProtocol, @@ -257,6 +258,7 @@ RedfishConfigHandlerInitialization ( Status =3D ConfigHandler->Init (ConfigHandler, &gRedfishConfigData.Red= fishServiceInfo); if (EFI_ERROR (Status) && (Status !=3D EFI_ALREADY_STARTED)) { DEBUG ((DEBUG_ERROR, "ERROR: Failed to init Redfish config handler %= p.\n", ConfigHandler)); + continue; } =20 // --=20 2.40.0.windows.1