From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.112]) by mx.groups.io with SMTP id smtpd.web10.16861.1680064578866533910 for ; Tue, 28 Mar 2023 21:36:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=jIPwAjWJ; spf=pass (domain: os.amperecomputing.com, ip: 40.107.237.112, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAc7H8yK6l65IwhdcANbicii69tEE5eSBzNAGv4vW2i3e2tYPm9Cui3Soip994bG7n7QGFP0xr2rYtI9bkuj6FErzuQKWkeWJRY5GAK8jddYTGr1oIaqRiDF0HZ5YwMsdew7PiA1OwYmVmgcyqQD0tK5D/nw2tkjMV2E5af3EDy/n35/U6b3NI13mBOd02y7L1FyfsQZufdPT9KgenTOy7nIx6nrvODS7FINe71v4RAV0DnpbVIN3Zo6RBZfNc+MpCgwq6z2z40NVvc8UYkp4SismUr2q4ZtMQabmHPLaObKHv2Rb6sBeOxZ+jj+eCDyUaK+oF/OxR9rpkbolRKPCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N1TCNQYkNRDIrm/Pz63FUYecwXqPW518+jovhx+eGKc=; b=N0EYH0mu2/j8xDTznYDyMOziaaokI22KJ1ajgxiMqyTgrwRKnD1M0ATaP318JgkGlmGJpqI3qvOwNfHtaLSVDYX5iM5hVqf+91OQ9Z07IOIMU43xKiKEP5iwUZyRjDxn4yFu3ASb+9eYWzAdEh/sScpbLV2BtPIViy/xcHWJVmnUM0RNJPAPF/LOWcRdiF5CzZMyVRac1nVPonJIzydxa1s2RRsCX7phmhGQvSYd9l+OYbI1DHNWHtoF9O3YhCBrjkMAg5F6wf9lAcDecnNe2MFoRq2cN9uXmDdPdBCkICIs5jN4qgXJQvVw4oxszDn51K+ksACozdfJdyuelMz/7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N1TCNQYkNRDIrm/Pz63FUYecwXqPW518+jovhx+eGKc=; b=jIPwAjWJEAs3lQ+1kjtAMNLJCKNym7kM+O0vpp3vVNrt3ex7TMkuc81ROCk/jdgbjeZssInP610A2PML4/BglSHK7pqQ5XRbFnW7OQCiTePVs1+uKBD8C0T7PhssZKAAwjkcGNyBJQ/3E+Fr4MYcIzpap1bvcK+/pBLTO2+hULU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SN6PR01MB4446.prod.exchangelabs.com (2603:10b6:805:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.18; Wed, 29 Mar 2023 04:36:16 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99%5]) with mapi id 15.20.6254.015; Wed, 29 Mar 2023 04:36:16 +0000 From: "Nhi Pham" To: devel@edk2.groups.io CC: patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, Vu Nguyen , Nhi Pham Subject: [edk2-platforms][PATCH v2 3/9] JadePkg: PCIe: Add delay after releasing PERST Date: Wed, 29 Mar 2023 11:32:40 +0700 Message-ID: <20230329043246.495600-4-nhi@os.amperecomputing.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230329043246.495600-1-nhi@os.amperecomputing.com> References: <20230329043246.495600-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: TY2PR0101CA0042.apcprd01.prod.exchangelabs.com (2603:1096:404:8000::28) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|SN6PR01MB4446:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e8a5648-61af-4271-e388-08db300f223c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oS1EBJI/mtSamV5WWx/oanOyccgniPqBUJ+Hpx/WqPgCK/9z6qIJLmIYVpBIvxx4OKjrprNWBQoL9/9YV7ZyBfsvVMM2R4KJXi7yQ58wnTi5MMAu2aiDR9rGsF9vHM8gNvAXlDssVe6rJAVuQKY99sNTDz4PwBfv3a1xLTjo51di3Zv3S4UJ2EKJnxXwYz8rcLPYK1owDLC9ZyyZUfJgpG0mo+84HlnxXdEAzrkhGMa1JyA1QFIzP3EcnzaYwc4Dex4+x2Lc+cTW3Utr84qqz9DgsnDB8KaPElWuyu8xefkY5vksUexDjXkAiyrDu/gOBglRWx3dgbphSOaHyWj2ChYrnvmM95Ijd1MTJHGuTD+6qn4ruS9ZOdr5F7Mw5Qer1uKzvUqNn2HOmjgrBmDlsSlZxYLT1rRYa1EofbtxQOhxeL/9UW6t5MyOU75ciWbH2q+PoII8hQUa5sTLEQxFGIAuh8SITp1FbTv66vGfh07HnvrD2hymvDh2jz0qvyqy2l/Qf9m8GT+rBuhce9ghaOd10BfPrjE1YchxRhwD+6dXyWTT3iqECFNI7WN+TsFSh/AHY4cvffIKUCo092ydEIxRGhMBq5Xtut2FFCye2fE791KLxoix1QYMxX0DJIU7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(39850400004)(366004)(136003)(451199021)(86362001)(83380400001)(2616005)(5660300002)(186003)(6512007)(26005)(1076003)(8936002)(6506007)(107886003)(6666004)(6486002)(2906002)(4326008)(41300700001)(6916009)(52116002)(66946007)(54906003)(38100700002)(38350700002)(316002)(8676002)(66556008)(66476007)(478600001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PaKZEcJNJCPGcohLEG+RfTTCSEFaiuEO7uoYnYhrbA1DEo8xAfAf9el5WnIy?= =?us-ascii?Q?jWPQDZQ1lpAHEAYX/aKEMZWdWVlgzOQaEWuldOmNTjHQpEViTHRSTkqEqZ6r?= =?us-ascii?Q?HazCvd/eo2VefVjO2CbyERzxgqiCURClOGy/fcnti6wifNvLbTnc9ofRXFBQ?= =?us-ascii?Q?V0mIqT/hnTDaqefEF15Bt3sOB3tQLD5A1ss/OEyHZjoD7O5VnZ9n2yb481A+?= =?us-ascii?Q?uQqgatS+EidxIAoxEaMavO5KrPiZGVxdrfNlOtRlrTe6Y+8gW6sa4NatT8LV?= =?us-ascii?Q?ytnQPV0ZINAehbSSLSJqfJtaIp7Ew/ofKSXhpPikhmmsEPyC5KcWrgna68B6?= =?us-ascii?Q?K6FCoOp3KFBLXS3Ds5D8XWvuVdjforDQNWZ+eM241nxuavSfkWCk3/0Ujl6o?= =?us-ascii?Q?TtNrRmjHztDfXDWtd3/W5NHHhxVB9xaGyNw2nso++vB6sFYPE3c1tQvNGWLN?= =?us-ascii?Q?M+gjxYJzsEm1SryD449BeeMH94w+hqiNRoFhPG3Arhd1mFWqnvVHn5BgX3yL?= =?us-ascii?Q?K+kziEkRDuSX2W4ZBUsrUmExPeg6wSAR88ux585k/+7ogPKi/xtOImb/QBZQ?= =?us-ascii?Q?wpyTJVwRvwYJKS6anYyK4U6V/KuBbYnOsTtov69rluFFcU7oM5qrBBqxNOsH?= =?us-ascii?Q?nZKJKmV92PDBDaBt38LdcLLFD0mEmZbjMZjxbEu0QVvpceL12I26xavRB6Ao?= =?us-ascii?Q?52e3iVejpcJR0+OzycH+2yDOUoo29Rng2ygNob4hC9vugJZnypQ5Q91sVA/7?= =?us-ascii?Q?mOXf8HllzfY8h4IYc9sDXTIXKi4aZUvCEJnl3mk2cregyzylTMQalAFueQg6?= =?us-ascii?Q?o9A72rQuQlY06kw2aUedyXkGwriwTUhxauzsGnY4VTOEZRxAfdkdSHmuXDlt?= =?us-ascii?Q?YjZXchZEoE1w5x6b2sCsdbbc6l96ov5tEbFssXLng87W622pZdqvkj7/PRyi?= =?us-ascii?Q?hPNN+sCXEl0uFlKjVou5gJSWU+B9IBOnUgEkJtHhX+nqHfWochm4AZuOZ/Lp?= =?us-ascii?Q?uxZzzEsYvhXVgxUUJWS0LmSTBtpvnFtPJ93MuI63OVHK/PGeCE82ye5PV5wd?= =?us-ascii?Q?pgkAUY1Bk1maZbnCsm4HgznkV7Vl4IH68xhYhUSuVb63XoIl6h9MmnBgvjuR?= =?us-ascii?Q?+NZiaoHO95IQjp2mxCPRpPPlMJvgEEozME2/EfvEQoSAag6WrM6KsA8+mFCW?= =?us-ascii?Q?hEJjATBK3JXq6NPuC81fubOEG15pGN+Ek4VvF41ghFK4F8qJ8sXjcDdWbcKl?= =?us-ascii?Q?DAl5TQKGbMTJo+b80BZdebOJ9y8BCRCprw1jQvJvXBFZSKRchqlu41B6xQTj?= =?us-ascii?Q?ssdUyYZr3Nstu1NFGKd2vnfle3W2Oyjm82/JzI+plnJfGTmMtbo113+UX2Ni?= =?us-ascii?Q?l4BlIZ9Zdu/QGiGmL8GFoNa5zy+UyW/LFzpdwKVsi67ruHEwgDzUwYODcmMO?= =?us-ascii?Q?HCngBG6GH5VtPxZW/DBvqLfexnAq97Xk9tUT/x7894EWdm5uNzgo2zspNNz4?= =?us-ascii?Q?8xS5TPDwi+WorquX3/tHf3RJjlIkUL1C+3meiHd2fSFBxXEaDU1Cdt5UPMSo?= =?us-ascii?Q?fD0A4iKlKsibbMxr0jLF8hWFPGz2GkhLj4Pyfmwrg9XlDdjGLSTgcdRBOQ8C?= =?us-ascii?Q?GBsmlg06Ee/MQcUrBJwxpVU=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8a5648-61af-4271-e388-08db300f223c X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 04:36:16.3356 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QfuejTFXoWkhT6fa7GvBEIhdl+uBPzkAPGJoamWRLtcO5HhBGDcz82yFLevZJeJysWL+Yf4QRr22zY19XR8noqyJTekQqlUH1+PeU5BZUyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB4446 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Vu Nguyen According to PCIe specification, following exit from a Conventional Reset, some devices may require additional time before they are able to respond to Requests they receive, so this patch adds a delay after releasing the PERST signal. Signed-off-by: Nhi Pham --- .../Ampere/JadePkg/Library/BoardPcieLib/BoardPcieLib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Platform/Ampere/JadePkg/Library/BoardPcieLib/BoardPcieLib.c b/= Platform/Ampere/JadePkg/Library/BoardPcieLib/BoardPcieLib.c index f49764097219..5041eb726288 100644 --- a/Platform/Ampere/JadePkg/Library/BoardPcieLib/BoardPcieLib.c +++ b/Platform/Ampere/JadePkg/Library/BoardPcieLib/BoardPcieLib.c @@ -2,7 +2,7 @@ Pcie board specific driver to handle asserting PERST signal to Endpoint card. PERST asserting is via group of GPIO pins to CPLD as Platform Spec= ification. =20 - Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved. + Copyright (c) 2020 - 2023, Ampere Computing LLC. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -20,6 +20,8 @@ #define RCB_MAX_PERST_GROUPVAL 46 #define DEFAULT_SEGMENT_NUMBER 0x0F =20 +#define PCIE_PERST_DELAY (100 * 1000) // 100ms + VOID BoardPcieReleaseAllPerst ( IN UINT8 SocketId @@ -32,6 +34,8 @@ BoardPcieReleaseAllPerst ( for (GpioIndex =3D 0; GpioIndex < 6; GpioIndex++) { GpioModeConfig (GpioPin + GpioIndex, GpioConfigOutHigh); } + + MicroSecondDelay (PCIE_PERST_DELAY); } =20 /** @@ -81,7 +85,7 @@ BoardPcieAssertPerst ( } =20 // Keep reset as low as 100 ms as specification - MicroSecondDelay (100 * 1000); + MicroSecondDelay (PCIE_PERST_DELAY); } else { BoardPcieReleaseAllPerst (RootComplex->Socket); } --=20 2.25.1