From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.64]) by mx.groups.io with SMTP id smtpd.web11.17874.1680070454306320032 for ; Tue, 28 Mar 2023 23:14:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=iOQB3mmy; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.244.64, mailfrom: nicklew@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVwYHpRcoNTzGEWpGW49kWYQormCNneD+ae4gbQ6MEA0ffrEPY1+LVcA6taAhOWbFVTjvku40ZWXDXEdU0o+eisOZ28SZQy/Eu9khCeYivWgg8WOKozJourh6sJIDKCxKUpQGESxjrmf1QxgOayFtMjuWoZB7Z45vmaQFk0Z5oya0NSpfb/3B9KGQQLhOmLGclN5gsJ8MCn0ccTGBidP0nzk+Rj8HX1BBnm8DHIHDWS+36+54lLV/3Uhy+kz+xH6Dv2FU3ctUdRce7F7LN0At9owud9MmXhYD2465OwL48/nJNIMBk9CEILsCFE1EiQeAUbxo2OC4CaViiSFJT5gew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z/U/bb6rdyDFpqkW28QOpqfel7pouSYwPPgcXagmRhY=; b=KbmmaPsjH+K0ylWAQDpAm7iTDiZ74RhhTFkuJPZtESDSbnOdtqe4JqEVxTKN5Et/g4ISuIfTbPqhvqqcJ7eIAXHtpdWbgjLWRBwMfmHGRz5hEgfoRDDe8PP14QD1jQ/kPND5f3Vg5nhspUJlzfujcLyH+4xPcisU3IcJ7OHabOtf1VRQgimsf7W2Jxmjk3HlJ90sFAVnyAjikvZurrvUOQuRckvzOZMxTbR/nPfne2aoI2CufLszifXDlsWVS5Tga49m+XlCyW3ET/Q4TXAb55suD5OHuHvh6zLfAwbtIS2tuDdgGFXyvdFEIgbSX0NMP/WRW9c1CFFTYbrQ7znvGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/U/bb6rdyDFpqkW28QOpqfel7pouSYwPPgcXagmRhY=; b=iOQB3mmyhVs5y4M3TROewu2eY+1rhO5CS4bqvfnlTV90bMQExwulDYN2kqf07gJC1jWJ+G6yAZTuatvLYcSjQEc88ZqV+MiELEaJxi27LffUxOL1beZj9FDuH0EOfpDUJz/XmwqH46Y3YmQLfmzELFtG6sIWUi+QfzxmyvtAKiqCJYuFHDv2slA6aU//dsuX8L1qjBhLdCF45jzGHHK2S5plkZd0myQChVIQOisgf7d+ZNyCf5Wsn2jiIBgmULLJBYU9twwOJh6fWYb0wjx0A0GHWP6N5nMflsCEIUK4ynMTlaV5cm6MRXbkIAwlB3Fcr06MZ8Z/4SAleY25do5VOg== Received: from DM6PR03CA0030.namprd03.prod.outlook.com (2603:10b6:5:40::43) by DS0PR12MB7678.namprd12.prod.outlook.com (2603:10b6:8:135::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.30; Wed, 29 Mar 2023 06:14:12 +0000 Received: from DS1PEPF0000E630.namprd02.prod.outlook.com (2603:10b6:5:40:cafe::37) by DM6PR03CA0030.outlook.office365.com (2603:10b6:5:40::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.43 via Frontend Transport; Wed, 29 Mar 2023 06:14:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0000E630.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.30 via Frontend Transport; Wed, 29 Mar 2023 06:14:12 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 28 Mar 2023 23:13:58 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 28 Mar 2023 23:13:58 -0700 Received: from NV-CL38DL3.nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.5 via Frontend Transport; Tue, 28 Mar 2023 23:13:57 -0700 From: "Nickle Wang" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [PATCH v2 3/3] RedfishPkg: fix config handler driver issues Date: Wed, 29 Mar 2023 14:13:57 +0800 Message-ID: <20230329061357.357-1-nicklew@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Return-Path: nicklew@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E630:EE_|DS0PR12MB7678:EE_ X-MS-Office365-Filtering-Correlation-Id: 3319c257-e310-4632-67af-08db301cd0dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H0+xO3znRpDdoonCfOvXxtm0edlYIk4m22I9x3N1xbOIXOzEFFOArXl+R0aEXxNIeU802z7OevA91ff7/60sTbItGESCNRGdrHlAxB4pzoxAwfHBfqZxtCopUF2ZNI7PYqv2we71gUWLIbCXyoZHmiP75mH+W1CmWX1iEsfy+ntxRIkqMIL/+ruAt/w8ssE8wFbCv67eIpd8m5D0H0jENNWnV84uiarQP19k3zttUtTByvGrQzH6m36tzLgHbc9AOVHXMuyMavSEyU/rUFTzOHQD2xSzAxrvLaPLN/lYjJDkMTGBb8vFjwfpU0jN/Z87Hm4JuA2zMkcjqj2bS3L/rny8Qn2li9G4n3TFD1Qw39sprbm9OYF98eI4deJfNJXS2byrnTV/wFrRRuJS4RCd6MMbkCu22nFEjcHS5KWwswgyhppvpiY6oAnHjHpaAFmLuH+ruPpoEQ222J9yObMG6T9MtcU4BptTv1o2/iXYDHT0u/7M7Lu5lmdJIsY+0nZ47m+jqV6h7t7r40hLiW4UbvOHvRCZX6Z6PG6OlsxsHwPVhNBI3QW4v95RdenO/rpykWW3WQqZ7UbLCkLul61xXEEgZJrq/GN92YAwvRKtbsidpLnOoKflsFEz0mC/qeVpz/H4gJFQN0xgJ+iaZv7H6ck/QZOIsds734C4TIXunrh81TBawyuVXHQtL+PuKiRkIY/LxLDEEtCtbPL5qwhzfezgsH6GecUY8ZF3eXA4puyP67EB/wKt7U1/k7Pej2fy X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(2906002)(40460700003)(83380400001)(36756003)(5660300002)(82740400003)(356005)(7636003)(40480700001)(8936002)(82310400005)(336012)(426003)(86362001)(7696005)(2616005)(41300700001)(107886003)(54906003)(47076005)(26005)(1076003)(316002)(478600001)(36860700001)(186003)(4326008)(8676002)(70206006)(70586007)(6916009);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 06:14:12.2973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3319c257-e310-4632-67af-08db301cd0dc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E630.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7678 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Bug fix: - function stack fault - config handler driver requires the dependency of Redfish Credential Protocol - incorrect caller id installation when failed to perform init() - fix typo Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- .../RedfishConfigHandlerDriver.inf | 4 ++-- .../RedfishConfigHandler/RedfishConfigHandlerCommon.c | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf= b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf index def91c7531..b167c6e1ee 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf @@ -4,6 +4,7 @@ # # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -56,5 +57,4 @@ gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event =20 [Depex] - TRUE - + gEdkIIRedfishCredentialProtocolGuid diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c b= /RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c index c3a7efd796..96aac125ee 100644 --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c @@ -2,6 +2,7 @@ The common code of EDKII Redfish Configuration Handler driver. =20 (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+ Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -9,7 +10,7 @@ =20 #include "RedfishConfigHandlerCommon.h" =20 -REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one Redfish se= rvice supproted +REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one Redfish se= rvice supported // on platform for the= BIOS // Redfish configurati= on. EFI_EVENT gEndOfDxeEvent =3D NULL; @@ -34,7 +35,7 @@ RedfishConfigOnEndOfDxe ( =20 Status =3D gCredential->StopService (gCredential, ServiceStopTypeSecureB= ootDisabled); if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop servic= e on EndOfDxe: %r", Status)); + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop servi= ce on EndOfDxe: %r", Status)); } =20 // @@ -62,7 +63,7 @@ RedfishConfigOnExitBootService ( =20 Status =3D gCredential->StopService (gCredential, ServiceStopTypeExitBoo= tService); if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop servic= e on ExitBootService: %r", Status)); + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop servi= ce on ExitBootService: %r", Status)); } } =20 @@ -225,7 +226,7 @@ RedfishConfigHandlerInitialization ( UINTN NumberOfHandles; EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; UINTN Index; - UINT32 Id; + UINT32 *Id; =20 Status =3D gBS->LocateHandleBuffer ( ByProtocol, @@ -257,6 +258,7 @@ RedfishConfigHandlerInitialization ( Status =3D ConfigHandler->Init (ConfigHandler, &gRedfishConfigData.Red= fishServiceInfo); if (EFI_ERROR (Status) && (Status !=3D EFI_ALREADY_STARTED)) { DEBUG ((DEBUG_ERROR, "ERROR: Failed to init Redfish config handler %= p.\n", ConfigHandler)); + continue; } =20 // --=20 2.40.0.windows.1