public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout
@ 2023-03-30 15:15 Michael D Kinney
  2023-03-30 15:27 ` [edk2-devel] " Ard Biesheuvel
  2023-03-30 17:46 ` Michael Kubacki
  0 siblings, 2 replies; 3+ messages in thread
From: Michael D Kinney @ 2023-03-30 15:15 UTC (permalink / raw)
  To: devel; +Cc: Sean Brogan, Michael Kubacki, Liming Gao

Increase the CI agent timeout to boot to UEFI Shell from
1 minute to 2 minutes.  There have been a few cases where
the boot to shell in QEMU has not quite completed in 1
minute and it is failing the CI check and preventing a PR
from being merged.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 .azurepipelines/templates/platform-build-run-steps.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azurepipelines/templates/platform-build-run-steps.yml
index 087f460d7fec..8be46cda0e2d 100644
--- a/.azurepipelines/templates/platform-build-run-steps.yml
+++ b/.azurepipelines/templates/platform-build-run-steps.yml
@@ -116,7 +116,7 @@ steps:
     filename: stuart_build
     arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=${{ parameters.tool_chain_tag}} TARGET=${{ parameters.build_target}} -a ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ parameters.run_flags }} --FlashOnly
   condition: and(and(gt(variables.pkg_count, 0), succeeded()), eq(variables['Run'], true))
-  timeoutInMinutes: 1
+  timeoutInMinutes: 2
 
 # Copy the build logs to the artifact staging directory
 - task: CopyFiles@2
-- 
2.39.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout
  2023-03-30 15:15 [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout Michael D Kinney
@ 2023-03-30 15:27 ` Ard Biesheuvel
  2023-03-30 17:46 ` Michael Kubacki
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-03-30 15:27 UTC (permalink / raw)
  To: devel, michael.d.kinney; +Cc: Sean Brogan, Michael Kubacki, Liming Gao

On Thu, 30 Mar 2023 at 17:17, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Increase the CI agent timeout to boot to UEFI Shell from
> 1 minute to 2 minutes.  There have been a few cases where
> the boot to shell in QEMU has not quite completed in 1
> minute and it is failing the CI check and preventing a PR
> from being merged.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  .azurepipelines/templates/platform-build-run-steps.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azurepipelines/templates/platform-build-run-steps.yml
> index 087f460d7fec..8be46cda0e2d 100644
> --- a/.azurepipelines/templates/platform-build-run-steps.yml
> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
> @@ -116,7 +116,7 @@ steps:
>      filename: stuart_build
>      arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=${{ parameters.tool_chain_tag}} TARGET=${{ parameters.build_target}} -a ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ parameters.run_flags }} --FlashOnly
>    condition: and(and(gt(variables.pkg_count, 0), succeeded()), eq(variables['Run'], true))
> -  timeoutInMinutes: 1
> +  timeoutInMinutes: 2
>
>  # Copy the build logs to the artifact staging directory
>  - task: CopyFiles@2
> --
> 2.39.1.windows.1
>
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout
  2023-03-30 15:15 [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout Michael D Kinney
  2023-03-30 15:27 ` [edk2-devel] " Ard Biesheuvel
@ 2023-03-30 17:46 ` Michael Kubacki
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Kubacki @ 2023-03-30 17:46 UTC (permalink / raw)
  To: devel, michael.d.kinney; +Cc: Sean Brogan, Liming Gao

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 3/30/2023 11:15 AM, Michael D Kinney wrote:
> Increase the CI agent timeout to boot to UEFI Shell from
> 1 minute to 2 minutes.  There have been a few cases where
> the boot to shell in QEMU has not quite completed in 1
> minute and it is failing the CI check and preventing a PR
> from being merged.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   .azurepipelines/templates/platform-build-run-steps.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azurepipelines/templates/platform-build-run-steps.yml
> index 087f460d7fec..8be46cda0e2d 100644
> --- a/.azurepipelines/templates/platform-build-run-steps.yml
> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
> @@ -116,7 +116,7 @@ steps:
>       filename: stuart_build
>       arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=${{ parameters.tool_chain_tag}} TARGET=${{ parameters.build_target}} -a ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{ parameters.run_flags }} --FlashOnly
>     condition: and(and(gt(variables.pkg_count, 0), succeeded()), eq(variables['Run'], true))
> -  timeoutInMinutes: 1
> +  timeoutInMinutes: 2
>   
>   # Copy the build logs to the artifact staging directory
>   - task: CopyFiles@2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-30 17:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 15:15 [Patch 1/1] .azurepipelines/templates: Increase run to shell timeout Michael D Kinney
2023-03-30 15:27 ` [edk2-devel] " Ard Biesheuvel
2023-03-30 17:46 ` Michael Kubacki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox