* [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change @ 2023-03-30 20:04 Rebecca Cran 2023-03-30 20:04 ` [PATCH edk2-basetools 1/1] " Rebecca Cran 2023-03-30 20:09 ` [edk2-devel] [PATCH edk2-basetools 0/1] " Michael D Kinney 0 siblings, 2 replies; 4+ messages in thread From: Rebecca Cran @ 2023-03-30 20:04 UTC (permalink / raw) To: devel, Bret Barkelew, Sean Brogan, Chris Fernald, Bob Feng, Michael Kubacki, Oliver Steffen, Liming Gao Cc: Rebecca Cran Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change This should be merged at the same time as the edk2 patch that supports passing CC and CXX to make when building BaseTools. Rebecca Cran (1): Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change edk2basetools/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH edk2-basetools 1/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change 2023-03-30 20:04 [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change Rebecca Cran @ 2023-03-30 20:04 ` Rebecca Cran 2023-03-30 20:09 ` [edk2-devel] [PATCH edk2-basetools 0/1] " Michael D Kinney 1 sibling, 0 replies; 4+ messages in thread From: Rebecca Cran @ 2023-03-30 20:04 UTC (permalink / raw) To: devel, Bret Barkelew, Sean Brogan, Chris Fernald, Bob Feng, Michael Kubacki, Oliver Steffen, Liming Gao Cc: Rebecca Cran In order to support building BaseTools using non-default compilers, a change is being made in the edk2 BaseTools directory to remove the 'BUILD_' prefix to CC, CXX, CFLAGS etc. so developers can for example run 'make CC=clang CXX=clang++' to build using clang. Update DscBuildData.py to generate Makefiles with CFLAGS instead of BUILD_CFLAGS. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- edk2basetools/Workspace/DscBuildData.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edk2basetools/Workspace/DscBuildData.py b/edk2basetools/Workspace/DscBuildData.py index ff5662f35702..38a5283389f9 100644 --- a/edk2basetools/Workspace/DscBuildData.py +++ b/edk2basetools/Workspace/DscBuildData.py @@ -89,7 +89,7 @@ def _IsFieldValueAnArray (Value): ''' WindowsCFLAGS = 'CFLAGS = $(CFLAGS) /wd4200 /wd4034 /wd4101 ' -LinuxCFLAGS = 'BUILD_CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable ' +LinuxCFLAGS = 'CFLAGS += -Wno-pointer-to-int-cast -Wno-unused-variable ' PcdMakefileEnd = ''' !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.common !INCLUDE $(BASE_TOOLS_PATH)\Source\C\Makefiles\ms.app -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change 2023-03-30 20:04 [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change Rebecca Cran 2023-03-30 20:04 ` [PATCH edk2-basetools 1/1] " Rebecca Cran @ 2023-03-30 20:09 ` Michael D Kinney 2023-03-30 20:10 ` Rebecca Cran 1 sibling, 1 reply; 4+ messages in thread From: Michael D Kinney @ 2023-03-30 20:09 UTC (permalink / raw) To: devel@edk2.groups.io, rebecca@bsdio.com, Barkelew, Bret, Sean Brogan, Chris Fernald, Feng, Bob C, Kubacki, Michael, Oliver Steffen, Gao, Liming Cc: Kinney, Michael D Rebecca, In order to avoid issues with the order or timing or merges, could CFLAGS be added in one set of patches and then later remove BUILD_CLAGS in a second set of patches? Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > Sent: Thursday, March 30, 2023 1:05 PM > To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris > Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; > Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: Rebecca Cran <rebecca@bsdio.com> > Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > This should be merged at the same time as the edk2 patch that supports > passing CC and CXX to make when building BaseTools. > > Rebecca Cran (1): > Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change > > edk2basetools/Workspace/DscBuildData.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.34.1 > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change 2023-03-30 20:09 ` [edk2-devel] [PATCH edk2-basetools 0/1] " Michael D Kinney @ 2023-03-30 20:10 ` Rebecca Cran 0 siblings, 0 replies; 4+ messages in thread From: Rebecca Cran @ 2023-03-30 20:10 UTC (permalink / raw) To: Kinney, Michael D, devel@edk2.groups.io, Barkelew, Bret, Sean Brogan, Chris Fernald, Feng, Bob C, Kubacki, Michael, Oliver Steffen, Gao, Liming Good idea. I'll send out a v2 patch with that change. On 3/30/23 2:09 PM, Kinney, Michael D wrote: > Rebecca, > > In order to avoid issues with the order or timing or merges, could > CFLAGS be added in one set of patches and then later remove BUILD_CLAGS > in a second set of patches? > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran >> Sent: Thursday, March 30, 2023 1:05 PM >> To: devel@edk2.groups.io; Barkelew, Bret <bret.barkelew@microsoft.com>; Sean Brogan <sean.brogan@microsoft.com>; Chris >> Fernald <chris.fernald@outlook.com>; Feng, Bob C <bob.c.feng@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>; >> Oliver Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn> >> Cc: Rebecca Cran <rebecca@bsdio.com> >> Subject: [edk2-devel] [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> This should be merged at the same time as the edk2 patch that supports >> passing CC and CXX to make when building BaseTools. >> >> Rebecca Cran (1): >> Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change >> >> edk2basetools/Workspace/DscBuildData.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> -- >> 2.34.1 >> >> >> >> >> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-30 20:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-30 20:04 [PATCH edk2-basetools 0/1] Change BUILD_CFLAGS to CFLAGS to match edk2 BaseTools change Rebecca Cran 2023-03-30 20:04 ` [PATCH edk2-basetools 1/1] " Rebecca Cran 2023-03-30 20:09 ` [edk2-devel] [PATCH edk2-basetools 0/1] " Michael D Kinney 2023-03-30 20:10 ` Rebecca Cran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox