* [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
@ 2023-03-30 20:44 Michael Kubacki
2023-03-30 21:08 ` [edk2-devel] " Michael D Kinney
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kubacki @ 2023-03-30 20:44 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Michael Kubacki, Michael D Kinney
From: Michael Kubacki <michael.kubacki@microsoft.com>
Adds caching of PIP dependencies. This reduces overall execution time
and decreases likelihood of a network error reaching out pypi to get
the dependencies.
Caching happens based on modules specified in pip-requirements.txt.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
.github/workflows/codeql-analysis.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index 791f79d1f014..33cc0bd6b46d 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -66,6 +66,8 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: '3.10.6'
+ cache: 'pip'
+ cache-dependency-path: 'pip-requirements.txt'
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
--
2.40.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
2023-03-30 20:44 [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching Michael Kubacki
@ 2023-03-30 21:08 ` Michael D Kinney
2023-04-02 0:30 ` Michael D Kinney
0 siblings, 1 reply; 3+ messages in thread
From: Michael D Kinney @ 2023-03-30 21:08 UTC (permalink / raw)
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Sean Brogan, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> Sent: Thursday, March 30, 2023 1:44 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Adds caching of PIP dependencies. This reduces overall execution time
> and decreases likelihood of a network error reaching out pypi to get
> the dependencies.
>
> Caching happens based on modules specified in pip-requirements.txt.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> .github/workflows/codeql-analysis.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
> index 791f79d1f014..33cc0bd6b46d 100644
> --- a/.github/workflows/codeql-analysis.yml
> +++ b/.github/workflows/codeql-analysis.yml
> @@ -66,6 +66,8 @@ jobs:
> uses: actions/setup-python@v4
> with:
> python-version: '3.10.6'
> + cache: 'pip'
> + cache-dependency-path: 'pip-requirements.txt'
>
> # Initializes the CodeQL tools for scanning.
> - name: Initialize CodeQL
> --
> 2.40.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#102209): https://edk2.groups.io/g/devel/message/102209
> Mute This Topic: https://groups.io/mt/97960009/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
2023-03-30 21:08 ` [edk2-devel] " Michael D Kinney
@ 2023-04-02 0:30 ` Michael D Kinney
0 siblings, 0 replies; 3+ messages in thread
From: Michael D Kinney @ 2023-04-02 0:30 UTC (permalink / raw)
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Sean Brogan, Kinney, Michael D
Merged:
PR: https://github.com/tianocore/edk2/pull/4227
Commit: https://github.com/tianocore/edk2/commit/b4af23aaab8a44341e43713a71cbebf23df2c27d
I verified that the caching is enabled and being used. You can view the caches here:
https://github.com/tianocore/edk2/actions/caches
Mike
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, March 30, 2023 2:08 PM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
> > Sent: Thursday, March 30, 2023 1:44 PM
> > To: devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching
> >
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > Adds caching of PIP dependencies. This reduces overall execution time
> > and decreases likelihood of a network error reaching out pypi to get
> > the dependencies.
> >
> > Caching happens based on modules specified in pip-requirements.txt.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> > .github/workflows/codeql-analysis.yml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
> > index 791f79d1f014..33cc0bd6b46d 100644
> > --- a/.github/workflows/codeql-analysis.yml
> > +++ b/.github/workflows/codeql-analysis.yml
> > @@ -66,6 +66,8 @@ jobs:
> > uses: actions/setup-python@v4
> > with:
> > python-version: '3.10.6'
> > + cache: 'pip'
> > + cache-dependency-path: 'pip-requirements.txt'
> >
> > # Initializes the CodeQL tools for scanning.
> > - name: Initialize CodeQL
> > --
> > 2.40.0.windows.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#102209): https://edk2.groups.io/g/devel/message/102209
> > Mute This Topic: https://groups.io/mt/97960009/1643496
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [michael.d.kinney@intel.com]
> > -=-=-=-=-=-=
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-02 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 20:44 [PATCH v1 1/1] .github/workflows/codeql-analysis.yml: Add PIP caching Michael Kubacki
2023-03-30 21:08 ` [edk2-devel] " Michael D Kinney
2023-04-02 0:30 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox