public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows
Date: Mon,  3 Apr 2023 18:32:56 -0600	[thread overview]
Message-ID: <20230404003256.2210620-1-rebecca@bsdio.com> (raw)

CC_FLAGS2 also needs to be set when running on Windows, otherwise the
wrong line is added and nmake fails when building using Visual Studio.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 edk2basetools/Workspace/DscBuildData.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/edk2basetools/Workspace/DscBuildData.py b/edk2basetools/Workspace/DscBuildData.py
index f6bf326018c6..8c402e189090 100644
--- a/edk2basetools/Workspace/DscBuildData.py
+++ b/edk2basetools/Workspace/DscBuildData.py
@@ -2895,6 +2895,7 @@ def GenerateByteArrayValue (self, StructuredPcds):
         CC_FLAGS2 = LinuxCFLAGS2
         if sys.platform == "win32":
             CC_FLAGS = WindowsCFLAGS
+            CC_FLAGS2 = WindowsCFLAGS
         BuildOptions = OrderedDict()
         for Options in self.BuildOptions:
             if Options[2] != EDKII_NAME:
-- 
2.34.1


             reply	other threads:[~2023-04-04  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  0:32 Rebecca Cran [this message]
2023-04-04  0:40 ` [edk2-devel] [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404003256.2210620-1-rebecca@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox