* [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows
@ 2023-04-04 0:32 Rebecca Cran
2023-04-04 0:40 ` [edk2-devel] " Michael D Kinney
0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2023-04-04 0:32 UTC (permalink / raw)
To: devel, Liming Gao, Yuwei Chen, Michael D Kinney; +Cc: Rebecca Cran
CC_FLAGS2 also needs to be set when running on Windows, otherwise the
wrong line is added and nmake fails when building using Visual Studio.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
edk2basetools/Workspace/DscBuildData.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/edk2basetools/Workspace/DscBuildData.py b/edk2basetools/Workspace/DscBuildData.py
index f6bf326018c6..8c402e189090 100644
--- a/edk2basetools/Workspace/DscBuildData.py
+++ b/edk2basetools/Workspace/DscBuildData.py
@@ -2895,6 +2895,7 @@ def GenerateByteArrayValue (self, StructuredPcds):
CC_FLAGS2 = LinuxCFLAGS2
if sys.platform == "win32":
CC_FLAGS = WindowsCFLAGS
+ CC_FLAGS2 = WindowsCFLAGS
BuildOptions = OrderedDict()
for Options in self.BuildOptions:
if Options[2] != EDKII_NAME:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows
2023-04-04 0:32 [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows Rebecca Cran
@ 2023-04-04 0:40 ` Michael D Kinney
0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2023-04-04 0:40 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@bsdio.com, Gao, Liming,
Chen, Christine
Cc: Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Monday, April 3, 2023 5:33 PM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Subject: [edk2-devel] [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows
>
> CC_FLAGS2 also needs to be set when running on Windows, otherwise the
> wrong line is added and nmake fails when building using Visual Studio.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> edk2basetools/Workspace/DscBuildData.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/edk2basetools/Workspace/DscBuildData.py b/edk2basetools/Workspace/DscBuildData.py
> index f6bf326018c6..8c402e189090 100644
> --- a/edk2basetools/Workspace/DscBuildData.py
> +++ b/edk2basetools/Workspace/DscBuildData.py
> @@ -2895,6 +2895,7 @@ def GenerateByteArrayValue (self, StructuredPcds):
> CC_FLAGS2 = LinuxCFLAGS2
> if sys.platform == "win32":
> CC_FLAGS = WindowsCFLAGS
> + CC_FLAGS2 = WindowsCFLAGS
> BuildOptions = OrderedDict()
> for Options in self.BuildOptions:
> if Options[2] != EDKII_NAME:
> --
> 2.34.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 0:32 [PATCH edk2-basetools 1/1] DscBuildData.py: set CC_FLAGS2 when running on Windows Rebecca Cran
2023-04-04 0:40 ` [edk2-devel] " Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox