public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default
@ 2023-04-05 17:02 Rebecca Cran
  2023-04-06  0:43 ` 回复: " gaoliming
  0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2023-04-05 17:02 UTC (permalink / raw)
  To: devel, Bob Feng, Liming Gao, Yuwei Chen, Michael D Kinney; +Cc: Rebecca Cran

Update the antlr makefile to remove the explicit setting of CC to either
clang or gcc. This causes it to use /usr/bin/cc or whatever the user has
set $(CC) to.

This removes the last dependency on gcc for BaseTools.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile b/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
index 42b603571fab..746d58b5e24e 100644
--- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
+++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
@@ -164,11 +164,6 @@ PCCTS_H=../h
 #
 #   UNIX  (default)
 #
-ifneq ($(CLANG),)
-CC?=$(CLANG_BIN)clang
-else ifeq ($(origin CC),default)
-CC=gcc
-endif
 COPT=-O
 ANTLR=${BIN_DIR}/antlr
 DLG=${BIN_DIR}/dlg
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* 回复: [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default
  2023-04-05 17:02 [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default Rebecca Cran
@ 2023-04-06  0:43 ` gaoliming
  0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2023-04-06  0:43 UTC (permalink / raw)
  To: 'Rebecca Cran', devel, 'Bob Feng',
	'Yuwei Chen', 'Michael D Kinney'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@bsdio.com>
> 发送时间: 2023年4月6日 1:03
> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> Michael D Kinney <michael.d.kinney@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>
> 主题: [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default
> 
> Update the antlr makefile to remove the explicit setting of CC to either
> clang or gcc. This causes it to use /usr/bin/cc or whatever the user has
> set $(CC) to.
> 
> This removes the last dependency on gcc for BaseTools.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
> b/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
> index 42b603571fab..746d58b5e24e 100644
> --- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
> +++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
> @@ -164,11 +164,6 @@ PCCTS_H=../h
>  #
>  #   UNIX  (default)
>  #
> -ifneq ($(CLANG),)
> -CC?=$(CLANG_BIN)clang
> -else ifeq ($(origin CC),default)
> -CC=gcc
> -endif
>  COPT=-O
>  ANTLR=${BIN_DIR}/antlr
>  DLG=${BIN_DIR}/dlg
> --
> 2.40.0




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-06  0:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-05 17:02 [PATCH 1/1] BaseTools: Update antlr makefile to use cc by default Rebecca Cran
2023-04-06  0:43 ` 回复: " gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox