From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.78]) by mx.groups.io with SMTP id smtpd.web10.172857.1680822769057300268 for ; Thu, 06 Apr 2023 16:12:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=LSCTSNVr; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.78, mailfrom: michael.roth@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDIxnGJE/RBfMoJ5RCubiguwlyK1MlWDrS+EEBOKRkMtfft1Sez1ZUfINhSPP/aY0tbgP5mjKkL1zizLUlE3/ccNAzPxTcwMsUXKeSian8mrsdXhnTktHlre1zvy+XQbwlQket/m5BCUrCqdttjkUhgDOUKXlRIZeY8cJ5N54X08txhlhN4V3IBq9U5YoqnNJa7Y8p37+dF+iuFnYCAW/dzcVfL6wibxcYdCE1SYM0FkjzifVsMWomrGqFl0nGpq5AgzaQkjuyORvZaEObP430xOB8fluP7RP1HrZzRZjDeDXkgPegdpNBA8A2XRiWkT4Xd/65iOsphtIdF1C2ZW9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMUoB3n2hxl8RHfDW0nV4YqbNxfy1ZHbkbARdC99t4A=; b=k+YBylLPaCO+EXMfDrxuD9fSUjqgVmdXCpVdmJ2evcS/UXkX0spvt842umFAdKdgjzh4j1WdVM3tuA1mezICLlt2B1962qtG0N7MXpI6tm3+sM73ba+mGo8oJXz0nCxpYtisIth4updnuzwwEAb570Ws3g3FQSWcWFeJuzC+6g8sw2QQnwEMwG2BVYIENwoDPWhQLU6qlQdO6SL54wP+8W/LsBAUaGg+ZqBQgqS6lTa0KH/rT1pXxv0OTBDfurNnbrfxMa9lkyFu1yipm8FwkuGvLZHYl7bhGFCU9IvT5E5KIseEYRdQWkLvHy25W6iCoHwYyAZEvSBNsoyS2TuK4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VMUoB3n2hxl8RHfDW0nV4YqbNxfy1ZHbkbARdC99t4A=; b=LSCTSNVrF8cUrRpFg9U9pKONgh5G+hHKakuNj14aVMZssQynV6Wt4TOfCfzYAQ8Ad2aZqXTs91LuYudtFS3UGy+KmYHj1IneB6VZhFaQnuux4nJd6NFVI1qsTJMLtbLjsq9th+L29ynVJVmx+IJqgsiZnQiYuk4K2dYHxyUk6pE= Received: from BN6PR17CA0044.namprd17.prod.outlook.com (2603:10b6:405:75::33) by MN2PR12MB4456.namprd12.prod.outlook.com (2603:10b6:208:266::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Thu, 6 Apr 2023 23:12:46 +0000 Received: from BN8NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:405:75:cafe::81) by BN6PR17CA0044.outlook.office365.com (2603:10b6:405:75::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31 via Frontend Transport; Thu, 6 Apr 2023 23:12:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT039.mail.protection.outlook.com (10.13.177.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6277.31 via Frontend Transport; Thu, 6 Apr 2023 23:12:46 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 6 Apr 2023 18:12:46 -0500 Date: Thu, 6 Apr 2023 18:12:24 -0500 From: "Roth, Michael" To: CC: Tom Lendacky , Jiewen Yao , , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu Subject: Re: [PATCH RESEND 0/4] Fixes for SEV-SNP CC blob and CPUID table handling Message-ID: <20230406231224.lt2r2we3d656nmib@amd.com> References: <20230315215747.1543837-1-michael.roth@amd.com> MIME-Version: 1.0 In-Reply-To: <20230315215747.1543837-1-michael.roth@amd.com> Return-Path: Michael.Roth@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT039:EE_|MN2PR12MB4456:EE_ X-MS-Office365-Filtering-Correlation-Id: 46da01c9-9710-4f98-8d45-08db36f46f02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4tqTbVSH9vlGOXioqJ6ZZTaRVhPfDBDQdXF58Jffb7+iL08XRIVFCJWYEHzlgqoWsm9A/uPhmZ8J9aFpUPGNYx5Yh95jLX1L+0oh1LXD05iAmJyfuzZQphsW8GdEj2wGg1pFOng0B0s/FUWPa1ZWfj8FPpG0UgRJ/tCBZqZIpls6qm+pDVnMzcTrt7xlbnE7A8mle9wmgo/2U7IjF+3WlpXM5flb/Ptzudp3VIociligr197CLfr9ZvYi+ldlTRc9MZTruBRHNw28BaK2Zzf8KHA4BFNVE8ozvXN1B27LT41YScmbsF2IDXnvn9Ukgq0asA8rUXLQ4llC2hN6FU8a2a4Githjk+8IrtBfhjRKjjE0Xa2BZO+Oe0Ex54TDS11vAszOp5eqDTdtWLgUgKpreVmjbhv68pDAwdSw4PPcWmMudrUTJwEnXsu74UP9Pv6w/ykp3EJNtKT+GamUj+4mRF1sOknL3UHdOsyommXnPz+3ErwBK783ZISkAIYfpBqhv3qxBkOGlTm+7M0qR2MMH+hedJAJ8ITQyuV+NeGBpLnkgWtPDNgUylKp9sTwPwntkSa/26nMPTI6cKnFoi3mHe4LBxOU0Rl9PtaLDV4yd06rV/XONzpF5YejIZfW897/NJDThbsHqzmXA786UzEJ28/9Rp9jPjcMXq5ROHqd8SwhquxTCJvN4ePS6RH1CxZOKlXA3u3yZTeX+8aMepBdalD/OxLRXfhsZluQCv3wAQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(5660300002)(82310400005)(82740400003)(478600001)(36860700001)(356005)(36756003)(70206006)(8676002)(6916009)(70586007)(81166007)(4326008)(86362001)(40480700001)(316002)(54906003)(41300700001)(8936002)(2616005)(44832011)(426003)(336012)(186003)(1076003)(26005)(2906002)(16526019)(6666004)(47076005)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 23:12:46.4946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46da01c9-9710-4f98-8d45-08db36f46f02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4456 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Mar 15, 2023 at 04:57:43PM -0500, Michael Roth wrote: > (Rebased series and resending due to merge conflict with previous > submission.) Ping. > > Here are a number of fixes related to OVMF handling of the SEV-SNP > Confidential Computing blob and CPUID table. > > Patch #1 is a fix for recently-reported issue that can cause > significant problems with some SEV-SNP guest operating systems. > Please consider applying this patch directly if the other > patches in this series are held up for any reason. > > Patches 2-4 are minor changes for things that aren't currently > triggered in practice, but make OVMF's SEV-SNP implementation more > robust for different build/hypervisor environments in the future. > Patch #2 was submitted previously, but refreshed here to apply > cleanly on top of Patch #1, with no other functional changes since > the initial review. > > ---------------------------------------------------------------- > Michael Roth (4): > OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory > OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition > OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation > OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP > > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++-------------- > OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h | 6 ++++-- > OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 13 +++++-------- > 3 files changed, 59 insertions(+), 24 deletions(-) > >