public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrei Warkentin" <andrei.warkentin@intel.com>
To: devel@edk2.groups.io
Cc: Andrei Warkentin <andrei.warkentin@intel.com>
Subject: [PATCH v7 0/3] RISC-V SBI-backed SerialLib
Date: Fri,  7 Apr 2023 16:44:22 -0500	[thread overview]
Message-ID: <20230407214425.4360-1-andrei.warkentin@intel.com> (raw)

Hello,

Here are three patches that provide a SerialLib backed by SBI console. 
Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles.

MdePkg reviewers: please review MdePkg.dsc changes.

This is also available at
https://github.com/andreiw/edk2-rv-wip/tree/patchset-2

A CI run is at https://github.com/tianocore/edk2/pull/4252

Compared to v6:

- Unify the two SerialLib implementations under one directory and
  factor out the code somewhat.
- Sunil's feedback on correctness.

Compared to v5:

Rename components as per Michael Kinney's suggestions.

Compared to v4:

(not sent out). CC MdePkg maintainers, fix copyright date in SecMain.c.

Compared to v3

EccCheck fixes. Add MdePkg infs to DSC.

Compared to v2:
- Probes legacy extension as well.
- Encode supported module types in the INF file. This is done using LIBRARY_CLASS,
  as MODULE_TYPE cannot encode multiple types, so MODULE_TYPE is retained as BASE.
- Update INF version and generate brand new GUIDs instead of editing them.
- Checked that all patches retain ^M endings.

Andrei Warkentin (3):
  MdePkg: BaseRiscVSbiLib: make more useful to consumers
  MdePkg: add SBI-based SerialPortLib for RISC-V
  OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

 MdePkg/MdePkg.dsc                                                               |   2 +
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf    |  40 +++
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf |  37 +++
 OvmfPkg/RiscVVirt/Sec/SecMain.inf                                               |   1 +
 MdePkg/Include/Library/BaseRiscVSbiLib.h                                        |  40 ++-
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h                            |  41 +++
 OvmfPkg/RiscVVirt/Sec/SecMain.h                                                 |   1 +
 MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.c                                |   3 +-
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c      | 208 ++++++++++++++
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c   | 289 ++++++++++++++++++++
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c                            | 132 +++++++++
 OvmfPkg/RiscVVirt/Sec/SecMain.c                                                 |   4 +-
 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni    |  16 ++
 13 files changed, 808 insertions(+), 6 deletions(-)
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.inf
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.inf
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.h
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.c
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLibRam.c
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/Common.c
 create mode 100644 MdePkg/Library/BaseSerialPortLibRiscVSbiLib/BaseSerialPortLibRiscVSbiLib.uni

-- 
2.25.1


             reply	other threads:[~2023-04-07 21:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 21:44 Andrei Warkentin [this message]
2023-04-07 21:44 ` [PATCH v7 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V Andrei Warkentin
2023-04-12  7:15   ` Sunil V L
2023-04-18 23:31     ` [edk2-devel] " Andrei Warkentin
2023-04-07 21:44 ` [PATCH v7 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec Andrei Warkentin
2023-04-08  2:22   ` [edk2-devel] " Yao, Jiewen
2023-04-07 22:08 ` [edk2-devel] [PATCH v7 0/3] RISC-V SBI-backed SerialLib Michael D Kinney
2023-04-25 19:26   ` Andrei Warkentin
2023-04-26  6:44     ` Sunil V L
     [not found]   ` <1759444C5DA596CB.10313@groups.io>
2023-05-11 20:25     ` Andrei Warkentin
     [not found]     ` <175E309BD5A0B986.27409@groups.io>
2023-05-17  4:58       ` Andrei Warkentin
2023-05-17  5:06         ` Michael D Kinney
2023-05-17  5:26           ` Andrei Warkentin
2023-05-17 18:03             ` Michael D Kinney
2023-05-17 23:47               ` Michael D Kinney
2023-05-18  3:36                 ` Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230407214425.4360-1-andrei.warkentin@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox