From: "Chen, Aryeh" <aryeh.chen@intel.com>
To: devel@edk2.groups.io
Cc: Aryeh Chen <aryeh.chen@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Isaac Oram <isaac.w.oram@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Eric Dong <eric.dong@intel.com>
Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.
Date: Thu, 13 Apr 2023 00:26:48 +0800 [thread overview]
Message-ID: <20230412162648.308-1-aryeh.chen@intel.com> (raw)
From: Aryeh Chen <aryeh.chen@intel.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4409
Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries
from board package.
Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 ++
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 ++
3 files changed, 6 insertions(+)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 6e57b638e0..e967031a3b 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1096,6 +1096,7 @@ PlatformUpdateTables (
case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE:
FadtHeader = (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table;
+ FadtHeader->Header.Revision = PcdGet8 (PcdFadtMajorVersion);
FadtHeader->PreferredPmProfile = PcdGet8 (PcdFadtPreferredPmProfile);
FadtHeader->IaPcBootArch = PcdGet16 (PcdFadtIaPcBootArch);
FadtHeader->Flags = PcdGet32 (PcdFadtFlags);
@@ -1113,6 +1114,7 @@ PlatformUpdateTables (
FadtHeader->Gpe1Blk = PcdGet16 (PcdAcpiGpe1BlockAddress);
FadtHeader->Gpe1BlkLen = PcdGet8 (PcdAcpiGpe1BlockLength);
FadtHeader->Gpe1Base = PcdGet8 (PcdAcpiGpe1Base);
+ FadtHeader->MinorVersion = PcdGet8 (PcdFadtMinorVersion);
FadtHeader->XPm1aEvtBlk.Address = PcdGet16 (PcdAcpiPm1AEventBlockAddress);
FadtHeader->XPm1bEvtBlk.Address = PcdGet16 (PcdAcpiPm1BEventBlockAddress);
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 451034fb8a..694492112b 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -67,6 +67,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion
gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index e6f714b181..784abb828e 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -346,6 +346,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025
gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026
gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x90000030
+ gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x90000031
[PcdsFixedAtBuild]
--
2.26.2.windows.1
next reply other threads:[~2023-04-12 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 16:26 Chen, Aryeh [this message]
2023-04-12 16:40 ` [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package Chiu, Chasel
2023-04-12 21:20 ` Isaac Oram
2023-04-14 15:56 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412162648.308-1-aryeh.chen@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox