public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.
@ 2023-04-12 16:26 Chen, Aryeh
  2023-04-12 16:40 ` Chiu, Chasel
  2023-04-14 15:56 ` Chiu, Chasel
  0 siblings, 2 replies; 4+ messages in thread
From: Chen, Aryeh @ 2023-04-12 16:26 UTC (permalink / raw)
  To: devel
  Cc: Aryeh Chen, Chasel Chiu, Nate DeSimone, Isaac Oram, Liming Gao,
	Eric Dong

From: Aryeh Chen <aryeh.chen@intel.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4409

Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries
from board package.

Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 2 ++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec               | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 6e57b638e0..e967031a3b 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1096,6 +1096,7 @@ PlatformUpdateTables (
   case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE:
     FadtHeader = (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table;
 
+    FadtHeader->Header.Revision                   = PcdGet8 (PcdFadtMajorVersion);
     FadtHeader->PreferredPmProfile                = PcdGet8 (PcdFadtPreferredPmProfile);
     FadtHeader->IaPcBootArch                      = PcdGet16 (PcdFadtIaPcBootArch);
     FadtHeader->Flags                             = PcdGet32 (PcdFadtFlags);
@@ -1113,6 +1114,7 @@ PlatformUpdateTables (
     FadtHeader->Gpe1Blk                           = PcdGet16 (PcdAcpiGpe1BlockAddress);
     FadtHeader->Gpe1BlkLen                        = PcdGet8 (PcdAcpiGpe1BlockLength);
     FadtHeader->Gpe1Base                          = PcdGet8 (PcdAcpiGpe1Base);
+    FadtHeader->MinorVersion                      = PcdGet8 (PcdFadtMinorVersion);
 
     FadtHeader->XPm1aEvtBlk.Address               = PcdGet16 (PcdAcpiPm1AEventBlockAddress);
     FadtHeader->XPm1bEvtBlk.Address               = PcdGet16 (PcdAcpiPm1BEventBlockAddress);
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 451034fb8a..694492112b 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -67,6 +67,8 @@
   gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
   gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
   gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion
 
   gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index e6f714b181..784abb828e 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -346,6 +346,8 @@
   gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025
   gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026
   gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x90000030
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x90000031
 
 [PcdsFixedAtBuild]
 
-- 
2.26.2.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.
  2023-04-12 16:26 [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package Chen, Aryeh
@ 2023-04-12 16:40 ` Chiu, Chasel
  2023-04-12 21:20   ` Isaac Oram
  2023-04-14 15:56 ` Chiu, Chasel
  1 sibling, 1 reply; 4+ messages in thread
From: Chiu, Chasel @ 2023-04-12 16:40 UTC (permalink / raw)
  To: Chen, Aryeh, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Oram, Isaac W, Gao, Liming, Dong, Eric



Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel



> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR
> REVISION to update FADT entries from board package.
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4409
> 
> Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from
> board package.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 2 ++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec               | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 6e57b638e0..e967031a3b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -1096,6 +1096,7 @@ PlatformUpdateTables (
>    case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE:
> FadtHeader = (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; +
> FadtHeader->Header.Revision                   = PcdGet8 (PcdFadtMajorVersion);
> FadtHeader->PreferredPmProfile                = PcdGet8
> (PcdFadtPreferredPmProfile);     FadtHeader->IaPcBootArch                      =
> PcdGet16 (PcdFadtIaPcBootArch);     FadtHeader->Flags                             =
> PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables (
>      FadtHeader->Gpe1Blk                           = PcdGet16 (PcdAcpiGpe1BlockAddress);
> FadtHeader->Gpe1BlkLen                        = PcdGet8 (PcdAcpiGpe1BlockLength);
> FadtHeader->Gpe1Base                          = PcdGet8 (PcdAcpiGpe1Base);+
> FadtHeader->MinorVersion                      = PcdGet8 (PcdFadtMinorVersion);
> FadtHeader->XPm1aEvtBlk.Address               = PcdGet16
> (PcdAcpiPm1AEventBlockAddress);     FadtHeader->XPm1bEvtBlk.Address
> = PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> index 451034fb8a..694492112b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> @@ -67,6 +67,8 @@
>    gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion
> gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git
> a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> index e6f714b181..784abb828e 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> @@ -346,6 +346,8 @@
> 
> gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9
> 0000025
> gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900
> 00026
> gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000
> 027+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000
> 30+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000
> 31  [PcdsFixedAtBuild] --
> 2.26.2.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.
  2023-04-12 16:40 ` Chiu, Chasel
@ 2023-04-12 21:20   ` Isaac Oram
  0 siblings, 0 replies; 4+ messages in thread
From: Isaac Oram @ 2023-04-12 21:20 UTC (permalink / raw)
  To: Chiu, Chasel, Chen, Aryeh, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Gao, Liming, Dong, Eric, Sinha, Ankit

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> 
Sent: Wednesday, April 12, 2023 9:41 AM
To: Chen, Aryeh <aryeh.chen@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.



Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel



> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel 
> <chasel.chiu@intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W 
> <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; 
> Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and 
> MINOR REVISION to update FADT entries from board package.
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4409
> 
> Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries 
> from board package.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 2 ++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec               | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git 
> a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 6e57b638e0..e967031a3b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -1096,6 +1096,7 @@ PlatformUpdateTables (
>    case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE:
> FadtHeader = (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; +
> FadtHeader->Header.Revision                   = PcdGet8 (PcdFadtMajorVersion);
> FadtHeader->PreferredPmProfile                = PcdGet8
> (PcdFadtPreferredPmProfile);     FadtHeader->IaPcBootArch                      =
> PcdGet16 (PcdFadtIaPcBootArch);     FadtHeader->Flags                             =
> PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables (
>      FadtHeader->Gpe1Blk                           = PcdGet16 (PcdAcpiGpe1BlockAddress);
> FadtHeader->Gpe1BlkLen                        = PcdGet8 (PcdAcpiGpe1BlockLength);
> FadtHeader->Gpe1Base                          = PcdGet8 (PcdAcpiGpe1Base);+
> FadtHeader->MinorVersion                      = PcdGet8 (PcdFadtMinorVersion);
> FadtHeader->XPm1aEvtBlk.Address               = PcdGet16
> (PcdAcpiPm1AEventBlockAddress);     FadtHeader->XPm1bEvtBlk.Address
> = PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git 
> a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> index 451034fb8a..694492112b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> @@ -67,6 +67,8 @@
>    gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion
> gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git 
> a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> index e6f714b181..784abb828e 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> @@ -346,6 +346,8 @@
> 
> gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9
> 0000025
> gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900
> 00026
> gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000
> 027+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000
> 30+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000
> 31  [PcdsFixedAtBuild] --
> 2.26.2.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package.
  2023-04-12 16:26 [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package Chen, Aryeh
  2023-04-12 16:40 ` Chiu, Chasel
@ 2023-04-14 15:56 ` Chiu, Chasel
  1 sibling, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2023-04-14 15:56 UTC (permalink / raw)
  To: Chen, Aryeh, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Oram, Isaac W, Gao, Liming, Dong, Eric


Patch merged:
https://github.com/tianocore/edk2-platforms/commit/3b7f82b61b552f5bdd415f1bf4ba2866a09ceac0

Thanks,
Chasel


> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Wednesday, April 12, 2023 9:27 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR
> REVISION to update FADT entries from board package.
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4409
> 
> Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from
> board package.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 2 ++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec               | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 6e57b638e0..e967031a3b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -1096,6 +1096,7 @@ PlatformUpdateTables (
>    case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE:
> FadtHeader = (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; +
> FadtHeader->Header.Revision                   = PcdGet8 (PcdFadtMajorVersion);
> FadtHeader->PreferredPmProfile                = PcdGet8
> (PcdFadtPreferredPmProfile);     FadtHeader->IaPcBootArch                      =
> PcdGet16 (PcdFadtIaPcBootArch);     FadtHeader->Flags                             =
> PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables (
>      FadtHeader->Gpe1Blk                           = PcdGet16 (PcdAcpiGpe1BlockAddress);
> FadtHeader->Gpe1BlkLen                        = PcdGet8 (PcdAcpiGpe1BlockLength);
> FadtHeader->Gpe1Base                          = PcdGet8 (PcdAcpiGpe1Base);+
> FadtHeader->MinorVersion                      = PcdGet8 (PcdFadtMinorVersion);
> FadtHeader->XPm1aEvtBlk.Address               = PcdGet16
> (PcdAcpiPm1AEventBlockAddress);     FadtHeader->XPm1bEvtBlk.Address
> = PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> index 451034fb8a..694492112b 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> @@ -67,6 +67,8 @@
>    gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
> gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion
> gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git
> a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> index e6f714b181..784abb828e 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> @@ -346,6 +346,8 @@
> 
> gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9
> 0000025
> gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900
> 00026
> gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000
> 027+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000
> 30+
> gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000
> 31  [PcdsFixedAtBuild] --
> 2.26.2.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-04-14 15:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 16:26 [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package Chen, Aryeh
2023-04-12 16:40 ` Chiu, Chasel
2023-04-12 21:20   ` Isaac Oram
2023-04-14 15:56 ` Chiu, Chasel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox