From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: "Sunil V L" <sunilvl@ventanamicro.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Rebecca Cran" <rebecca@bsdio.com>,
"Chao Li" <lichao@loongson.cn>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Oliver Steffen" <osteffen@redhat.com>,
"Bob Feng" <bob.c.feng@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Daniel Schaefer" <git@danielschaefer.me>,
"Yuwei Chen" <yuwei.chen@intel.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH v3 02/10] MdePkg: don't set visibility to hidden for BaseTools
Date: Thu, 13 Apr 2023 10:53:05 +0200 [thread overview]
Message-ID: <20230413085313.273483-3-kraxel@redhat.com> (raw)
In-Reply-To: <20230413085313.273483-1-kraxel@redhat.com>
Setting visibility to hidden can cause linker errors when BaseTools are
linked against standard libraries.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
MdePkg/Include/X64/ProcessorBind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/X64/ProcessorBind.h b/MdePkg/Include/X64/ProcessorBind.h
index f0a4d00142b9..98673456aad0 100644
--- a/MdePkg/Include/X64/ProcessorBind.h
+++ b/MdePkg/Include/X64/ProcessorBind.h
@@ -21,7 +21,7 @@
#pragma pack()
#endif
-#if defined (__GNUC__) && defined (__pic__) && !defined (USING_LTO) && !defined (__APPLE__)
+#if defined (__GNUC__) && defined (__pic__) && !defined (BASETOOLS) && !defined (USING_LTO) && !defined (__APPLE__)
//
// Mark all symbol declarations and references as hidden, meaning they will
// not be subject to symbol preemption. This allows the compiler to refer to
--
2.39.2
next prev parent reply other threads:[~2023-04-13 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 8:53 [PATCH v3 00/10] BaseTools: remove duplicate includes Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 01/10] BaseTools: add BASETOOLS define Gerd Hoffmann
2023-04-13 8:53 ` Gerd Hoffmann [this message]
2023-04-13 8:53 ` [PATCH v3 03/10] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 04/10] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 05/10] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 06/10] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 07/10] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 09/10] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-04-13 8:53 ` [PATCH v3 10/10] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
2023-04-13 12:51 ` [PATCH v3 00/10] BaseTools: remove duplicate includes Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413085313.273483-3-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox