From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7935.1681376003760335421 for ; Thu, 13 Apr 2023 01:53:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=idT7z9tP; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681376002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yZbjkxYVKqb7FN1I5wiOWxgIt1EydXPAbdLHz4V+qW8=; b=idT7z9tPm1LB6uFZbKPc/8wm/a3UmX3LZG99ZYSx00V8tqpzt0rVnUJfOI/ss21YoB56/s XCsQ5LQmxVv9z9RsG8XK4wdy17WvtElKf1lIZhVS/JAxedpuH5U6lmr4NdQ0qLJrLvO5sE U3oJKAdPYk+/SK7YddYFFqNjazeSIQ0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-527-7hgEuh5gNlusWh2mwtSmXA-1; Thu, 13 Apr 2023 04:53:17 -0400 X-MC-Unique: 7hgEuh5gNlusWh2mwtSmXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 01DDE185A78F; Thu, 13 Apr 2023 08:53:17 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2799404DC40; Thu, 13 Apr 2023 08:53:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BE2D118003B3; Thu, 13 Apr 2023 10:53:13 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Sunil V L , Zhiguang Liu , Rebecca Cran , Chao Li , Michael D Kinney , Pawel Polawski , Baoqi Zhang , Leif Lindholm , Dongyan Qian , Oliver Steffen , Bob Feng , Liming Gao , Ard Biesheuvel , =?UTF-8?q?Marvin=20H=C3=A4user?= , Daniel Schaefer , Yuwei Chen , Gerd Hoffmann Subject: [PATCH v3 02/10] MdePkg: don't set visibility to hidden for BaseTools Date: Thu, 13 Apr 2023 10:53:05 +0200 Message-Id: <20230413085313.273483-3-kraxel@redhat.com> In-Reply-To: <20230413085313.273483-1-kraxel@redhat.com> References: <20230413085313.273483-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Setting visibility to hidden can cause linker errors when BaseTools are linked against standard libraries. Signed-off-by: Gerd Hoffmann --- MdePkg/Include/X64/ProcessorBind.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/X64/ProcessorBind.h b/MdePkg/Include/X64/ProcessorBind.h index f0a4d00142b9..98673456aad0 100644 --- a/MdePkg/Include/X64/ProcessorBind.h +++ b/MdePkg/Include/X64/ProcessorBind.h @@ -21,7 +21,7 @@ #pragma pack() #endif -#if defined (__GNUC__) && defined (__pic__) && !defined (USING_LTO) && !defined (__APPLE__) +#if defined (__GNUC__) && defined (__pic__) && !defined (BASETOOLS) && !defined (USING_LTO) && !defined (__APPLE__) // // Mark all symbol declarations and references as hidden, meaning they will // not be subject to symbol preemption. This allows the compiler to refer to -- 2.39.2