From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.16258.1681398967183620947 for ; Thu, 13 Apr 2023 08:16:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=itve5/7T; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8ADC45C012C; Thu, 13 Apr 2023 11:16:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 13 Apr 2023 11:16:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1681398966; x=1681485366; bh=xlfzNPro7r ibhOMn3NnBbLVVXWZVpWfwpb8rkpNcETU=; b=itve5/7TOnFb/B5lzmyNFXjl69 +tzmU247w/usHMH/cOF7JVIBw8UzYIMqYIYX0ej1ESiz9i4+rD5ODMr9eGH71idv yoDMXoZia3tvysn2xQ49/UWOQQ6L+BVbYF2EvuBOV2wlQefQsSx994K7eK5WbwtC mcvaLbP4vtO3O6YQRynkS46lJlGKk2Xsu4GOqmbHzqqdC843EH1hGn9M63rRAqi5 D/jQ6tuI+qpb8SHCemIbPIiysxIImqWkTTNHylIPvlc3GVvlkEF0217ybB7RHLMd PT3EJeK30xuWB6qdUUQtUwzixvxPUQsqwJmUnFQHKMJoQMf6p7FUUJOvcUlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681398966; x=1681485366; bh=xlfzNPro7ribh OMn3NnBbLVVXWZVpWfwpb8rkpNcETU=; b=OeraZBADVROOvLTszEsGnxtBolK1a NN5jdmxGMvkSIcfoPDRx0H4h1W3NyoVdWyX/TX2WfVV1TYYEP82GkrVECLXRTHqV gMlMHqvWBJq90CmCsN0Tt7MPaJXrgC3x9fXqctmimANI/ZUHy0sIpYAzlN6Cy7Ci ptAFT/74+HGb0MJAAETQBL3dAGuO1DQRzm89UUqKSeHEdVmqRo5zcNwdCV5iOO8H 8tFyvWP01r/uOmJYQ6Ydiu301Sy+j0sfKR/Limydmikd7XBILVjHf+vtAP6whrgW tD5fIwpigcW1IV+o3eDpRDsC0JoaUZ/fAn7q5ugB1YDhMGE7WtxJOj9cA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekkedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheptfgvsggvtggt rgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrthhtvg hrnhepuedvkedtleekueekgfejjeettefftdduiefffeehveefgfevueelgffhleelgfdv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsg gvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Apr 2023 11:16:04 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Bob Feng , Yuwei Chen Cc: Rebecca Cran Subject: [PATCH v2 1/1] BaseTools: Update PatchCheck.py to check for __FUNCTION__ Date: Thu, 13 Apr 2023 09:16:00 -0600 Message-Id: <20230413151600.308196-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit New code should use the C99 macro __func__ instead of the pre-Standard macro __FUNCTION__. Update PatchCheck.py to reject patches with the latter. Signed-off-by: Rebecca Cran --- BaseTools/Scripts/PatchCheck.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 5d17d99a12ef..900226f18fe5 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -491,6 +491,12 @@ class GitDiffCheck: 'but DEBUG_' + mo.group(1) + ' is now recommended', line) + rp_file = os.path.realpath(self.filename) + rp_script = os.path.realpath(__file__) + if line.find('__FUNCTION__') != -1 and rp_file != rp_script: + self.added_line_error('__FUNCTION__ was used, but __func__ ' + 'is now recommended', line) + split_diff_re = re.compile(r''' (?P ^ diff \s+ --git \s+ a/.+ \s+ b/.+ $ -- 2.34.1