From: "Oliver Steffen" <osteffen@redhat.com>
To: devel@edk2.groups.io
Cc: Anthony Perard <anthony.perard@citrix.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Zhichao Gao <zhichao.gao@intel.com>,
Oliver Steffen <osteffen@redhat.com>
Subject: [PATCH v3 0/2] Set Firmware Version from build command line
Date: Thu, 13 Apr 2023 17:32:07 +0200 [thread overview]
Message-ID: <20230413153209.128585-1-osteffen@redhat.com> (raw)
ArmVirtXen.dsc allows setting the firmware version
string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
via FIRMWARE_VER variable conveniently on the build command line.
These two patches add this behavior to all .dsc files in ArmVirtPkg
and OvmfPkg.
PR: https://github.com/tianocore/edk2/pull/4268
v3:
- Introduce common include file for OVMF .dsc files
v2:
Address comments by Sami and Gerd:
- Only set PCD if FIRMWARE_VER is defined
- ArmVirt: move logic to ArmVirt.dsc.inc
https://edk2.groups.io/g/devel/message/95208
v1:
https://edk2.groups.io/g/devel/message/95057
Oliver Steffen (2):
OvmfPkg: allow setting Firmware Version from build command line
ArmVirtPkg: allow setting Firmware Version from build command line
ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++
OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++
ArmVirtPkg/ArmVirtXen.dsc | 1 -
OvmfPkg/OvmfPkgIa32.dsc | 3 +++
OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++
OvmfPkg/OvmfPkgX64.dsc | 5 ++++-
OvmfPkg/OvmfXen.dsc | 3 +++
7 files changed, 26 insertions(+), 2 deletions(-)
create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc
--
2.40.0
next reply other threads:[~2023-04-13 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 15:32 Oliver Steffen [this message]
2023-04-13 15:32 ` [PATCH v3 1/2] OvmfPkg: allow setting Firmware Version from build command line Oliver Steffen
2023-04-13 15:32 ` [PATCH v3 2/2] ArmVirtPkg: " Oliver Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413153209.128585-1-osteffen@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox