From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16596.1681399972993121980 for ; Thu, 13 Apr 2023 08:32:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L0N4PDSk; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681399971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OLLwR8ghqELvLY1KJtE2BnjiW3G60m4nZ7MoLTISvu4=; b=L0N4PDSklGq7w3ehtVz6BqKo4kYlDwkMYwyh4Ch4pRt+L5a40jNEfDMutYs0S8vMxpArgM po/O9YfHV6bF5YpuiC18nK4Kw6oX1jEmLqIgbTIy2p//MgE3QL6sWrQUmDTpxeo1aLADFM WkHYGnFgNrUQeRzvMh84OdzIj1TyAms= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-czIF8ythMoaSxKbzf2CW6Q-1; Thu, 13 Apr 2023 11:32:50 -0400 X-MC-Unique: czIF8ythMoaSxKbzf2CW6Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 10998185A792; Thu, 13 Apr 2023 15:32:50 +0000 (UTC) Received: from osteffen-laptop.redhat.com (unknown [10.39.195.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2E31C16028; Thu, 13 Apr 2023 15:32:36 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao , Oliver Steffen Subject: [PATCH v3 0/2] Set Firmware Version from build command line Date: Thu, 13 Apr 2023 17:32:07 +0200 Message-Id: <20230413153209.128585-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true ArmVirtXen.dsc allows setting the firmware version string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString via FIRMWARE_VER variable conveniently on the build command line. These two patches add this behavior to all .dsc files in ArmVirtPkg and OvmfPkg. PR: https://github.com/tianocore/edk2/pull/4268 v3: - Introduce common include file for OVMF .dsc files v2: Address comments by Sami and Gerd: - Only set PCD if FIRMWARE_VER is defined - ArmVirt: move logic to ArmVirt.dsc.inc https://edk2.groups.io/g/devel/message/95208 v1: https://edk2.groups.io/g/devel/message/95057 Oliver Steffen (2): OvmfPkg: allow setting Firmware Version from build command line ArmVirtPkg: allow setting Firmware Version from build command line ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++ ArmVirtPkg/ArmVirtXen.dsc | 1 - OvmfPkg/OvmfPkgIa32.dsc | 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/OvmfPkgX64.dsc | 5 ++++- OvmfPkg/OvmfXen.dsc | 3 +++ 7 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc -- 2.40.0