public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0
@ 2023-04-14  7:16 PierreGondois
  0 siblings, 0 replies; only message in thread
From: PierreGondois @ 2023-04-14  7:16 UTC (permalink / raw)
  To: devel
  Cc: Thomas Abraham, Ard Biesheuvel, Sami Mujawar, Fabien Ficheau,
	Rebecca Cran

From: Pierre Gondois <pierre.gondois@arm.com>

Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf

JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code
as Juno-r0 doesn't support PCIe.

Check Juno's revision in HWPciRbInit() before setting up the
PCIe root complex.

Reported-by: Fabien Ficheau <fabien.ficheau@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
---
 .../ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c  | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
index 0755dc155616..055bf95f10ec 100644
--- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
+++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
@@ -69,6 +69,12 @@ HWPciRbInit (
   UINTN                   TranslationTable;
   EFI_CPU_IO2_PROTOCOL    *CpuIo;
   EFI_STATUS              Status;
+  UINT32                  JunoRevision;
+
+  GetJunoRevision (JunoRevision);
+  if (JunoRevision == JUNO_REVISION_R0) {
+    return EFI_SUCCESS;
+  }
 
   PCI_TRACE ("VExpressPciRbInit()");
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-04-14  7:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-14  7:16 [PATCH v2 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0 PierreGondois

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox