From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io
Cc: "Pawel Polawski" <ppolawsk@redhat.com>,
"Dongyan Qian" <qiandongyan@loongson.cn>,
"Sunil V L" <sunilvl@ventanamicro.com>,
"Baoqi Zhang" <zhangbaoqi@loongson.cn>,
"Chao Li" <lichao@loongson.cn>,
"Rebecca Cran" <rebecca@bsdio.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Yuwei Chen" <yuwei.chen@intel.com>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Daniel Schaefer" <git@danielschaefer.me>,
"Bob Feng" <bob.c.feng@intel.com>,
"Oliver Steffen" <osteffen@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH v4 00/10] BaseTools: remove duplicate includes.
Date: Fri, 14 Apr 2023 10:02:40 +0200 [thread overview]
Message-ID: <20230414080250.1357004-1-kraxel@redhat.com> (raw)
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over to use the include files in
MdePkg instead. It also cleans up some (apparently) obsolete code and
adapts BaseTools code in a few places to work with the MdePkg version of
the include files.
v4 changes:
- fix clang build failure
v3 changes:
- fix build failure on ubuntu 22.04
v2 changes:
- rebase to latest master, resolve conflicts.
- pick up reviews and acks.
take care,
Gerd
Gerd Hoffmann (10):
BaseTools: add BASETOOLS define
MdePkg: don't set visibility to hidden for BaseTools
BaseTools: remove WinNtInclude.h
BaseTools: remove duplicate includes: <arch>/ProcessorBind.h
BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h
MdePkg/PeImage.h: add bits from BaseTools version
BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks
BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*
BaseTools: remove duplicate includes: IndustryStandard/PeImage.h
BaseTools: remove duplicate includes: IndustryStandard/*.h
BaseTools/Source/C/Common/WinNtInclude.h | 66 --
BaseTools/Source/C/EfiRom/EfiRom.h | 14 +-
.../Source/C/Include/AArch64/ProcessorBind.h | 148 ----
.../Source/C/Include/Arm/ProcessorBind.h | 147 ----
.../Source/C/Include/Ia32/ProcessorBind.h | 155 ----
.../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
.../C/Include/IndustryStandard/Acpi1_0.h | 285 -------
.../C/Include/IndustryStandard/Acpi2_0.h | 520 ------------
.../C/Include/IndustryStandard/Acpi3_0.h | 668 ---------------
.../C/Include/IndustryStandard/Bluetooth.h | 56 --
.../C/Include/IndustryStandard/EfiPci.h | 51 --
...emoryMappedConfigurationSpaceAccessTable.h | 39 -
.../C/Include/IndustryStandard/PeImage.h | 789 ------------------
.../Source/C/Include/IndustryStandard/pci22.h | 536 ------------
.../Source/C/Include/IndustryStandard/pci23.h | 18 -
.../Source/C/Include/IndustryStandard/pci30.h | 38 -
.../C/Include/LoongArch64/ProcessorBind.h | 80 --
.../Source/C/Include/Protocol/DevicePath.h | 2 +-
.../Source/C/Include/RiscV64/ProcessorBind.h | 85 --
.../Source/C/Include/X64/ProcessorBind.h | 183 ----
MdePkg/Include/IndustryStandard/PeImage.h | 31 +
MdePkg/Include/X64/ProcessorBind.h | 2 +-
BaseTools/Source/C/Common/BasePeCoff.c | 51 +-
BaseTools/Source/C/Common/Decompress.c | 1 +
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 43 +-
BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +-
BaseTools/Source/C/GenFw/Elf64Convert.c | 12 +-
BaseTools/Source/C/GenFw/ElfConvert.c | 2 -
BaseTools/Source/C/GenFw/GenFw.c | 18 +-
BaseTools/Source/C/Makefiles/header.makefile | 18 +-
BaseTools/Source/C/Makefiles/ms.common | 17 +-
BaseTools/Source/C/VfrCompile/GNUmakefile | 1 +
32 files changed, 119 insertions(+), 4082 deletions(-)
delete mode 100644 BaseTools/Source/C/Common/WinNtInclude.h
delete mode 100644 BaseTools/Source/C/Include/AArch64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/Arm/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/Ia32/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi1_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi2_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi3_0.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Bluetooth.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/EfiPci.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeImage.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci22.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci23.h
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci30.h
delete mode 100644 BaseTools/Source/C/Include/LoongArch64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/RiscV64/ProcessorBind.h
delete mode 100644 BaseTools/Source/C/Include/X64/ProcessorBind.h
--
2.39.2
next reply other threads:[~2023-04-14 8:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 8:02 Gerd Hoffmann [this message]
2023-04-14 8:02 ` [PATCH v4 01/10] BaseTools: add BASETOOLS define Gerd Hoffmann
2023-04-14 12:29 ` Marvin Häuser
2023-04-14 14:37 ` Gerd Hoffmann
2023-04-14 14:51 ` Marvin Häuser
2023-04-14 14:57 ` [edk2-devel] " Ard Biesheuvel
2023-04-14 15:10 ` Marvin Häuser
2023-04-18 11:52 ` Gerd Hoffmann
2023-04-18 11:59 ` Ard Biesheuvel
2023-04-18 13:20 ` Gerd Hoffmann
2023-04-18 13:41 ` Marvin Häuser
2023-04-18 15:50 ` Ard Biesheuvel
2023-04-21 3:26 ` 回复: " gaoliming
2023-05-22 12:27 ` Gerd Hoffmann
2023-05-22 12:55 ` Ard Biesheuvel
2023-05-22 13:38 ` Gerd Hoffmann
2023-05-22 14:31 ` Gerd Hoffmann
2023-05-23 7:07 ` Ard Biesheuvel
2023-05-23 8:49 ` Gerd Hoffmann
2023-05-23 8:54 ` Ard Biesheuvel
2023-04-14 8:02 ` [PATCH v4 02/10] MdePkg: don't set visibility to hidden for BaseTools Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 03/10] BaseTools: remove WinNtInclude.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 04/10] BaseTools: remove duplicate includes: <arch>/ProcessorBind.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 05/10] BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 06/10] MdePkg/PeImage.h: add bits from BaseTools version Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 07/10] BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 08/10] BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_* Gerd Hoffmann
2023-04-14 12:16 ` [edk2-devel] " Rebecca Cran
2023-04-14 14:39 ` Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 09/10] BaseTools: remove duplicate includes: IndustryStandard/PeImage.h Gerd Hoffmann
2023-04-14 8:02 ` [PATCH v4 10/10] BaseTools: remove duplicate includes: IndustryStandard/*.h Gerd Hoffmann
2023-04-14 12:18 ` [edk2-devel] [PATCH v4 00/10] BaseTools: remove duplicate includes Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414080250.1357004-1-kraxel@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox