From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.4028.1681459376880634905 for ; Fri, 14 Apr 2023 01:02:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bgmPoWK5; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681459375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yZbjkxYVKqb7FN1I5wiOWxgIt1EydXPAbdLHz4V+qW8=; b=bgmPoWK5uZ/ltD8v1L3nxge2zgfMyiy9uPc2TmW9IsdyKGN+j3KOOCW7kQr4RYKs/gxRF1 QfwkqNxSTu10oGL7PGqrnhrhF4Pq7oKzkTPUPHhraoiy2Hz/2pU3EIBnc9U2Ivx1u2rWtN Ho80OSC23+UbFHLYQ8GbZf0rk/QrhGw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-O59u3ltPM5Svhw6gZ50xug-1; Fri, 14 Apr 2023 04:02:54 -0400 X-MC-Unique: O59u3ltPM5Svhw6gZ50xug-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17CF5101A553; Fri, 14 Apr 2023 08:02:54 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D09171121320; Fri, 14 Apr 2023 08:02:53 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A5C9418000A3; Fri, 14 Apr 2023 10:02:50 +0200 (CEST) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Pawel Polawski , Dongyan Qian , Sunil V L , Baoqi Zhang , Chao Li , Rebecca Cran , Ard Biesheuvel , Zhiguang Liu , Liming Gao , Yuwei Chen , =?UTF-8?q?Marvin=20H=C3=A4user?= , Leif Lindholm , Michael D Kinney , Daniel Schaefer , Bob Feng , Oliver Steffen , Gerd Hoffmann Subject: [PATCH v4 02/10] MdePkg: don't set visibility to hidden for BaseTools Date: Fri, 14 Apr 2023 10:02:42 +0200 Message-Id: <20230414080250.1357004-3-kraxel@redhat.com> In-Reply-To: <20230414080250.1357004-1-kraxel@redhat.com> References: <20230414080250.1357004-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Setting visibility to hidden can cause linker errors when BaseTools are linked against standard libraries. Signed-off-by: Gerd Hoffmann --- MdePkg/Include/X64/ProcessorBind.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/X64/ProcessorBind.h b/MdePkg/Include/X64/ProcessorBind.h index f0a4d00142b9..98673456aad0 100644 --- a/MdePkg/Include/X64/ProcessorBind.h +++ b/MdePkg/Include/X64/ProcessorBind.h @@ -21,7 +21,7 @@ #pragma pack() #endif -#if defined (__GNUC__) && defined (__pic__) && !defined (USING_LTO) && !defined (__APPLE__) +#if defined (__GNUC__) && defined (__pic__) && !defined (BASETOOLS) && !defined (USING_LTO) && !defined (__APPLE__) // // Mark all symbol declarations and references as hidden, meaning they will // not be subject to symbol preemption. This allows the compiler to refer to -- 2.39.2