public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Minh Nguyen <minhnguyen@os.amperecomputing.com>
To: devel@edk2.groups.io
Cc: patches@amperecomputing.com, abner.chang@amd.com,
	nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com,
	tinhnguyen@os.amperecomputing.com,
	Vu Nguyen <vunguyen@os.amperecomputing.com>,
	Minh Nguyen <minhnguyen@os.amperecomputing.com>
Subject: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region
Date: Fri, 14 Apr 2023 15:19:00 +0700	[thread overview]
Message-ID: <20230414081903.7892-3-minhnguyen@os.amperecomputing.com> (raw)
In-Reply-To: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com>

From: Vu Nguyen <vunguyen@os.amperecomputing.com>

This change also fix miscellaneous errors on condition checking and
debug argument missing.

Signed-off-by: Minh Nguyen <minhnguyen@os.amperecomputing.com>
---
 RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
index 583c6f78e19c..29e7b0624ebf 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
@@ -5,6 +5,7 @@
   (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
   Copyright (c) 2022, AMD Incorporated. All rights reserved.
   Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -272,7 +273,7 @@ Tcp6GetSubnetInfo (
   if (IpModedata.AddressCount == 0) {
     DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__));
     Instance->SubnetAddrInfoIPv6Number = 0;
-    return EFI_SUCCESS;
+    return EFI_NOT_FOUND;
   }
 
   if (Instance->SubnetAddrInfoIPv6 != NULL) {
@@ -926,7 +927,7 @@ AddAndSignalNewRedfishService (
     }
 
     Status = gBS->SignalEvent (Instance->DiscoverToken->Event);
-    if (!EFI_ERROR (Status)) {
+    if (EFI_ERROR (Status)) {
       DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__));
     }
   }
-- 
2.39.0


  parent reply	other threads:[~2023-04-14  8:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  8:18 [PATCH 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
2023-04-14  8:18 ` [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Minh Nguyen
2023-04-14  8:52   ` Nickle Wang
2023-04-14  8:19 ` Minh Nguyen [this message]
2023-04-14  9:03   ` [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region Nickle Wang
2023-04-14  9:17     ` minhn
2023-04-14  9:28       ` Nickle Wang
2023-04-14  9:20     ` Minh Nguyen OS
2023-04-14  8:19 ` [PATCH 3/5] RedfishPkg: Create RestEx child on selected interface Minh Nguyen
2023-04-16  4:36   ` Chang, Abner
2023-04-20  1:23     ` Minh Nguyen OS
2023-04-20  1:28       ` Chang, Abner
2023-04-20  1:33         ` Minh Nguyen OS
2023-04-14  8:19 ` [PATCH 4/5] RedfishPkg: Add missing newline character Minh Nguyen
2023-04-14  8:53   ` Nickle Wang
2023-04-14  8:19 ` [PATCH 5/5] RedfishPkg: Fix compile issue on Linux Minh Nguyen
2023-04-14 14:13   ` Chang, Abner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414081903.7892-3-minhnguyen@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox