From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.4496.1681461215240346803 for ; Fri, 14 Apr 2023 01:33:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aLHUwdqO; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: osteffen@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681461214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VD5o/5qtsJ5SrNsx4rUpEDZkwKj8n4PIypHG5Vyi7lg=; b=aLHUwdqOKX2oo/UeTQBtmTr7wEJhvt0h+tlmF9HCEqSFer9+c95PqPOrv/eDs+mkNs4050 VwBPlRORxlcG5tjO2XWZh02jIrjlBm/n+DA1fFdU4YLeZK7ocyZSslBYkv18AEHqt2Yz+T nsG24lQpTaV1qQFm4hCZnFEjUGOK09s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-VEkNVpPbMw-rAUJXssZwSw-1; Fri, 14 Apr 2023 04:33:31 -0400 X-MC-Unique: VEkNVpPbMw-rAUJXssZwSw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B7EB88B7A0; Fri, 14 Apr 2023 08:33:30 +0000 (UTC) Received: from osteffen-laptop.redhat.com (unknown [10.39.193.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90746492C13; Fri, 14 Apr 2023 08:33:28 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao , Oliver Steffen Subject: [PATCH v4 0/2] Set Firmware Version from build command line Date: Fri, 14 Apr 2023 10:33:21 +0200 Message-Id: <20230414083323.153731-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true ArmVirtXen.dsc allows setting the firmware version string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString via FIRMWARE_VER variable conveniently on the build command line. These two patches add this behavior to all .dsc files in ArmVirtPkg and OvmfPkg. PR: https://github.com/tianocore/edk2/pull/4268 v4: - Actually use the include file v3: - Introduce common include file for OVMF .dsc files https://edk2.groups.io/g/devel/message/102952 v2: Address comments by Sami and Gerd: - Only set PCD if FIRMWARE_VER is defined - ArmVirt: move logic to ArmVirt.dsc.inc https://edk2.groups.io/g/devel/message/95208 v1: https://edk2.groups.io/g/devel/message/95057 Oliver Steffen (2): OvmfPkg: allow setting Firmware Version from build command line ArmVirtPkg: allow setting Firmware Version from build command line ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++ ArmVirtPkg/ArmVirtXen.dsc | 1 - OvmfPkg/OvmfPkgIa32.dsc | 2 ++ OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ OvmfPkg/OvmfPkgX64.dsc | 3 +++ OvmfPkg/OvmfXen.dsc | 2 ++ 7 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc -- 2.40.0