From: "Chang, Abner" <abner.chang@amd.com>
To: <devel@edk2.groups.io>
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Abdul Lateef Attar <abdattar@amd.com>,
Nickle Wang <nicklew@nvidia.com>,
Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
Subject: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C
Date: Sat, 15 Apr 2023 19:57:26 +0800 [thread overview]
Message-ID: <20230415115727.805-2-abner.chang@amd.com> (raw)
In-Reply-To: <20230415115727.805-1-abner.chang@amd.com>
From: Abner Chang <abner.chang@amd.com>
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++-----
.../BaseManageabilityTransportHelper.inf | 2 +-
.../BaseManageabilityTransportHelper.c | 14 +++++++-------
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..3656190a70 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -32,13 +32,13 @@
# Manageability Transport Interface type
#
# Manageability Transport KCS
- gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
- # Manageability Transport I2C
- gManageabilityTransportI2CGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
+ gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
+ # Manageability Transport SMBUS I2C
+ gManageabilityTransportSmbusI2CGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
# Manageability Transport PCI VDM
- gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
+ gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
# Manageability Transport MCTP
- gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
+ gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
# Manageability Protocol Specification
#
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
index 95c3362ddb..8876e36480 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
@@ -32,7 +32,7 @@
[Guids]
gManageabilityTransportKcsGuid
- gManageabilityTransportI2CGuid
+ gManageabilityTransportSmbusI2CGuid
gManageabilityTransportPciVdmGuid
gManageabilityTransportMctpGuid
gManageabilityProtocolIpmiGuid
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
index 81da209764..6454f32670 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
@@ -15,13 +15,13 @@
// Make sure the global variables added here should be unchangable.
//
MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] = {
- { &gManageabilityTransportKcsGuid, L"KCS" },
- { &gManageabilityTransportI2CGuid, L"I2C" },
- { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
- { &gManageabilityTransportMctpGuid, L"MCTP" },
- { &gManageabilityProtocolIpmiGuid, L"IPMI" },
- { &gManageabilityProtocolMctpGuid, L"MCTP" },
- { &gManageabilityProtocolPldmGuid, L"PLDM" }
+ { &gManageabilityTransportKcsGuid, L"KCS" },
+ { &gManageabilityTransportSmbusI2CGuid, L"SMBUS I2C"},
+ { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
+ { &gManageabilityTransportMctpGuid, L"MCTP" },
+ { &gManageabilityProtocolIpmiGuid, L"IPMI" },
+ { &gManageabilityProtocolMctpGuid, L"MCTP" },
+ { &gManageabilityProtocolPldmGuid, L"PLDM" }
};
UINT16 mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);
--
2.37.1.windows.1
next prev parent reply other threads:[~2023-04-15 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 11:57 [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
2023-04-15 11:57 ` Chang, Abner [this message]
2023-04-17 4:50 ` [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Attar, AbdulLateef (Abdul Lateef)
2023-04-17 5:22 ` Chang, Abner
2023-04-15 11:57 ` [edk2-platforms][PATCH 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner
2023-04-17 4:51 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:43 ` Tinh Nguyen
2023-04-17 4:41 ` [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:40 ` Tinh Nguyen
2023-04-17 12:56 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230415115727.805-2-abner.chang@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox