From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.51]) by mx.groups.io with SMTP id smtpd.web10.6050.1681559878966720737 for ; Sat, 15 Apr 2023 04:57:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=EXebmUGW; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.51, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvkAp9nsQHfetLk608QAMSUnsLbZuQn316nfNGstL8O9UiBGm5oeckfC5NlMu8UwrNjyp0X2FAYzpLgkwf3b1rkjaZOO9FT6FDGTApLirYO0bWvzO7+/b5wGdRreaCaTuhX3zDZsJJF9G5llCSC4ORFTfmC9i8nS+T2t11NdLSkk+pB7jrA3Swc3he6xVrtD+kmSmzFTLL5rqY/mLI0HLk9jWx1IRuSjSt/RbnRGatFFNKuCIuBwwWgqMdwnm5A+Q5ehgibPXruuqNDMXsCgImxdAmj/yAzERZTBQ4diunIQkeaYyNsAXViTpvq0JMICFYYzDNa7WUe7U7mTwoF5zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sh0EFprTKUCd1SXKYI3x220HeIuoRpVd2TnuliZNieg=; b=IIJNVD33bJXZsdyIlZXjngMfp0ttrDOESg1NCgCbuAHA/slp2hUp3EnbrTck+eU0rtIkmKJrj5UlBb/3Y9EqzM1EUutsw6XDI4AFl7jjHb60e3zCFze6DAuh1l3vxLzHTl9QdzGPt81Jx5lzo9KgZh17ZxYE4BNrsKOxgRIY170DVwaLC3xuBEkfKkDDUhrx1CAiY6Hz1umgsWtQETYlCRQKaxuKHpKys9sf72bUaXw1tMq/Je2zlNMGxSHfgTaFeQCm8/DxM+FNmIoswiEo/ptlYnC25bjcw6xIqZKJfdRWXyMD4pS5x0eqKtZzu6ql5hFo+WK5Q7xthLnlxSHtCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sh0EFprTKUCd1SXKYI3x220HeIuoRpVd2TnuliZNieg=; b=EXebmUGWwqZ0FFZNrUaXJfQFWPaYPUD0kxqeT8lVph0wIcxujuhRXm4pI3oxdrvOF9yS/+b0PPr1XrzKnb05Z8+z/Nfpa4G+lh2p7ximp1Y43Ii7ZuX0/YQhH/bYeXw5Az+CCSeMqa/Th13zZuJlXB40kt5rXRLWgQohvsWgKHw= Received: from MN2PR10CA0022.namprd10.prod.outlook.com (2603:10b6:208:120::35) by SJ0PR12MB6829.namprd12.prod.outlook.com (2603:10b6:a03:47b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sat, 15 Apr 2023 11:57:55 +0000 Received: from BL02EPF000145B8.namprd05.prod.outlook.com (2603:10b6:208:120:cafe::37) by MN2PR10CA0022.outlook.office365.com (2603:10b6:208:120::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.36 via Frontend Transport; Sat, 15 Apr 2023 11:57:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF000145B8.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.16 via Frontend Transport; Sat, 15 Apr 2023 11:57:54 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sat, 15 Apr 2023 06:57:51 -0500 From: "Chang, Abner" To: CC: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Tinh Nguyen Subject: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Date: Sat, 15 Apr 2023 19:57:26 +0800 Message-ID: <20230415115727.805-2-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20230415115727.805-1-abner.chang@amd.com> References: <20230415115727.805-1-abner.chang@amd.com> MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145B8:EE_|SJ0PR12MB6829:EE_ X-MS-Office365-Filtering-Correlation-Id: e9bc928d-020a-4cd7-8bca-08db3da8a5a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8RXF2Byf0j3pUZrYEqwCuRo5/NkH/0S56s8Hhc7uvwS8XgxDtDaGIggG26QS7JCUwlp+144CjpM80Kkz/kG3o9X54jTYtz8HfXHbiBjEGarf+LhUtgtYksxzTNX4gRpiBNEvJHo3dKTJDuZmAlN59K4i2VrGljgrkB6k9mlQ1GoMGh2IXIQTMqC9Fi6H8CuENDDAWMyyDk9JN1RT6VUvYzrtX0Vv8eTNjFv1puPCrUEZqCC1uJuMCwlu+nscwERcrbWY/eRMAvs5qECnTTQEd3JJm+7dYWbl+TdPrAgKdvZ/6edgqQdJ5hw6E3a07r9S2EjSBOzsbjxeqNVw/Worbcfia7RhN27KStbZ37p2QurdOpN2xl/9nfGQsSM1PRrSXkbb1vRW86mriD6NpgEAeEeFg/8tcp71/2DxyosKo8ilysxcwgmtwqWs3PMGYQOXzV4Xol7/X9TI/jUxmxABvnfsf2zo91Z0bziik7pb9MjoY/4iouy/cJh8raVdfYjKYZAD7za0h7IpLkK2Aya4MClBTOmeo1Yo+8Gwsz4+5/geLqevmDTuKjpURMwLsF6B6FeeGKfyJ1efrE/PxJTY2X4VRE6AikEPugwlUWomPA8hEzVdYve9UiHeU/XWWOYCZd+2ruYhVxTlrwmUTHAEYaCHMw2p9Z+Vr+p1N4Ya5x3TI8WAp9h1bTEBqEaqDBvel8ZnqGvEv0bFrnJTWKeSbzdY7KdV4ux4m8EOYq29mDs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199021)(40470700004)(46966006)(36840700001)(2616005)(36860700001)(36756003)(356005)(40480700001)(7696005)(6666004)(86362001)(81166007)(5660300002)(426003)(2876002)(336012)(47076005)(83380400001)(2906002)(16526019)(54906003)(186003)(40460700003)(26005)(82310400005)(1076003)(478600001)(19627235002)(6916009)(4326008)(70206006)(8936002)(316002)(41300700001)(8676002)(82740400003)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2023 11:57:54.5306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9bc928d-020a-4cd7-8bca-08db3da8a5a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6829 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++----- .../BaseManageabilityTransportHelper.inf | 2 +- .../BaseManageabilityTransportHelper.c | 14 +++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index 9a930d3e4b..3656190a70 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -32,13 +32,13 @@ # Manageability Transport Interface type # # Manageability Transport KCS - gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { 0x= AA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } - # Manageability Transport I2C - gManageabilityTransportI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { 0x= A0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } + gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { = 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } + # Manageability Transport SMBUS I2C + gManageabilityTransportSmbusI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { = 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } # Manageability Transport PCI VDM - gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { 0x= 9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } + gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { = 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } # Manageability Transport MCTP - gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { 0x= 82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } + gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { = 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } =20 # Manageability Protocol Specification # diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Li= brary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.= inf index 95c3362ddb..8876e36480 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf @@ -32,7 +32,7 @@ =20 [Guids] gManageabilityTransportKcsGuid - gManageabilityTransportI2CGuid + gManageabilityTransportSmbusI2CGuid gManageabilityTransportPciVdmGuid gManageabilityTransportMctpGuid gManageabilityProtocolIpmiGuid diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Libr= ary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c index 81da209764..6454f32670 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c @@ -15,13 +15,13 @@ // Make sure the global variables added here should be unchangable. // MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] =3D { - { &gManageabilityTransportKcsGuid, L"KCS" }, - { &gManageabilityTransportI2CGuid, L"I2C" }, - { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, - { &gManageabilityTransportMctpGuid, L"MCTP" }, - { &gManageabilityProtocolIpmiGuid, L"IPMI" }, - { &gManageabilityProtocolMctpGuid, L"MCTP" }, - { &gManageabilityProtocolPldmGuid, L"PLDM" } + { &gManageabilityTransportKcsGuid, L"KCS" }, + { &gManageabilityTransportSmbusI2CGuid, L"SMBUS I2C"}, + { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, + { &gManageabilityTransportMctpGuid, L"MCTP" }, + { &gManageabilityProtocolIpmiGuid, L"IPMI" }, + { &gManageabilityProtocolMctpGuid, L"MCTP" }, + { &gManageabilityProtocolPldmGuid, L"PLDM" } }; =20 UINT16 mManageabilitySpecNum =3D sizeof (ManageabilitySpecNameTable)/ siz= eof (MANAGEABILITY_SPECIFICATION_NAME); --=20 2.37.1.windows.1