public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms][PATCH V2 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance
@ 2023-04-17 12:55 Chang, Abner
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner
  0 siblings, 2 replies; 5+ messages in thread
From: Chang, Abner @ 2023-04-17 12:55 UTC (permalink / raw)
  To: devel
  Cc: Isaac Oram, Abdul Lateef Attar, Nickle Wang, Tinh Nguyen,
	Abdul Lateef Attar

From: Abner Chang <abner.chang@amd.com>

Remove duplicate library instance in [LibraryClass]
section.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Reviewed-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 .../ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
index 8d59b46d48..3f839625ac 100644
--- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
+++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
@@ -37,7 +37,6 @@
   ManageabilityTransportHelperLib
   ManageabilityTransportLib
   PeimEntryPoint
-  ManageabilityTransportLib
 
 [Ppis]
   gPeiIpmiPpiGuid       # PPI ALWAYS PRODUCED
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C
  2023-04-17 12:55 [edk2-platforms][PATCH V2 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
@ 2023-04-17 12:55 ` Chang, Abner
  2023-04-17 16:35   ` Tinh Nguyen
  2023-04-18  4:20   ` Attar, AbdulLateef (Abdul Lateef)
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner
  1 sibling, 2 replies; 5+ messages in thread
From: Chang, Abner @ 2023-04-17 12:55 UTC (permalink / raw)
  To: devel; +Cc: Isaac Oram, Abdul Lateef Attar, Nickle Wang, Tinh Nguyen

From: Abner Chang <abner.chang@amd.com>

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 Features/ManageabilityPkg/ManageabilityPkg.dec     | 10 +++++-----
 .../BaseManageabilityTransportHelper.inf           |  2 +-
 .../BaseManageabilityTransportHelper.c             | 14 +++++++-------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..3d279ef033 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -32,13 +32,13 @@
   # Manageability Transport Interface type
   #
   # Manageability Transport KCS
-  gManageabilityTransportKcsGuid    = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
-  # Manageability Transport I2C
-  gManageabilityTransportI2CGuid    = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
+  gManageabilityTransportKcsGuid      = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
+  # Manageability Transport SMBUS I2C
+  gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
   # Manageability Transport PCI VDM
-  gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
+  gManageabilityTransportPciVdmGuid   = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
   # Manageability Transport MCTP
-  gManageabilityTransportMctpGuid   = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
+  gManageabilityTransportMctpGuid     = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
 
   # Manageability Protocol Specification
   #
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
index 95c3362ddb..5447954144 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
@@ -32,7 +32,7 @@
 
 [Guids]
   gManageabilityTransportKcsGuid
-  gManageabilityTransportI2CGuid
+  gManageabilityTransportSmbusI2cGuid
   gManageabilityTransportPciVdmGuid
   gManageabilityTransportMctpGuid
   gManageabilityProtocolIpmiGuid
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
index 81da209764..c3f35b7beb 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
@@ -15,13 +15,13 @@
 // Make sure the global variables added here should be unchangable.
 //
 MANAGEABILITY_SPECIFICATION_NAME  ManageabilitySpecNameTable[] = {
-  { &gManageabilityTransportKcsGuid,    L"KCS"     },
-  { &gManageabilityTransportI2CGuid,    L"I2C"     },
-  { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
-  { &gManageabilityTransportMctpGuid,   L"MCTP"    },
-  { &gManageabilityProtocolIpmiGuid,    L"IPMI"    },
-  { &gManageabilityProtocolMctpGuid,    L"MCTP"    },
-  { &gManageabilityProtocolPldmGuid,    L"PLDM"    }
+  { &gManageabilityTransportKcsGuid,         L"KCS"      },
+  { &gManageabilityTransportSmbusI2cGuid,    L"SMBUS I2C"},
+  { &gManageabilityTransportPciVdmGuid,      L"PCI VDM"  },
+  { &gManageabilityTransportMctpGuid,        L"MCTP"     },
+  { &gManageabilityProtocolIpmiGuid,         L"IPMI"     },
+  { &gManageabilityProtocolMctpGuid,         L"MCTP"     },
+  { &gManageabilityProtocolPldmGuid,         L"PLDM"     }
 };
 
 UINT16  mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [edk2-platforms][PATCH V2 3/3] ManageabilityPkg: Support AARCH64
  2023-04-17 12:55 [edk2-platforms][PATCH V2 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
@ 2023-04-17 12:55 ` Chang, Abner
  1 sibling, 0 replies; 5+ messages in thread
From: Chang, Abner @ 2023-04-17 12:55 UTC (permalink / raw)
  To: devel
  Cc: Isaac Oram, Abdul Lateef Attar, Nickle Wang, Tinh Nguyen,
	Abdul Lateef Attar

From: Abner Chang <abner.chang@amd.com>

Add AARCH64 support in Manageability.dsc

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Reviewed-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 .../ManageabilityPkg/Include/Dsc/Manageability.dsc    | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
index 0d868fdf4a..7f8d8df3f0 100644
--- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
+++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
@@ -15,11 +15,18 @@
   NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
   ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
+  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
 
-[Components.IA32]
+[LibraryClasses.AARCH64.PEIM]
+  PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
+
+[Components.IA32, Components.AARCH64]
   ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
 
-[Components.X64]
+[Components.X64, Components.AARCH64]
   ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
+
+[Components.X64]
   ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
 
-- 
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
@ 2023-04-17 16:35   ` Tinh Nguyen
  2023-04-18  4:20   ` Attar, AbdulLateef (Abdul Lateef)
  1 sibling, 0 replies; 5+ messages in thread
From: Tinh Nguyen @ 2023-04-17 16:35 UTC (permalink / raw)
  To: abner.chang, devel
  Cc: Isaac Oram, Abdul Lateef Attar, Nickle Wang, Tinh Nguyen

[-- Attachment #1: Type: text/plain, Size: 4632 bytes --]

|||Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>|

On 4/17/2023 7:55 PM, abner.chang@amd.com wrote:
> From: Abner Chang<abner.chang@amd.com>
>
> Signed-off-by: Abner Chang<abner.chang@amd.com>
> Cc: Isaac Oram<isaac.w.oram@intel.com>
> Cc: Abdul Lateef Attar<abdattar@amd.com>
> Cc: Nickle Wang<nicklew@nvidia.com>
> Cc: Tinh Nguyen<tinhnguyen@os.amperecomputing.com>
> ---
>   Features/ManageabilityPkg/ManageabilityPkg.dec     | 10 +++++-----
>   .../BaseManageabilityTransportHelper.inf           |  2 +-
>   .../BaseManageabilityTransportHelper.c             | 14 +++++++-------
>   3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
> index 9a930d3e4b..3d279ef033 100644
> --- a/Features/ManageabilityPkg/ManageabilityPkg.dec
> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> @@ -32,13 +32,13 @@
>     # Manageability Transport Interface type
>     #
>     # Manageability Transport KCS
> -  gManageabilityTransportKcsGuid    = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
> -  # Manageability Transport I2C
> -  gManageabilityTransportI2CGuid    = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
> +  gManageabilityTransportKcsGuid      = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
> +  # Manageability Transport SMBUS I2C
> +  gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
>     # Manageability Transport PCI VDM
> -  gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
> +  gManageabilityTransportPciVdmGuid   = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
>     # Manageability Transport MCTP
> -  gManageabilityTransportMctpGuid   = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
> +  gManageabilityTransportMctpGuid     = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
>   
>     # Manageability Protocol Specification
>     #
> diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> index 95c3362ddb..5447954144 100644
> --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
> @@ -32,7 +32,7 @@
>   
>   [Guids]
>     gManageabilityTransportKcsGuid
> -  gManageabilityTransportI2CGuid
> +  gManageabilityTransportSmbusI2cGuid
>     gManageabilityTransportPciVdmGuid
>     gManageabilityTransportMctpGuid
>     gManageabilityProtocolIpmiGuid
> diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> index 81da209764..c3f35b7beb 100644
> --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
> @@ -15,13 +15,13 @@
>   // Make sure the global variables added here should be unchangable.
>   //
>   MANAGEABILITY_SPECIFICATION_NAME  ManageabilitySpecNameTable[] = {
> -  { &gManageabilityTransportKcsGuid,    L"KCS"     },
> -  { &gManageabilityTransportI2CGuid,    L"I2C"     },
> -  { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
> -  { &gManageabilityTransportMctpGuid,   L"MCTP"    },
> -  { &gManageabilityProtocolIpmiGuid,    L"IPMI"    },
> -  { &gManageabilityProtocolMctpGuid,    L"MCTP"    },
> -  { &gManageabilityProtocolPldmGuid,    L"PLDM"    }
> +  { &gManageabilityTransportKcsGuid,         L"KCS"      },
> +  { &gManageabilityTransportSmbusI2cGuid,    L"SMBUS I2C"},
> +  { &gManageabilityTransportPciVdmGuid,      L"PCI VDM"  },
> +  { &gManageabilityTransportMctpGuid,        L"MCTP"     },
> +  { &gManageabilityProtocolIpmiGuid,         L"IPMI"     },
> +  { &gManageabilityProtocolMctpGuid,         L"MCTP"     },
> +  { &gManageabilityProtocolPldmGuid,         L"PLDM"     }
>   };
>   
>   UINT16  mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);

[-- Attachment #2: Type: text/html, Size: 6568 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C
  2023-04-17 12:55 ` [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
  2023-04-17 16:35   ` Tinh Nguyen
@ 2023-04-18  4:20   ` Attar, AbdulLateef (Abdul Lateef)
  1 sibling, 0 replies; 5+ messages in thread
From: Attar, AbdulLateef (Abdul Lateef) @ 2023-04-18  4:20 UTC (permalink / raw)
  To: Chang, Abner, devel@edk2.groups.io; +Cc: Isaac Oram, Nickle Wang, Tinh Nguyen

[AMD Official Use Only - General]

Reviewed-by: Abdul Lateef Attar <abdattar@amd.com>

-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: 17 April 2023 18:26
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.oram@intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Subject: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C

From: Abner Chang <abner.chang@amd.com>

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 Features/ManageabilityPkg/ManageabilityPkg.dec     | 10 +++++-----
 .../BaseManageabilityTransportHelper.inf           |  2 +-
 .../BaseManageabilityTransportHelper.c             | 14 +++++++-------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..3d279ef033 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -32,13 +32,13 @@
   # Manageability Transport Interface type
   #
   # Manageability Transport KCS
-  gManageabilityTransportKcsGuid    = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
-  # Manageability Transport I2C
-  gManageabilityTransportI2CGuid    = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
+  gManageabilityTransportKcsGuid      = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
+  # Manageability Transport SMBUS I2C
+  gManageabilityTransportSmbusI2cGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
   # Manageability Transport PCI VDM
-  gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
+  gManageabilityTransportPciVdmGuid   = { 0x388021A7, 0xFB59, 0x4811, { 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
   # Manageability Transport MCTP
-  gManageabilityTransportMctpGuid   = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
+  gManageabilityTransportMctpGuid     = { 0x6798448D, 0x1200, 0x4577, { 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }

   # Manageability Protocol Specification
   #
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
index 95c3362ddb..5447954144 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
@@ -32,7 +32,7 @@

 [Guids]
   gManageabilityTransportKcsGuid
-  gManageabilityTransportI2CGuid
+  gManageabilityTransportSmbusI2cGuid
   gManageabilityTransportPciVdmGuid
   gManageabilityTransportMctpGuid
   gManageabilityProtocolIpmiGuid
diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
index 81da209764..c3f35b7beb 100644
--- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
+++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
@@ -15,13 +15,13 @@
 // Make sure the global variables added here should be unchangable.
 //
 MANAGEABILITY_SPECIFICATION_NAME  ManageabilitySpecNameTable[] = {
-  { &gManageabilityTransportKcsGuid,    L"KCS"     },
-  { &gManageabilityTransportI2CGuid,    L"I2C"     },
-  { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
-  { &gManageabilityTransportMctpGuid,   L"MCTP"    },
-  { &gManageabilityProtocolIpmiGuid,    L"IPMI"    },
-  { &gManageabilityProtocolMctpGuid,    L"MCTP"    },
-  { &gManageabilityProtocolPldmGuid,    L"PLDM"    }
+  { &gManageabilityTransportKcsGuid,         L"KCS"      },
+  { &gManageabilityTransportSmbusI2cGuid,    L"SMBUS I2C"},
+  { &gManageabilityTransportPciVdmGuid,      L"PCI VDM"  },
+  { &gManageabilityTransportMctpGuid,        L"MCTP"     },
+  { &gManageabilityProtocolIpmiGuid,         L"IPMI"     },
+  { &gManageabilityProtocolMctpGuid,         L"MCTP"     },
+  { &gManageabilityProtocolPldmGuid,         L"PLDM"     }
 };

 UINT16  mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof (MANAGEABILITY_SPECIFICATION_NAME);
--
2.37.1.windows.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-04-18  4:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 12:55 [edk2-platforms][PATCH V2 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
2023-04-17 12:55 ` [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
2023-04-17 16:35   ` Tinh Nguyen
2023-04-18  4:20   ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17 12:55 ` [edk2-platforms][PATCH V2 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox