From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.65]) by mx.groups.io with SMTP id smtpd.web10.2715.1681802166278997276 for ; Tue, 18 Apr 2023 00:16:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=YWrJTqno; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.65, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhHLBRfauXxGkl55SkK95qHDu3ThjXaMycNYWXnXlciHtc0Lak270WonIQ+5HzEtF1qzbRc9WQZ/0RZMM/Y2wJBwRKAiZQHa2E6xaa2bmOs/pSkVRaQ5NYca7V1KVJOHknhelNLyDbQfVxKTWcpMI/dRUcNkFA5ZG8Vw6jaVhpZCKIteK8UW5IlpdQhOPeryYeY50Iir1clVKoPSVub/spdYg900GYVXcViYHacakjZ9ZoA8CYyNzSXfO2k7OWD2juM9yp6qUQclj4d/zY5P4P7n0hRsKKwOSHrfJfcPymiwo05yOf+YYO9ad4RWvFgWhqsK/wnTCOTIxeaROna1bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUO4TrScDG6F12pMYl5jLemruoFHrV9Yauw/HWEE1w4=; b=IrG0kdXOSk5yziy+ZxeejTaunCXufCxYCwAkfF0o0cfJeZjJicoEzU0i+w/GEVlGUZd12OBxWajHNMhjq0LvmM/Ttj5hxm1H2XC2oykp/7lzMW5+/24NYv3JGYBIQvduSF0vBoRN69PshfdRGF7VG5P1VMf3/tK7OT2DQZWmNiI+jhCYguTSClsMb/TkDDei5BFQGg9CGSPBzGq5wM8NRbbtD8rEK4lzeiuUpW0SrKDIDfainNTfzZGAvaymJK7EOcIYICfg2K4DuekX7lK8JpWenywKaHRsx3umh4skIcjM9CkLw8UAzynJ2fbi9JyaLc9rcIKnzTt1j6k7FXdboA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUO4TrScDG6F12pMYl5jLemruoFHrV9Yauw/HWEE1w4=; b=YWrJTqnoaJzEvrNjGSmQut2uS28q9cZAyj5pYF1RgnBPcGNrFxY0bx/bC3hKImjTgF4dhuN4vhxX/m94gi9+2/vFaXl4OazUGDbV+T++LeKANCHW5VPuzi3wEVL3joiq+9VaNaOSgKesuvr+4FCNYONQtmngLYE3XJYe1xkpNDA= Received: from DM6PR11CA0006.namprd11.prod.outlook.com (2603:10b6:5:190::19) by MW3PR12MB4379.namprd12.prod.outlook.com (2603:10b6:303:5e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 07:16:04 +0000 Received: from DM6NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::ff) by DM6PR11CA0006.outlook.office365.com (2603:10b6:5:190::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.20 via Frontend Transport; Tue, 18 Apr 2023 07:16:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT095.mail.protection.outlook.com (10.13.172.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.20 via Frontend Transport; Tue, 18 Apr 2023 07:16:03 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 18 Apr 2023 02:16:01 -0500 From: "Chang, Abner" To: CC: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , Tinh Nguyen Subject: [edk2-platforms][PATCH V2 00/14] ManageabilityPkg part II Date: Tue, 18 Apr 2023 15:15:29 +0800 Message-ID: <20230418071543.1951-1-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT095:EE_|MW3PR12MB4379:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f04f0ad-909b-4ce0-9507-08db3fdcc53c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MjtzPub4buQyD2NqCSKXN+p0aPWxf1ytDruV34qThDTpQ5mPVQnoUWAsF/G0F/tvp3XKWIngMtFsfSC75Br/MdZIjkF1STnq+G6h/q1Dslc5dOkqCJxUOOAw9TjbpTF/NG8Qlwu+nc3pYCh6ICTSDdT3gK8VvEIefzQZW9kvIJpIa1H23nucgDMMAv58PztHdl0tJlsTly6dSF9vKTQ3B8uWV3PfvAZwnBj5VvWKY9xs6CrL8MdxutmOhLVLc+hF9SNEC1bMUsV1KxWjmjv7/oZuxsgDv2CFW/kmymT/XSR0dWZZH8jM1cGrnKS4+rZY2NiD6jpYZe2acSlbCXqZ5tsL9jSqtRBbU6/saRKtUkHaVrfnr9jk/HTIm+UO5OAZwu815I4ZjHMMppLvaplIDSJhbrwXodbahAWd9DxAnrygqnnX1N7g1jc2rx3bzFeqL9NRdauhwlac/6VeSX641WO9AZUZrZt1Ew5dL1+Wpdymjpe3w8rC3r7o7Z39WzGgCyaTNM4HJabIm+TbTJI5x3DPSrZ/Us/YJFC5UL+TpAT62ZDOPHTWK9cJbXvDup8EjdbGCrP1T5gJ1o3MW8k/HC8deFazUU2pqalgCwWnuh6Cl3dfP2zvgrAs0LAAuAFsy7hYXDmv1ji2fAkEKWanbcRV9nZjMOpQaIFi+cMDgTOsTUe+192+v4vRwJzXS0s7B3JZmEcd0Tao1Q16/qcUlUWftQWG1cWivbYLuDVZotI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199021)(36840700001)(40470700004)(46966006)(36756003)(8936002)(2876002)(8676002)(40460700003)(5660300002)(2906002)(82310400005)(86362001)(40480700001)(478600001)(7696005)(6666004)(54906003)(16526019)(186003)(2616005)(36860700001)(1076003)(70586007)(70206006)(26005)(41300700001)(356005)(82740400003)(316002)(83380400001)(81166007)(6916009)(4326008)(47076005)(426003)(336012)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 07:16:03.6556 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f04f0ad-909b-4ce0-9507-08db3fdcc53c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4379 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang In V2: - Address uncrustify issues. - Use DBBUG_MANAGEABILITY_INFO to output detailed manageability information. DEBUG_INFO is used for the function entry point, while DEBUG_ERROR is used for the error situations. In part II, we had implemented - PLDM protocol - MCTP protocol - PLDM SMBIOS Transfer protocol - MCTP manageability transport interface - Support maximum transfer unit of transport interface - Add more heler functions - Add two new fields HeaderSize and TrailerSize in MANAGEABILITY_TRANSFER_TOKEN structure. - Add PCDs to build the manageability modules. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen Abner Chang (14): ManageabilityPkg: Add more helper functions ManageabilityPkg: Support Maximum Transfer Unit ManageabilityPkg: Add HeaderSize and TrailerSize ManageabilityPkg: Add PldmProtocolLib ManageabilityPkg: Add PldmSmbiosTransferDxe driver ManageabilityPkg/KCS: KCS transport interface ManageabilityPkg: Add definitions of MCTP ManageabilityPkg: Add MCTP manageability header file ManageabilityPkg/MctpProtocol: Add MctpProtocol ManageabilityPkg: Add MCTP transport interface ManageabilityPkg/PldmProtocol: Add PLDM protocol ManageabilityPkg: Add Manageability PCDs ManageabilityPkg: Relocate Manageability.dsc ManageabilityPkg: Add Manageability FDFs .../ManageabilityPkg/ManageabilityPkg.dec | 28 + .../Include/{Dsc =3D> }/Manageability.dsc | 20 + .../ManageabilityPkg/ManageabilityPkg.dsc | 14 +- .../ManageabilityPkg/Include/PostMemory.fdf | 28 + .../ManageabilityPkg/Include/PreMemory.fdf | 12 + .../BaseManageabilityTransportHelper.inf | 1 + .../Dxe/DxeManageabilityTransportMctp.inf | 44 ++ .../Dxe/PldmProtocolLib.inf | 42 ++ .../MctpProtocol/Dxe/MctpProtocolDxe.inf | 53 ++ .../PldmProtocol/Dxe/PldmProtocolDxe.inf | 50 ++ .../PldmSmbiosTransferDxe.inf | 47 ++ .../Include/Library/BasePldmProtocolLib.h | 41 ++ .../Library/ManageabilityTransportHelperLib.h | 98 ++++ .../Library/ManageabilityTransportLib.h | 35 +- .../Library/ManageabilityTransportMctpLib.h | 54 ++ .../Include/Protocol/MctpProtocol.h | 102 ++++ .../Include/Protocol/PldmProtocol.h | 87 +++ .../Protocol/PldmSmbiosTransferProtocol.h | 184 ++++++ .../Common/ManageabilityTransportKcs.h | 22 +- .../Dxe/ManageabilityTransportMctp.h | 26 + .../IpmiProtocol/Common/IpmiProtocolCommon.h | 36 +- .../IpmiProtocol/Pei/IpmiPpiInternal.h | 8 +- .../MctpProtocol/Common/MctpProtocolCommon.h | 139 +++++ .../PldmProtocol/Common/PldmProtocolCommon.h | 109 ++++ .../BaseManageabilityTransportHelper.c | 225 +++++++- .../BaseManageabilityTransportNull.c | 18 +- .../Common/KcsCommon.c | 208 ++++--- .../Dxe/ManageabilityTransportKcs.c | 89 +-- .../Dxe/ManageabilityTransportMctp.c | 367 ++++++++++++ .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 87 +++ .../IpmiProtocol/Common/IpmiProtocolCommon.c | 63 ++- .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 24 +- .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 51 +- .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 24 +- .../MctpProtocol/Common/MctpProtocolCommon.c | 472 ++++++++++++++++ .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 218 ++++++++ .../PldmProtocol/Common/PldmProtocolCommon.c | 437 +++++++++++++++ .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 181 ++++++ .../PldmSmbiosTransferDxe.c | 525 ++++++++++++++++++ Features/ManageabilityPkg/Readme.md | 10 + .../Dxe/ManageabilityTransportMctp.uni | 13 + .../Dxe/PldmProtocolLib.uni | 18 + 42 files changed, 4096 insertions(+), 214 deletions(-) rename Features/ManageabilityPkg/Include/{Dsc =3D> }/Manageability.dsc (57= %) create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/DxeManageabilityTransportMctp.inf create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.inf create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/Mc= tpProtocolDxe.inf create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/Pl= dmProtocolDxe.inf create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferD= xe/PldmSmbiosTransferDxe.inf create mode 100644 Features/ManageabilityPkg/Include/Library/BasePldmProto= colLib.h create mode 100644 Features/ManageabilityPkg/Include/Library/Manageability= TransportMctpLib.h create mode 100644 Features/ManageabilityPkg/Include/Protocol/MctpProtocol= .h create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmProtocol= .h create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmSmbiosTr= ansferProtocol.h create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.h create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common= /MctpProtocolCommon.h create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common= /PldmProtocolCommon.h create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.c create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.c create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common= /MctpProtocolCommon.c create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/Mc= tpProtocol.c create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common= /PldmProtocolCommon.c create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/Pl= dmProtocol.c create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferD= xe/PldmSmbiosTransferDxe.c create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.uni create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.uni --=20 2.37.1.windows.1