From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Star Zeng <star.zeng@intel.com>, Andrew Fish <afish@apple.com>
Cc: "Rebecca Cran" <rebecca@bsdio.com>, "Ray Ni" <ray.ni@intel.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Jian J Wang" <jian.j.wang@intel.com>,
"Xiaoyu Lu" <xiaoyu1.lu@intel.com>,
"Guomin Jiang" <guomin.jiang@intel.com>,
"Gua Guo" <gua.guo@intel.com>, "Ard Biesheuvel" <ardb@kernel.org>,
"Pedro Falcato" <pedro.falcato@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marvin Häuser" <mhaeuser@posteo.de>
Subject: [PATCH v4 11/13] BaseTools: Add a deprecation warning for GCC48,GCC49,GCC5 to build.py
Date: Wed, 19 Apr 2023 13:57:44 -0600 [thread overview]
Message-ID: <20230419195746.99074-12-rebecca@bsdio.com> (raw)
In-Reply-To: <20230419195746.99074-1-rebecca@bsdio.com>
The GCC48, GCC49 and GCC5 toolchains will be deleted in the coming
months. Inform users that they're deprecated and tell them what replaces
them.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/Source/Python/build/build.py | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 8681b98776a9..61f66e7b04d7 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -64,6 +64,8 @@ from AutoGen.IncludesAutoGen import IncludesAutoGen
from GenFds.GenFds import resetFdsGlobalVariable
from AutoGen.AutoGen import CalculatePriorityValue
+gDeprecatedToolChains = ['GCC48', 'GCC49', 'GCC5']
+
## standard targets of build command
gSupportedTarget = ['all', 'genc', 'genmake', 'modules', 'libraries', 'fds', 'clean', 'cleanall', 'cleanlib', 'run']
@@ -898,6 +900,12 @@ class Build():
for BuildTarget in self.BuildTargetList:
GlobalData.gGlobalDefines['TARGET'] = BuildTarget
for BuildToolChain in self.ToolChainList:
+ if BuildToolChain in gDeprecatedToolChains:
+ EdkLogger.warn("build", "Toolchain " + BuildToolChain + \
+ " is deprecated and will be removed before the edk2-stable202402 release. " \
+ "You should use 'GCCNOLTO' instead of 'GCC49', and 'GCC' instead of 'GCC5'")
+ time.sleep(2)
+
GlobalData.gGlobalDefines['TOOLCHAIN'] = BuildToolChain
GlobalData.gGlobalDefines['TOOL_CHAIN_TAG'] = BuildToolChain
for BuildArch in self.ArchList:
@@ -2768,6 +2776,12 @@ def Main():
if not BuildError:
MyBuild.BuildReport.GenerateReport(BuildDurationStr, LogBuildTime(MyBuild.AutoGenTime), LogBuildTime(MyBuild.MakeTime), LogBuildTime(MyBuild.GenFdsTime))
+ if any(tc in Option.ToolChain for tc in gDeprecatedToolChains):
+ EdkLogger.warn("build", "Toolchains " + str(gDeprecatedToolChains) + " are " \
+ "deprecated and will be removed before the edk2-stable202402 release. " \
+ "You should use 'GCCNOLTO' instead of 'GCC49', and 'GCC' instead of 'GCC5'.")
+ time.sleep(2)
+
EdkLogger.SetLevel(EdkLogger.QUIET)
EdkLogger.quiet("\n- %s -" % Conclusion)
EdkLogger.quiet(time.strftime("Build end time: %H:%M:%S, %b.%d %Y", time.localtime()))
--
2.37.2
next prev parent reply other threads:[~2023-04-19 19:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 19:57 [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 01/13] BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 toolchains Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 02/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 03/13] BaseTools: Remove VS2008-VS2013 remnants Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 04/13] MdePkg: " Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 05/13] edksetup.bat: " Rebecca Cran
2023-04-20 17:34 ` [edk2-devel] " Leif Lindholm
2023-04-19 19:57 ` [PATCH v4 06/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 07/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 08/13] BaseTools: Update VS toolchain descriptions in tools_def.txt.template Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 09/13] BaseTools/Conf/tools_def.template: Add GCC and GCCNOLTO toolchains Rebecca Cran
2023-04-21 2:32 ` 回复: " gaoliming
2023-04-21 17:16 ` Rebecca Cran
2023-04-24 5:03 ` 回复: [edk2-devel] " gaoliming
2023-04-19 19:57 ` [PATCH v4 10/13] BaseTools: Only call LoadConfiguration once in build.py Rebecca Cran
2023-04-19 19:57 ` Rebecca Cran [this message]
2023-04-19 19:57 ` [PATCH v4 12/13] BaseTools/Conf/tools_def.template: Add section for deprecated toolchains Rebecca Cran
2023-04-19 19:57 ` [PATCH v4 13/13] BaseTools/Conf/tools_def.template: Bump VERSION to 3.00 Rebecca Cran
2023-04-21 2:35 ` 回复: [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419195746.99074-12-rebecca@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox