From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.53601.1681947672260312361 for ; Wed, 19 Apr 2023 16:41:12 -0700 Authentication-Results: mx.groups.io; dkim=fail, err=malformed MIME header line: Subject: [edk2-devel][PATCH v1 2/2] Add volatile keyword to NvmExpressPei's Passthru CQs and SQs.; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: osde@linux.microsoft.com) Received: from OSD-Desktop.redmond.corp.microsoft.com (unknown [131.107.159.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 9956321C205B; Wed, 19 Apr 2023 16:41:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9956321C205B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1681947671; bh=qQXJvJUHs3P9DmGDWsHFty7gyOz3uh/zAPmlApj76mU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IB+7vu/nyF/Ic3J/3HUfHnmHDub4S6eyLEDj7qyxeWKlYHtoL0/K/muAaqruohwVJ p3ZwO5fcnKGychPrgzhDyoEuvTxNtTQs1nzp26620ApMhCKCgLf2DXQtlc0AYuMKMy KbGWgqrrmGt7JYxTCFXGVzSmSJb/yEaUBNNK2+6Q= From: "Oliver Smith-Denny" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni , Jian J Wang , Liming Gao , Michael Kubacki , Sean Brogan Subject: [edk2-devel][PATCH v1 2/2] Add volatile keyword to NvmExpressPei's Passthru CQs and SQs. Date: Wed, 19 Apr 2023 16:41:08 -0700 Message-Id: <20230419234108.10243-3-osde@linux.microsoft.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230419234108.10243-1-osde@linux.microsoft.com> References: <20230419234108.10243-1-osde@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable This applies the volatile keyword and appropriate casts=0D to the NvmExpressPei's Passthru CQs and SQs.=0D =0D Cc: Hao A Wu =0D Cc: Ray Ni =0D Cc: Jian J Wang =0D Cc: Liming Gao =0D Cc: Michael Kubacki =0D Cc: Sean Brogan =0D Signed-off-by: Oliver Smith-Denny =0D ---=0D MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c | 10 +++++-----= =0D 1 file changed, 5 insertions(+), 5 deletions(-)=0D =0D diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c b/M= deModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c=0D index 5081b53cd5e8..70b0b9d5965c 100644=0D --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c=0D +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c=0D @@ -115,7 +115,7 @@ NvmeCreatePrpList (=0D **/=0D EFI_STATUS=0D NvmeCheckCqStatus (=0D - IN NVME_CQ *Cq=0D + IN volatile NVME_CQ *Cq=0D )=0D {=0D if ((Cq->Sct =3D=3D 0x0) && (Cq->Sc =3D=3D 0x0)) {=0D @@ -343,8 +343,8 @@ NvmePassThruExecute (=0D )=0D {=0D EFI_STATUS Status;=0D - NVME_SQ *Sq;=0D - NVME_CQ *Cq;=0D + volatile NVME_SQ *Sq;=0D + volatile NVME_CQ *Cq;=0D UINT8 QueueId;=0D UINTN SqSize;=0D UINTN CqSize;=0D @@ -414,7 +414,7 @@ NvmePassThruExecute (=0D return EFI_INVALID_PARAMETER;=0D }=0D =0D - ZeroMem (Sq, sizeof (NVME_SQ));=0D + ZeroMem ((VOID *)Sq, sizeof (NVME_SQ));=0D Sq->Opc =3D (UINT8)Packet->NvmeCmd->Cdw0.Opcode;=0D Sq->Fuse =3D (UINT8)Packet->NvmeCmd->Cdw0.FusedOperation;=0D Sq->Cid =3D Private->Cid[QueueId]++;=0D @@ -617,7 +617,7 @@ NvmePassThruExecute (=0D //=0D // Copy the Respose Queue entry for this command to the callers response= buffer=0D //=0D - CopyMem (Packet->NvmeCompletion, Cq, sizeof (EFI_NVM_EXPRESS_COMPLETION)= );=0D + CopyMem (Packet->NvmeCompletion, (VOID *)Cq, sizeof (EFI_NVM_EXPRESS_COM= PLETION));=0D =0D //=0D // Check the NVMe cmd execution result=0D -- =0D 2.39.2=0D =0D