From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.70]) by mx.groups.io with SMTP id smtpd.web10.1720.1682038839919270236 for ; Thu, 20 Apr 2023 18:00:40 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nvidia.com header.s=selector2 header.b=Vpgfltq9; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.223.70, mailfrom: tputta@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHAhtSk/XpkdVB3PLj4qGnaQRNCTHehPaym/NXs/NNnPl9DDYFtLpKrnBUURY4ug1FO5D79Ilp8p/KFibkZu53Eu6erhcAHYGLOHQq+59aFZSe81AXCrnI7Czv3tGmYfHSNO/6FcWZe9HikKV5DHvg7lOY3Wxy4AWQvferuRzToegs2pf2w6dDn+xntPcm3gAwhbMlcUZebaiOOeTkdA+6a3f3/2djkirU74M7zEv5VbOVVT7sinfgiLZKomVbZzW7psNtA/jUYMgpYRjuCEG4vRge9lTSNqWrh+fy8TVLXwexNQu3tRyplaXrTQaV9OrFKOS+JSrBhWh3hPlQgoJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydU9b8PPscaxz/LjrZERyi2p1EnHBhQo+tA83ji8O08=; b=QHoeqcjoAi4BFJjSjKWkQ27Iv6dnVcjPuhkBJLI8krFrWS00K6NxumsMwj7lWfRMTRGjFutQ6EQrf5w7w+APM2RwyUJWuCyByi7b/rGf3HFRSsLJUFL2UjqOcMfZo4cgkCi+uGi7JGx8VGFSvfMkYYWwsq1jDxzh7DVI57ybFEa8dhSNQFgatFhqPkVKTL9KOi7t0v6Pjdg7HX+J+QrwDr+z7bPgFG232YHEBWlLM3quVGJdDXcIupGeeSo7B+4fLWRfzbgexCZiJiY5+oESVyHSzyQWCX1mbpF9j9NBP3G+7qC0WH1Rcc6ABNDcvl4ATeB31PCb4qNm5JNFeYaWNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydU9b8PPscaxz/LjrZERyi2p1EnHBhQo+tA83ji8O08=; b=Vpgfltq9z8XdHx4lT+t6G9xREw42I6kdHUE2E1AxLet2h2piQrOdsByXLP2lECD0YpnqAf7W4MChXsSr09+/lsXuzbaY7zt4JFssq0YYTQHEPjqPLXhhxyPGrAImyHPRBmrDW3o7v6Yx7+ic5z2Xqxu+CURy789N1/f43DoZ3bO6zimMFbQ/hMGxQ53DY0tvaCbXNUquXqKPmWnRCKIP5a7IduXWWsqTC9mJCF9/Da/KXlTMmp4TFVBsC+l5AcwVbwO1Z9GP7nhJeHkxfS8Sn7Awq4/ni1PO57OhSNQmXIObU8LiWm/K6ur1iVS5wOfnjgeAuIEDzvtZzaqk1lvzQQ== Received: from MW4PR03CA0214.namprd03.prod.outlook.com (2603:10b6:303:b9::9) by CY5PR12MB6036.namprd12.prod.outlook.com (2603:10b6:930:2c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.50; Fri, 21 Apr 2023 01:00:36 +0000 Received: from CO1NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::d4) by MW4PR03CA0214.outlook.office365.com (2603:10b6:303:b9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.25 via Frontend Transport; Fri, 21 Apr 2023 01:00:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CO1NAM11FT061.mail.protection.outlook.com (10.13.175.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.26 via Frontend Transport; Fri, 21 Apr 2023 01:00:36 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 20 Apr 2023 18:00:24 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 20 Apr 2023 18:00:23 -0700 Received: from tputta-vm-01.nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 20 Apr 2023 18:00:23 -0700 From: tputta@nvidia.com To: CC: Ray Ni , Zhichao Gao Subject: [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Date: Thu, 20 Apr 2023 18:00:23 -0700 Message-ID: <20230421010023.25867-1-tputta@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: tputta@nvidia.com X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT061:EE_|CY5PR12MB6036:EE_ X-MS-Office365-Filtering-Correlation-Id: f4175366-a2cf-4126-2eef-08db4203d128 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P/42+BeO6nLTb0ifESujVB64oBlAd02NhOwfVGOiWooiKZ/DOZnYJSWbi8RNTQCajSU+23PY+kocGvC+/Uh3Ffitagq6RI1IHZKWNFwnW/pj23kIXr95lfyY3Qx/CCo3Q0MdXY493dqomwgnSNGLr91K7UVx8QeUDnc+Ncm/NPBVQItBt/98ZRrBzm2LY6h4xMm6RDF8OFOJz5KpIbjvl2DBW+w2IRinfPURfIB71Bo/AWeHjkooXmdHO7kPJyKFY9mnLNC4WfCApLJHDasm0S/VLAPoW4ifbx0cZmXgZYm8bHzF4lTpuPbacjcBSYIddXWHkAgIR91tJEc3LQilF96qKFk+M/MYtGLaUHotRH4T7xP3w/y2QKR9w5maZH4fY9cSrpsrAQa+GIALpYIIM+sboRsjVJamf8X3gzq8QgbOKhr8Aoa+Q0/P9gwBgC8KODB/TOGZnhkGOW0KGPGtOhM4udDBamUElyvLp9grdBWqXnyzh+jPFHlRwWjAwcOOaBpA1G0eq7TIm9b+VtRnCMA0TTIyz1fIiabrtpTGZNrMIr7ruS1VeD9+Z23oqv8Y3ETqTxYfhmAUJXGeIzPy5JCVycOjhRJBqHq03a3Stz8BQ6qjG9JqY1RDZMkxkGdrC/MZEK34WmhEYZCr5+fcmVYPB4QqZoMLeugxqvAnJO5uBozSLrMbxp9U2ZukgjgvmBJIyY1d8/Na4WVHyer9tSeRPyBZq/ugb0dmUh1p06dqlkngmpICpq6PuStl1T85A2Zq9bU4xaLabpFG5pn9gInACqFo52ShZ+lhrU0FDHE= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199021)(36840700001)(40470700004)(46966006)(4326008)(54906003)(316002)(6916009)(70206006)(70586007)(478600001)(7696005)(40480700001)(82310400005)(8936002)(8676002)(5660300002)(41300700001)(2906002)(356005)(7636003)(34020700004)(86362001)(36756003)(82740400003)(426003)(2616005)(336012)(1076003)(26005)(40460700003)(36860700001)(47076005)(186003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 01:00:36.3526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4175366-a2cf-4126-2eef-08db4203d128 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain As per the SMBIOS spec, in smbios type0 table, if the Bios size is greater than 16MB, extended bios size is used to update size information and bios size is set to 0xff. when this data is printed by smbiosview, both bios size and extended bios size is printed if the smbios version is beyond 3.1, which is incorrect as Bios size is set to 0xff when rom size is more than 16MB. To fix this bug, added a condition to print bios size only when it is not set to 0xff or if the smbios version is older than 3.1. Signed-off-by: Thejaswani Putta Cc: Ray Ni Cc: Zhichao Gao --- .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 1811cf0c44..5448abaa22 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -339,7 +339,9 @@ SmbiosPrintStructure ( ShellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (Str= uct, Struct->Type0->BiosVersion)); ShellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", Stru= ct->Type0->BiosSegment); ShellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosString= (Struct, Struct->Type0->BiosReleaseDate)); - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINF= O_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); + if ((Struct->Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x3,= 0x1))) { + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTI= NFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); + } =20 DisplayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(Stru= ct->Type0->BiosCharacteristics)), Option); =20 --=20 2.17.1