From: "Chang, Abner" <abner.chang@amd.com>
To: <devel@edk2.groups.io>
Cc: Isaac Oram <isaac.w.oram@intel.com>,
Abdul Lateef Attar <abdattar@amd.com>,
Nickle Wang <nicklew@nvidia.com>,
Igor Kulchytskyy <igork@ami.com>,
Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Subject: [edk2-platforms][PATCH V3 00/14] ManageabilityPkg part II
Date: Fri, 21 Apr 2023 13:22:33 +0800 [thread overview]
Message-ID: <20230421052247.1520-1-abner.chang@amd.com> (raw)
From: Abner Chang <abner.chang@amd.com>
In V3: Address comments given to V2.
In V2:
- Address uncrustify issues.
- Use DBBUG_MANAGEABILITY_INFO to output detailed
manageability information.
DEBUG_INFO is used for the function entry point,
while DEBUG_ERROR is used for the error situations.
In part II, we had implemented
- PLDM protocol
- MCTP protocol
- PLDM SMBIOS Transfer protocol
- MCTP manageability transport interface
- Support maximum transfer unit of transport interface
- Add more heler functions
- Add two new fields HeaderSize and TrailerSize in
MANAGEABILITY_TRANSFER_TOKEN structure.
- Add PCDs to build the manageability modules.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Abner Chang (14):
ManageabilityPkg: Add more helper functions
ManageabilityPkg: Support Maximum Transfer Unit
ManageabilityPkg: Add HeaderSize and TrailerSize
ManageabilityPkg: Add PldmProtocolLib
ManageabilityPkg: Add PldmSmbiosTransferDxe driver
ManageabilityPkg/KCS: KCS transport interface
ManageabilityPkg: Add definitions of MCTP
ManageabilityPkg: Add MCTP manageability header file
ManageabilityPkg/MctpProtocol: Add MctpProtocol
ManageabilityPkg: Add MCTP transport interface
ManageabilityPkg/PldmProtocol: Add PLDM protocol
ManageabilityPkg: Add Manageability PCDs
ManageabilityPkg: Relocate Manageability.dsc
ManageabilityPkg: Add Manageability FDFs
.../ManageabilityPkg/ManageabilityPkg.dec | 28 +
.../Include/{Dsc => }/Manageability.dsc | 20 +
.../ManageabilityPkg/ManageabilityPkg.dsc | 14 +-
.../ManageabilityPkg/Include/PostMemory.fdf | 28 +
.../ManageabilityPkg/Include/PreMemory.fdf | 12 +
.../BaseManageabilityTransportHelper.inf | 1 +
.../Dxe/DxeManageabilityTransportMctp.inf | 44 ++
.../Dxe/PldmProtocolLib.inf | 42 ++
.../MctpProtocol/Dxe/MctpProtocolDxe.inf | 53 ++
.../PldmProtocol/Dxe/PldmProtocolDxe.inf | 50 ++
.../PldmSmbiosTransferDxe.inf | 47 ++
.../Include/Library/BasePldmProtocolLib.h | 41 ++
.../Library/ManageabilityTransportHelperLib.h | 97 ++++
.../Library/ManageabilityTransportLib.h | 35 +-
.../Library/ManageabilityTransportMctpLib.h | 54 ++
.../Include/Protocol/MctpProtocol.h | 102 ++++
.../Include/Protocol/PldmProtocol.h | 87 +++
.../Protocol/PldmSmbiosTransferProtocol.h | 184 ++++++
.../Common/ManageabilityTransportKcs.h | 22 +-
.../Dxe/ManageabilityTransportMctp.h | 26 +
.../IpmiProtocol/Common/IpmiProtocolCommon.h | 36 +-
.../IpmiProtocol/Pei/IpmiPpiInternal.h | 8 +-
.../MctpProtocol/Common/MctpProtocolCommon.h | 139 +++++
.../PldmProtocol/Common/PldmProtocolCommon.h | 109 ++++
.../BaseManageabilityTransportHelper.c | 225 +++++++-
.../BaseManageabilityTransportNull.c | 18 +-
.../Common/KcsCommon.c | 208 ++++---
.../Dxe/ManageabilityTransportKcs.c | 89 +--
.../Dxe/ManageabilityTransportMctp.c | 367 ++++++++++++
.../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 87 +++
.../IpmiProtocol/Common/IpmiProtocolCommon.c | 63 ++-
.../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 24 +-
.../Universal/IpmiProtocol/Pei/IpmiPpi.c | 51 +-
.../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 24 +-
.../MctpProtocol/Common/MctpProtocolCommon.c | 472 ++++++++++++++++
.../Universal/MctpProtocol/Dxe/MctpProtocol.c | 218 ++++++++
.../PldmProtocol/Common/PldmProtocolCommon.c | 437 +++++++++++++++
.../Universal/PldmProtocol/Dxe/PldmProtocol.c | 181 ++++++
.../PldmSmbiosTransferDxe.c | 525 ++++++++++++++++++
Features/ManageabilityPkg/Readme.md | 10 +
.../Dxe/ManageabilityTransportMctp.uni | 13 +
.../Dxe/PldmProtocolLib.uni | 18 +
42 files changed, 4095 insertions(+), 214 deletions(-)
rename Features/ManageabilityPkg/Include/{Dsc => }/Manageability.dsc (57%)
create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf
create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf
create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/DxeManageabilityTransportMctp.inf
create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.inf
create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf
create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf
create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.inf
create mode 100644 Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.h
create mode 100644 Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpLib.h
create mode 100644 Features/ManageabilityPkg/Include/Protocol/MctpProtocol.h
create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmProtocol.h
create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmSmbiosTransferProtocol.h
create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/ManageabilityTransportMctp.h
create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolCommon.h
create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolCommon.h
create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/ManageabilityTransportMctp.c
create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.c
create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolCommon.c
create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c
create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolCommon.c
create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c
create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.c
create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/ManageabilityTransportMctp.uni
create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.uni
--
2.37.1.windows.1
next reply other threads:[~2023-04-21 5:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 5:22 Chang, Abner [this message]
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 01/14] ManageabilityPkg: Add more helper functions Chang, Abner
2023-04-21 11:46 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 02/14] ManageabilityPkg: Support Maximum Transfer Unit Chang, Abner
2023-04-21 7:13 ` [edk2-devel] " Tinh Nguyen
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 03/14] ManageabilityPkg: Add HeaderSize and TrailerSize Chang, Abner
2023-04-21 11:51 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 04/14] ManageabilityPkg: Add PldmProtocolLib Chang, Abner
2023-04-21 12:55 ` Attar, AbdulLateef (Abdul Lateef)
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 05/14] ManageabilityPkg: Add PldmSmbiosTransferDxe driver Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 06/14] ManageabilityPkg/KCS: KCS transport interface Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 07/14] ManageabilityPkg: Add definitions of MCTP Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 08/14] ManageabilityPkg: Add MCTP manageability header file Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 09/14] ManageabilityPkg/MctpProtocol: Add MctpProtocol Chang, Abner
2023-04-25 1:31 ` Nickle Wang
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 10/14] ManageabilityPkg: Add MCTP transport interface Chang, Abner
2023-04-25 1:33 ` Nickle Wang
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 11/14] ManageabilityPkg/PldmProtocol: Add PLDM protocol Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 12/14] ManageabilityPkg: Add Manageability PCDs Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 13/14] ManageabilityPkg: Relocate Manageability.dsc Chang, Abner
2023-04-21 5:22 ` [edk2-platforms][PATCH V3 14/14] ManageabilityPkg: Add Manageability FDFs Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421052247.1520-1-abner.chang@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox