From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.79]) by mx.groups.io with SMTP id smtpd.web11.5087.1682054596106526454 for ; Thu, 20 Apr 2023 22:23:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=KIiU8VWx; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.79, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MuQ/IAAAxNZLh8hDrIPx8X8uE+huqPzvTjgHJoHDI2fbo8biKAA9p91D3s+MuziVj4YFN3xa3OcHr8y/vIwpb3Q0MBhJ7k2a4X8Fc0vKYWN4kICS/mca6UuPeHONQnkHjJyHz9DM/thRwGfLtR7GHfxlGQjcvum35tWQIxzmaeiDjsEdWhL7cnxgKAcQytxg981RPD9Bec48mwzNVvFxW8z8tNAJf9lHYyaO7agRSIeG0VxwUsCdx8YO5zfqiZQtq2dJ/5xZmonLoXs8RbRQMngCIeycjoct8uWfiUa2q9qVoxAzDC+XLQThYQ6QMLtNbjiU/jDfJFd490gj5HUU0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rBOqCDGk4O8soPSmT+IlYJktyReou5AuTOqis4ymQzU=; b=G82r37LF3/2XOkZJyjXPa5BcrATDezmZiDtEcv50D35x3VMgZVo6s2mdvRlQVf487Ur/tk4xRJs4Oazq/2U0iRXGnfmplIyXeAH0NjKRjXv8DDsN34e7vg+cNHQMFgjuKPGuOW2PZ8KqOJ6lokPnmM/Cj7K3Y9dnWgckzRPoaVtDlz0Ddw+hOs2xSDhYmZDIrI0arpQhA7Ie/C9C1zwzHQ45HCpEDNgYThsmfmdErwxEzLaxbLb92WbetGVnfUxE7VheYiFRa500RXnQM2lbZdYC7nDGaBevv8J8F7HV3cQO4WsNtv8/6krlOOqplrIfTcUSEn57WBob+hn/hITLEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBOqCDGk4O8soPSmT+IlYJktyReou5AuTOqis4ymQzU=; b=KIiU8VWxCpM+NX/uKX4hPBKrX9GxPk+eB9H9quuqARh2WDD1dGJIE6b8QyDgdN/oVYYxp4GqRESOFuuaqj3qoPYoXtoxm9akp/3qS6b/ogM+5Cse62iwu4eJGDL/ILj8PCQMc9rBBTqLanCHMGv+4SgPxjYXHAgF1Yd3Tr99BLk= Received: from DM5PR07CA0114.namprd07.prod.outlook.com (2603:10b6:4:ae::43) by PH8PR12MB6891.namprd12.prod.outlook.com (2603:10b6:510:1cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Fri, 21 Apr 2023 05:23:14 +0000 Received: from DS1PEPF0000B076.namprd05.prod.outlook.com (2603:10b6:4:ae:cafe::3e) by DM5PR07CA0114.outlook.office365.com (2603:10b6:4:ae::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.28 via Frontend Transport; Fri, 21 Apr 2023 05:23:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000B076.mail.protection.outlook.com (10.167.17.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6340.15 via Frontend Transport; Fri, 21 Apr 2023 05:23:13 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 21 Apr 2023 00:23:09 -0500 From: "Chang, Abner" To: CC: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , Tinh Nguyen Subject: [edk2-platforms][PATCH V3 00/14] ManageabilityPkg part II Date: Fri, 21 Apr 2023 13:22:33 +0800 Message-ID: <20230421052247.1520-1-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B076:EE_|PH8PR12MB6891:EE_ X-MS-Office365-Filtering-Correlation-Id: fec8261a-6646-452b-264e-08db4228812e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: blr8fPyxJn04iFHzFyPfnqNhEMgXaN7VyGxeRtl03OnLOV1oOpGfTj3yZxAJhYv2fzBnVh3rJSc2tD9z3MYHPfU1NHZsV81Mh4Q2A2CNPIsrQbEPRqZyF3jepWFfWzPKWO5Gj+UaKD/K/NwVmypns3ICIPuVfPXVN2VKHevThdOfZ/8ADsmFx+phoeg3EMUMnusyer9YF7VT/ZGeTYv+gdjC2DD8PAfLxB6q6E48Xa3H0uGqiNMbmCH8R7Tv7tywx9iau51D+V/9Fr0FqQw2ONuPeFn85Dx+/U84p79mEnOzNqK8vgV+T/T4040mdICHT2XNvUX6Pm5aV+/BcYQm05imM9i+PVAhw+o2MJqxqkSnGvAFRBUi1Rs1YEV8JDN+5bHK0inLIydEkFmWJXFd0MVj0UQm5qv5222nw1YYSeC0j7ojtuLc/c0cF9BNslikVoar19Rw0zxd+1lQkGQlOJY+xio9sHOw95VuxzS2spiyB7COc5cRY7B6E5RX9v3/LUYa+Aloanh9LY/YDlE20NnP6lEkZkCoBY67LPkF2X7eyckl5jC+kO14QcIJvXzpnWUg4b7HvlB3C6Gc4dKM8OKkDu659PuqMY/gSeQqolLlDPEKvLu1PYx2WiIO3xA1V1LLi9ekh9j1YB2ha+U4zZESkO8aq/TcsmcMk3vynbQK10DKob6MCqkDJxWv78wBD826yAsDgi1srojIhrTnSFV2e82sgkrRLMnEniJtHaI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199021)(46966006)(36840700001)(40470700004)(82310400005)(40460700003)(1076003)(26005)(82740400003)(40480700001)(186003)(86362001)(70586007)(6916009)(41300700001)(83380400001)(6666004)(7696005)(70206006)(36756003)(54906003)(478600001)(316002)(4326008)(356005)(81166007)(16526019)(36860700001)(8676002)(8936002)(2906002)(2876002)(336012)(5660300002)(2616005)(426003)(47076005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 05:23:13.5530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fec8261a-6646-452b-264e-08db4228812e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B076.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6891 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang In V3: Address comments given to V2. In V2: - Address uncrustify issues. - Use DBBUG_MANAGEABILITY_INFO to output detailed manageability information. DEBUG_INFO is used for the function entry point, while DEBUG_ERROR is used for the error situations. In part II, we had implemented - PLDM protocol - MCTP protocol - PLDM SMBIOS Transfer protocol - MCTP manageability transport interface - Support maximum transfer unit of transport interface - Add more heler functions - Add two new fields HeaderSize and TrailerSize in MANAGEABILITY_TRANSFER_TOKEN structure. - Add PCDs to build the manageability modules. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Tinh Nguyen Abner Chang (14): ManageabilityPkg: Add more helper functions ManageabilityPkg: Support Maximum Transfer Unit ManageabilityPkg: Add HeaderSize and TrailerSize ManageabilityPkg: Add PldmProtocolLib ManageabilityPkg: Add PldmSmbiosTransferDxe driver ManageabilityPkg/KCS: KCS transport interface ManageabilityPkg: Add definitions of MCTP ManageabilityPkg: Add MCTP manageability header file ManageabilityPkg/MctpProtocol: Add MctpProtocol ManageabilityPkg: Add MCTP transport interface ManageabilityPkg/PldmProtocol: Add PLDM protocol ManageabilityPkg: Add Manageability PCDs ManageabilityPkg: Relocate Manageability.dsc ManageabilityPkg: Add Manageability FDFs .../ManageabilityPkg/ManageabilityPkg.dec | 28 + .../Include/{Dsc =3D> }/Manageability.dsc | 20 + .../ManageabilityPkg/ManageabilityPkg.dsc | 14 +- .../ManageabilityPkg/Include/PostMemory.fdf | 28 + .../ManageabilityPkg/Include/PreMemory.fdf | 12 + .../BaseManageabilityTransportHelper.inf | 1 + .../Dxe/DxeManageabilityTransportMctp.inf | 44 ++ .../Dxe/PldmProtocolLib.inf | 42 ++ .../MctpProtocol/Dxe/MctpProtocolDxe.inf | 53 ++ .../PldmProtocol/Dxe/PldmProtocolDxe.inf | 50 ++ .../PldmSmbiosTransferDxe.inf | 47 ++ .../Include/Library/BasePldmProtocolLib.h | 41 ++ .../Library/ManageabilityTransportHelperLib.h | 97 ++++ .../Library/ManageabilityTransportLib.h | 35 +- .../Library/ManageabilityTransportMctpLib.h | 54 ++ .../Include/Protocol/MctpProtocol.h | 102 ++++ .../Include/Protocol/PldmProtocol.h | 87 +++ .../Protocol/PldmSmbiosTransferProtocol.h | 184 ++++++ .../Common/ManageabilityTransportKcs.h | 22 +- .../Dxe/ManageabilityTransportMctp.h | 26 + .../IpmiProtocol/Common/IpmiProtocolCommon.h | 36 +- .../IpmiProtocol/Pei/IpmiPpiInternal.h | 8 +- .../MctpProtocol/Common/MctpProtocolCommon.h | 139 +++++ .../PldmProtocol/Common/PldmProtocolCommon.h | 109 ++++ .../BaseManageabilityTransportHelper.c | 225 +++++++- .../BaseManageabilityTransportNull.c | 18 +- .../Common/KcsCommon.c | 208 ++++--- .../Dxe/ManageabilityTransportKcs.c | 89 +-- .../Dxe/ManageabilityTransportMctp.c | 367 ++++++++++++ .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 87 +++ .../IpmiProtocol/Common/IpmiProtocolCommon.c | 63 ++- .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 24 +- .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 51 +- .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 24 +- .../MctpProtocol/Common/MctpProtocolCommon.c | 472 ++++++++++++++++ .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 218 ++++++++ .../PldmProtocol/Common/PldmProtocolCommon.c | 437 +++++++++++++++ .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 181 ++++++ .../PldmSmbiosTransferDxe.c | 525 ++++++++++++++++++ Features/ManageabilityPkg/Readme.md | 10 + .../Dxe/ManageabilityTransportMctp.uni | 13 + .../Dxe/PldmProtocolLib.uni | 18 + 42 files changed, 4095 insertions(+), 214 deletions(-) rename Features/ManageabilityPkg/Include/{Dsc =3D> }/Manageability.dsc (57= %) create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/DxeManageabilityTransportMctp.inf create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.inf create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/Mc= tpProtocolDxe.inf create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/Pl= dmProtocolDxe.inf create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferD= xe/PldmSmbiosTransferDxe.inf create mode 100644 Features/ManageabilityPkg/Include/Library/BasePldmProto= colLib.h create mode 100644 Features/ManageabilityPkg/Include/Library/Manageability= TransportMctpLib.h create mode 100644 Features/ManageabilityPkg/Include/Protocol/MctpProtocol= .h create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmProtocol= .h create mode 100644 Features/ManageabilityPkg/Include/Protocol/PldmSmbiosTr= ansferProtocol.h create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.h create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common= /MctpProtocolCommon.h create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common= /PldmProtocolCommon.h create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.c create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.c create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Common= /MctpProtocolCommon.c create mode 100644 Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/Mc= tpProtocol.c create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Common= /PldmProtocolCommon.c create mode 100644 Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/Pl= dmProtocol.c create mode 100644 Features/ManageabilityPkg/Universal/PldmSmbiosTransferD= xe/PldmSmbiosTransferDxe.c create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTranspor= tMctpLib/Dxe/ManageabilityTransportMctp.uni create mode 100644 Features/ManageabilityPkg/Library/PldmProtocolLibrary/D= xe/PldmProtocolLib.uni --=20 2.37.1.windows.1