From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web10.18653.1682097369009222109 for ; Fri, 21 Apr 2023 10:16:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=dKir3sIw; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E78293200B18; Fri, 21 Apr 2023 13:16:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 21 Apr 2023 13:16:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1682097366; x= 1682183766; bh=VY09KOERSQvlZfDgJ+6NVPWGc2Lkb/cBDjVvdmAVtPs=; b=d Kir3sIwxmG4rN0z3S++6n0Q6GrrcbSz1xO4GwrrWWKB6ei9eelRJJxjgCG8yVQ2n VSiqwRHNT2/+Jd7hnMLXEMaqHf1MtK2oqJo351rzJNBUuxXoCsfMiG5QJOhACSne xnz14sad2449gmIr/fFL27dttR9/k3r0RCeO20nbjt1jXr4jk32B3JySKIbs4L2k HF6wv9As9csb12pKX78bHsmb+7apTtXtTwFArkoeO2cn817dgT/ZyXACXYFu5B+R R8nj3YHRLLGt6qazctjtLCIc/19+Xu+SLnNmU7vffeths/nzErGZYhr3FHjPYAnY SyP7QgDDcI1LHyqLq4jIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1682097366; x= 1682183766; bh=VY09KOERSQvlZfDgJ+6NVPWGc2Lkb/cBDjVvdmAVtPs=; b=c pRDywEqB2nwLjPt7mbSj7qSQ0RUDDMQzFOGI5DjqeQqX9GyFSxFrOp1s72/9yZx0 XtjgitqAQWbKD8BqVdhOyx41wYgrHHDf0PG4fn6gMlk/Bjuzr3p17ydd51T6t96B fIrsjnLbMrHIFnMSVINu0L1qTSitlryL/ov6Hxrw1mvzj5KGEHuXbQQquT5oF0wN le3jEaXs5U528N4Q8XMVxM/+6lJgcLcivrj+FwC38ho3CKSInIf2Sv8mlqyjyzjo 8huYpIaUnrM2z7jZ723rrOnaOizKp2LFDlHOBxn5UWoODHl5z83BUoFg4HBwqsHf 5M9UmOS83qHSZJ/Ty2SbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegffeuueelvdeggfdvvdfgtedvudfhfeekudekieektddukeefteetieef vdelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Apr 2023 13:16:04 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen , Michael D Kinney , Michael Kubacki , Sean Brogan , Chasel Chiu , Nate DeSimone , Star Zeng , Andrew Fish Cc: Rebecca Cran , Ray Ni , Leif Lindholm , Zhiguang Liu , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Gua Guo , Ard Biesheuvel , Pedro Falcato , Gerd Hoffmann , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [PATCH v5 10/13] BaseTools: Only call LoadConfiguration once in build.py Date: Fri, 21 Apr 2023 11:15:05 -0600 Message-Id: <20230421171508.73336-11-rebecca@bsdio.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230421171508.73336-1-rebecca@bsdio.com> References: <20230421171508.73336-1-rebecca@bsdio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Avoid calling LoadConfiguration twice, in both InitPreBuild and InitBuild. Since InitPreBuild is called first, delete the second call from InitBuild. Signed-off-by: Rebecca Cran Reviewed-by: Liming Gao --- BaseTools/Source/Python/build/build.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index 51fb1f433eb7..8681b98776a9 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -1002,9 +1002,6 @@ class Build(): # command line and target.txt, then get the final build configurations. # def InitBuild(self): - # parse target.txt, tools_def.txt, and platform file - self.LoadConfiguration() - # Allow case-insensitive for those from command line or configuration file ErrorCode, ErrorInfo = self.PlatformFile.Validate(".dsc", False) if ErrorCode != 0: @@ -1012,6 +1009,7 @@ class Build(): def InitPreBuild(self): + # parse target.txt, tools_def.txt, and platform file self.LoadConfiguration() ErrorCode, ErrorInfo = self.PlatformFile.Validate(".dsc", False) if ErrorCode != 0: -- 2.39.2