From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.47111.1682330765582511830 for ; Mon, 24 Apr 2023 03:06:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IcB8VXq7; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682330784; x=1713866784; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+P+yV7nTZOy8i4xQVtQMqtBOC3OcOn6Xr9k9NFuI0GI=; b=IcB8VXq7bfu6XgDBfo0lAHHkq6r4jiJN3m5PWQlawvkCUF2J6T/mVOdj 7agsVIfN4QckyBhyL97iQB9v4sMl2+a5Mjnwr1AIiGiUgXsFsCIJyAMKQ hGX+RBk7KTjKpLFQF6e5W74PEfhfuavBwGXcABk7GiyoCgkk3lbMf0FzF KPqLq41jxnBxmBMJuc5ZDm+k13SNo67rC/QYGFacSJk+V3kvyAsATPpwx RA5dIOQChHUQOqo1VxO1R0HwPV8KnMmP2/IZe9LNwhCU++r+1oAY039zs HpVaWVuZ0e3OtFmjOmOC/Eln7ulOd/avE2CBTZ2qJuvK2GYHxwTa8xQ9e A==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="343897905" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="343897905" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 03:06:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="686766996" X-IronPort-AV: E=Sophos;i="5.99,222,1677571200"; d="scan'208";a="686766996" Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.92]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 03:06:22 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Ray Ni , Jian J Wang Subject: [Patch V3 7/8] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX Date: Mon, 24 Apr 2023 18:05:51 +0800 Message-Id: <20230424100552.2718-8-dun.tan@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20230424100552.2718-1-dun.tan@intel.com> References: <20230424100552.2718-1-dun.tan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In IA32 code, remove the duplicated code to enable NX. In the previous patch, IA32 code also uses the new CreateIdentityMappingPageTables() to create PAE page table. This function calls EnableExecuteDisableBit if needed. Signed-off-by: Dun Tan Cc: Dandan Bi Cc: Liming Gao Reviewed-by: Ray Ni Cc: Jian J Wang --- MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c index 69d073fb58..dd7cbb6ce6 100644 --- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c +++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c @@ -322,9 +322,6 @@ HandOffToDxeCore ( BuildPageTablesIa32Pae = ToBuildPageTable (); if (BuildPageTablesIa32Pae) { PageTables = CreateIdentityMappingPageTables (FALSE, BaseOfStack, STACK_SIZE, 0, 0); - if (IsEnableNonExecNeeded ()) { - EnableExecuteDisableBit (); - } } // -- 2.31.1.windows.1