From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web10.52293.1682345149887596256 for ; Mon, 24 Apr 2023 07:05:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=e6dezvKy; spf=pass (domain: bsdio.com, ip: 66.111.4.25, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 36C105C0117; Mon, 24 Apr 2023 10:05:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 24 Apr 2023 10:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1682345149; x=1682431549; bh=zOAbJGHAu8 +HG4NKzaSy81iBLiTYVrPEKlIoT5+tepc=; b=e6dezvKyPGa6cl5RAPDe6UDntY mfhKdDa24IGHgex5/jh1kdQZvfJcYCov2FDvpRKkz61HkDdvqMuF1KgC2bnK7jp5 7yc0o9HAUoS+2LMqLYtskOEKAJwGVE8cC0FZQqWN+fm5BvLo0rsJPJccUNI7wojZ vTQDaGE3Gpxv9aDq2sssimCERRAqBlTafAP2GdDM6w9QsTXUiqUcb/4ZiMAxlaAR xo9mSbDDOW99ATGpc2fPVXyZcNkwtp6p3aXWb36bY7lkqXH7IoX4SwI0ZF3691fb mBJv7ica6UQdfhi7wMaS6arrteNOPxS3aRB/lvOCXRw4rf/0wQQ4pMrUn4OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682345149; x=1682431549; bh=zOAbJGHAu8+HG 4NKzaSy81iBLiTYVrPEKlIoT5+tepc=; b=gFCmHMzsYsyDxRVn1oXLJ4W6qc4PL dD5vj5A+OpVqXL4PYpFacdgD1vHqw0Ovnz/cXA1fNq/pJNWCZfD+Ifs+vojr8Slr BPB5u9HFztHyfHro52CgEqajV6p0ApBT1h6mb6wJ7V7BjpprhArmFFRA8aM41PXv 7mPtzLv/ZVeLKjnpPnl6+xkP6Jn7aiYNgFXwuKCgnfXvTC5WD8iNeMMYHfu/o6z7 vO8EIyrXFhgMHpl1JPY3IYvihkBVG2etuE8us30uX/8xxAFPJ/9PAwtydW+OFYOX O8LFDWCyPAEzkvLq83zhsXQXMaFX1xYZ58XgXTivmti6iZ1tM6S9jSq6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedutddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheptfgvsggvtggt rgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrthhtvg hrnhepuedvkedtleekueekgfejjeettefftdduiefffeehveefgfevueelgffhleelgfdv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsg gvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Apr 2023 10:05:47 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen Cc: Rebecca Cran Subject: [PATCH v2 1/1] BaseTools: Add quotes around OBJCOPY cmd in build_rule.template Date: Mon, 24 Apr 2023 08:05:34 -0600 Message-Id: <20230424140534.1637-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.40.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add quotes around the OBJCOPY command in build_rule.template to fix the case where LLVM is installed on Windows in a path with spaces such as C:\Program Files\LLVM. Signed-off-by: Rebecca Cran --- BaseTools/Conf/build_rule.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index d42e7937cc90..eb64c62060e1 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -352,12 +352,12 @@ -$(CP) $(DEBUG_DIR)(+)*.pdb $(OUTPUT_DIR) $(CP) ${src} $(DEBUG_DIR)(+)$(MODULE_NAME).debug - $(OBJCOPY) $(OBJCOPY_STRIPFLAG) ${src} + "$(OBJCOPY)" $(OBJCOPY_STRIPFLAG) ${src} # #The below 2 lines are only needed for UNIXGCC tool chain, which generates PE image directly # - -$(OBJCOPY) $(OBJCOPY_ADDDEBUGFLAG) ${src} + -"$(OBJCOPY)" $(OBJCOPY_ADDDEBUGFLAG) ${src} -$(CP) $(DEBUG_DIR)(+)$(MODULE_NAME).debug $(BIN_DIR)(+)$(MODULE_NAME_GUID).debug "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) -- 2.40.0.windows.1