From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.73019.1682404812454075052 for ; Mon, 24 Apr 2023 23:40:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IbJNCBl9; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682404817; x=1713940817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8osGVZ7zQvN6fGWNjo4LrV6dFjdFocaPwjNt92xVQ1Q=; b=IbJNCBl9sLdgJq4DQhl4VjRHgzHGQvkbqLyuyhibC/TIq7AWPTHNKfVL poqtbRIkZbfE84VWZJNC9WAdAINGr1M5q9OutCM1pnCri7EnIbJl8936S rbpyGuBavrHEgHROLBV/pA4tlu7vcPKz5OerogiMA4hIfdofDrhlv3nou 0lBaeIt5IMcx/zi6M++9p5aNaQ4q7eW4aE5yFw011KFie7FwIBVqe6YRJ 4G4YB86+IpDRY3ee6JV4Su+wQk/c3zb94FfOFAnuZtUDo/ERhPeBkVPlz diLfyYcHT9Jm3mtvXTR3r2JB64LeHiGsgw3smSUyf/IjczItWhiLCwxHg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="326982933" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="326982933" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="817558212" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="817558212" Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:40:15 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD PcdSimicsSecPageTablesBase Date: Tue, 25 Apr 2023 14:40:03 +0800 Message-Id: <20230425064003.2037-4-zhiguang.liu@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20230425064003.2037-1-zhiguang.liu@intel.com> References: <20230425064003.2037-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, for 64-bit PEI, pagetable is created in reset vector and stored in SPI flash. No need this PCD now Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 3 --- Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec | 1 - Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 8 -------- Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 1 - Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 1 - 5 files changed, 14 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index ccb7fe7e59..a74c355e09 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -79,9 +79,6 @@ ErasePolarity = 1 BlockSize = 0x10000 NumBlocks = 0xB0 -0x000000|0x006000 -gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize - 0x006000|0x001000 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase|gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize diff --git a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec index 421c464023..e8aefdd893 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec @@ -38,7 +38,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwSpareBase|0x0|UINT32|0xd gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwWorkingBase|0x0|UINT32|0xe gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFdBaseAddress|0x0|UINT32|0xf - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|0x0|UINT32|0x11 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize|0x0|UINT32|0x12 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase|0x0|UINT32|0x13 gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize|0x0|UINT32|0x14 diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 6b572b38a8..39e879e922 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -759,14 +759,6 @@ SecCoreStartupWithStack ( AsmWriteIdtr (&IdtDescriptor); -#if defined (MDE_CPU_X64) - // - // ASSERT that the Page Tables were set by the reset vector code to - // the address we expect. - // - ASSERT (AsmReadCr3 () == (UINTN) PcdGet32 (PcdSimicsSecPageTablesBase)); -#endif - // // |-------------| <-- TopOfCurrentStack // | Stack | 32k diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf index 1de3d012a7..af1c0f2b55 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf @@ -62,7 +62,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsPeiMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf index cdc30ad582..49f441fe9d 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf @@ -65,7 +65,6 @@ gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress -- 2.31.1.windows.1