From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.69]) by mx.groups.io with SMTP id smtpd.web11.91233.1682454826290203190 for ; Tue, 25 Apr 2023 13:33:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=mvCA7F5d; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.69, mailfrom: michael.roth@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWi+fi8EUu873SKYlHbyb9S2SokaR7L9OotRmZzG7396KB1OWQwYHg9KyP/mXwTZe6WeYR6UttUiqGbWy82cDBVl3RRcDKjQxpablHJuLRXP38gO9UwfIQKPnFssKzQXcV2r3koAi0MzYAHrrNu+23dEGrJqUhgq3JbWXLEL2V25tYudl7bNDmi3j40VI8WeyLrmEPLWV19uJFsLBTjhBfh1RgZX95hNI0+n4cu3I/54efXVxCf/JKVjQSxsgwqoKP8LciEcmGEvHZbjO+x7s2ED+JsMbDIwqEx2elTnx0rC8Zmu0RiEa959mvbL+YC1aNIr4cMejQU7tsjVTVcqeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZoPSdfsEFngi8wvmTLK6LhrlwjjUjF0+sqMXzwgPp1U=; b=Um3xTAQEPVyKzn8umr4OKRSyccWsdrpTDdsWTYoCD4HsGIUzch1wPZRbLJRy2wSEOA77ILRmOgnDG0ZMv0BeJO0XhdQJu4Vgo8YLgqbtlICrY0VFJTpGIEVJDvmEwuBMgDGFfzr0kYPvteiIdl2a5Us4C+7n182u7lMcQb0ApljGhHVSY8+D++1FdT007cl5Syw/1cjJOKF9S3moEKGQQJuxZjfCWEkH+qcnZeYVjykpyp8Y7b5g0alAwaX4W3uW6I/exQB62aHIEhmF3+md78t7JnKJNmdRRMc4E+9hnDTJNOwae/FF0Slgrkh0/fOAh+UvjRLoxseMQ92STpuQ2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZoPSdfsEFngi8wvmTLK6LhrlwjjUjF0+sqMXzwgPp1U=; b=mvCA7F5d5lrDpLmqhR4pIGa4SFtIdHbe3yLP2O/X8Ema54PdEpK7yMOrp7H1RqaC0MbAp/u16lH9eFfWGaDJ/fuqgmN11pxYQEaP43MIrnPDgJZTy8PQMXcZycyv92JE7I0u/SBSHleoYRknXzly+vq3GKq/wsRbX8atpE8Yljw= Received: from BN7PR06CA0066.namprd06.prod.outlook.com (2603:10b6:408:34::43) by SA0PR12MB4494.namprd12.prod.outlook.com (2603:10b6:806:94::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 20:33:44 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:408:34:cafe::4f) by BN7PR06CA0066.outlook.office365.com (2603:10b6:408:34::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20 via Frontend Transport; Tue, 25 Apr 2023 20:33:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6340.20 via Frontend Transport; Tue, 25 Apr 2023 20:33:42 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 25 Apr 2023 15:33:41 -0500 From: "Roth, Michael" To: CC: Ard Biesheuvel , Tom Lendacky , Jiewen Yao , , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu Subject: [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling Date: Tue, 25 Apr 2023 15:32:54 -0500 Message-ID: <20230425203258.255583-1-michael.roth@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Return-Path: Michael.Roth@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT063:EE_|SA0PR12MB4494:EE_ X-MS-Office365-Filtering-Correlation-Id: 037da4e6-fd24-4ca8-e02d-08db45cc5c25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5l6Se6M6rBYy7Diux6F3svFRdLy8tG6tApvnBor8Obh+EjEu/kU6KqVSxk7g/BEFeYJ3asUFQrebkqQA+dfT5Lxyy1RydkxeFLYenl3F+pAkZybGCEJRgd5PpxfxMVgzhRF5VXcbNpwSZUsbsFOfjlQxovFFDD+2pcixlM7IeBwgS21anYJSRbP6+TKS+I4o/XYmHAOwHaEzY2KrP20mk4+yWI+Ivq56Xkb7vUAeWuWVY+dENCWic8AnEDHYmgpZMhB7+gwBGcxJrrgC5/fRs02xRClOEWosj/yeRRxqCCWL4rnKKKAgjBVJLECx9sGWbRPLaHzEVYLgmyAzstKRvJuzX9WCL4nrtILOYrIPbjPPl9vhwXljfcnBtnAlCa8xjv+J+SN3JgMyaEe+Vdl+XjQa3RSnWYkmNAt2hpkPCApo0qcB4n16+ssKg+zhrnWZEkEF2/Qq4Ts161XCExvW4/twPFQAad4zm9F4NN1cUGxeUPkoiRHxMjkaWCVz3H/32ykgPOHg36xIuoQmDfDU3AFH9xGRzr242brEnB7N4r0F9GozMbbXR/l3FTYpZjsDVb2PgqkCAyUZGnQn1PyEtM9ydIEcDFL7QIPcr4fZyUXlCzkB+LJYoj0NtPZNxUuSkfXoOA3yHQMEbfdvUxgzjYkc9eS7M/3atnAM7vAPTlWAU4ug59eXgcwvnWG3a1WTfHNDbJLL3tz23FwgmiEUvI3MvsFr+aiDJB3VZxaxCG8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(40470700004)(36840700001)(46966006)(2906002)(426003)(336012)(36860700001)(47076005)(83380400001)(86362001)(36756003)(82310400005)(40460700003)(70586007)(8936002)(478600001)(4326008)(316002)(26005)(6916009)(41300700001)(2616005)(16526019)(1076003)(70206006)(6666004)(186003)(40480700001)(82740400003)(356005)(81166007)(8676002)(44832011)(54906003)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 20:33:42.4219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 037da4e6-fd24-4ca8-e02d-08db45cc5c25 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4494 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain (Mainly a resend of v1, but rolled in Gerd's Acked-by's, addressed new coding style check in the CI, and updated Cc list) Here are a number of fixes related to OVMF handling of the SEV-SNP Confidential Computing blob and CPUID table. Patch #1 is a fix for recently-reported issue that can cause significant problems with some SEV-SNP guest operating systems. Please consider applying this patch directly if the other patches in this series are held up for any reason. Patches 2-4 are minor changes for things that aren't currently triggered in practice, but make OVMF's SEV-SNP implementation more robust for different build/hypervisor environments in the future. Patch #2 was submitted previously, but refreshed here to apply cleanly on top of Patch #1, with no other functional changes since the initial review. v2: - rebased/retested on latest master - replaced usage of __FUNCTION__ with __func__ to comply with new CI test cases ---------------------------------------------------------------- Michael Roth (4): OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definitio= n OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP OvmfPkg/AmdSevDxe/AmdSevDxe.c | 64 ++++++++++++++= ++++++++++++++++++++++++++++++++++++-------------- OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h | 6 ++++-- OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 13 +++++-------- 3 files changed, 59 insertions(+), 24 deletions(-)