From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1740.1682489774480026272 for ; Tue, 25 Apr 2023 23:16:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=luoKrNaF; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhiguang.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682489778; x=1714025778; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a8SpagFg8/1/9d/rdlSRpG2Y7GztT7XjBwylS6UI65U=; b=luoKrNaFtIbxxQLAgvE6XyTUoDAamdc8pNAkR4E3lXUfeW5v2SHdiG6r dX3axc4olPgdPfyjlGiSHeZ/xU/BnUkdhelz1WK0eUDN/iGoQl5Q5PRXR NjAMQSSbjNjDf57AXuFxpmBwEIdNyvLRo62JqnpJMcMZx33zFxDMGTtjk GQ119vo3J5F2Cir7RSPt0+RvHqSr8YSlVifVf5VDGuKo2vqV+QIHLi425 LF2hxFinzF6ghN8ytDR7KK4TNmCkzUi5wxvc59KC7Hf+yS6alcJY+fev9 n9MtpZhCaeZo3YkBOyNe2lYnKqx7ha0Czi3Me0QvuIxvuc99xSIAwvDMC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="331235195" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="331235195" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="644125254" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="644125254" Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 23:16:16 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Nate DeSimone , Ray Ni Subject: [PATCH v2 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver Date: Wed, 26 Apr 2023 14:15:48 +0800 Message-Id: <20230426061549.1254-5-zhiguang.liu@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20230426061549.1254-1-zhiguang.liu@intel.com> References: <20230426061549.1254-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Because of the similar reason I mentioned in last commit, the SmmAccess2Dxe.inf driver should be deleted and the replacement will avoid hard-code and use gEfiSmmSmramMemoryGuid Hob to get Smm Range information. This can fix an existing bug. In pei phase, some module may use some SMM range, and mark this range as allocated in gEfiSmmSmramMemoryGuid Hob. In DXE phase, when loading SMM core, we should avoid using the allocated SMM range. However, because the GetCapabilities by this driver return a hard-code SMM range information, the allocated buffer is treated as free buffer and used to load SMM core. Cc: Nate DeSimone Cc: Ray Ni Signed-off-by: Zhiguang Liu --- .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 +- Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index ae6f980a68..f15c088d9e 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -278,7 +278,7 @@ !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE $(PCH_PKG)/SmmControl/RuntimeDxe/SmmControl2Dxe.inf $(PCH_PKG)/Spi/Smm/PchSpiSmm.inf - $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf + IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf !endif diff --git a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf index fdcb4fb9a7..42c8408c05 100644 --- a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf +++ b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf @@ -1,14 +1,14 @@ ## @file # Component description file for the Simics X58 SiPkg DXE drivers. # -# Copyright (c) 2019 Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2023 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE - INF $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf + INF IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf !endif INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf -- 2.31.1.windows.1