From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.14511.1682578833927477542 for ; Thu, 27 Apr 2023 00:00:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Upb0DzqS; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: pen-chunx.lu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682578833; x=1714114833; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=b6awXACTRntvhwTkwM4D0HJlnueoKgjRP0RAvPQVoCY=; b=Upb0DzqSgcd2cE70JXWt+X7W1OaxwhitwkEAuwJc5OHXu9sozDurArkB pUBRXbzUGX2SgXeoCliZnGl4i5KuWWQMoUcg+x0hR7olb0BqNt9Ge+D7k a4j4qNjWy+xYSBJT483+XLOCsbVtNdiUMBjWiLOYOaOsPkH898nUlokHm wMxJN66UNiXlJHXSFtMEKptGnwZuTUoirRRj7w3/ZR/k5nTPu8wZbsyp8 wy8MOPAcbO4UevCrWSQ00EzMMEdjky+WVpCKbqjOdbKPuI/zVSRgn+R/z AXvblI5SnQGpRV2N8f4qp0doZFlMH8yKvfsgNfg4yg5o0MqdulQ7bdgX4 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="350190236" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="350190236" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 23:59:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="688287734" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="688287734" Received: from shserverbios518.ccr.corp.intel.com ([10.5.215.124]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2023 23:59:01 -0700 From: "JoeX Lu" To: devel@edk2.groups.io Cc: JoeX Lu , Jiewen Yao , Jian J Wang Subject: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Date: Thu, 27 Apr 2023 14:58:30 +0800 Message-Id: <20230427065830.29735-1-pen-chunx.lu@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CC: Jiewen Yao CC: Jian J Wang Signed-off-by: JoeX Lu --- .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c index eeb424b6c3..bf7a5fc65c 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( EFI_GUID *Identifier ) { - HASH_INTERFACE_HOB LocalHashInterfaceHob; + HASH_INTERFACE_HOB *LocalHashInterfaceHob; + HASH_INTERFACE_HOB *HobBuffer; - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); - return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); + HobBuffer = NULL; + LocalHashInterfaceHob = AllocateZeroPool (sizeof (HASH_INTERFACE_HOB)); + if (LocalHashInterfaceHob == NULL) { + return NULL; + } + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); + if (LocalHashInterfaceHob != NULL) { + FreePool (LocalHashInterfaceHob); + } + return HobBuffer; } /** -- 2.31.1.windows.1