From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.40199.1683165516892047154 for ; Wed, 03 May 2023 18:58:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=rDLyDVz0; spf=pass (domain: os.amperecomputing.com, ip: 40.107.236.100, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SPca2/sy5IvaMElhEp7KdvLIWTYIwcktHGekUCNurK+cnjOcc57xU3QovPDWjCEKNPI+IdUqSuOrZUX1cFn7SCtS2JX7eENFpoxFpZqlSo4EYDWW7iu7G+enR8zMTf31UapyW11iIVbKsOhZdwJ7RRICn2V/5ZGp4r7Sha65LA7DVZw5TWKLbyf9WO3AI7k5E7MTQljbtXV51tqRRhqKOVH7lIR1r2+4DLY8H/VNpKDTSB/5FITRYV5895kpc2diAYP/qnGYHxep77NJFwtqa6wPUVCQ9jtqfTfHNf9TOXjprdQ/rcql6xDtUbrJxyjXTKZ+NMH6VE/iUzaWJnIkkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xNrdBY1r5fbo82TYj7RUasTeZQFHcKwRx+s6YJweN8Q=; b=BoDqKb4vVWVPzUXx2Xr+kf+Q2CxcgNqGFzgbfT2dav94r024Lowpg6T/Q9saNS3TztFR0LMgb1NYa5NMNcwhbgMBxlkEjAE9Zm2dDYHG5VNfIiEmKkvHFv94c1EGT+8rImPLfub9OlJ83dUbRhDAnESFENO9tgUvWhE8yu/LJMTF5tDT0IV8JltiexMGJq0OTrnX8akMiFBezF6YR14ZvkQcpg2v7Ys9F1Yh00BhvYHb3UdeXJvx+lPKwMws8fQow+5WxYtogdSuxXYgMN/TUYd4ikTCUyDCbe7YaC4XL/vHavqCvVOxsusmUke7iynzCRrGgX1yyh+d/scQAaY0qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNrdBY1r5fbo82TYj7RUasTeZQFHcKwRx+s6YJweN8Q=; b=rDLyDVz0NPVA7Atkd4/hy3985Z5sVI2bTPBJn53ays2VnXuKswD3jjdPZJyDNFVI9zjH7OMCZFNLhEF7xDcS0o32Q5a/O3D5iJv9NJZlipvXL/YwNjnPiS+7tnvqweNY4cIPak3T8ax882V4eoj1lWwoYnjzqlK5xDZ9XHbrGM0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) by DM6PR01MB5978.prod.exchangelabs.com (2603:10b6:5:1df::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 01:58:34 +0000 Received: from SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a]) by SJ2PR01MB8049.prod.exchangelabs.com ([fe80::b8:5d56:7d04:223a%3]) with mapi id 15.20.6340.030; Thu, 4 May 2023 01:58:34 +0000 From: Minh Nguyen To: devel@edk2.groups.io CC: patches@amperecomputing.com, abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, nhi@os.amperecomputing.com, Vu Nguyen , Minh Nguyen Subject: [v1 PATCH 2/5] RedfishPkg: Fix condition checking of error status Date: Thu, 4 May 2023 08:57:51 +0700 Message-ID: <20230504015754.1352305-3-minhnguyen1@os.amperecomputing.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> X-ClientProxiedBy: SG2P153CA0037.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::6) To SJ2PR01MB8049.prod.exchangelabs.com (2603:10b6:a03:4ce::10) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR01MB8049:EE_|DM6PR01MB5978:EE_ X-MS-Office365-Filtering-Correlation-Id: fdf3f2b1-5ce8-489b-dded-08db4c431144 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ax7z0pwxYS+wkKF/0ezafy1U4ev001NGV8j3yLQRrkRW3jpSOFQByEoLijUdbD/GdCw7mvRuBcM3F0YbksT2CO/+iyEzUnLCn1dc2tyiAVWD6XvhrXn6TUyY14OYRWJOjDBLOcSN9T+Zw4b3x9J2iTAxc0DSWGOYbeykayu+JB5T/Mg4x0Ua6dBnEPHxeIT2p6EGPMCBxqp5qDjHwRj0vg6ZYkkGeGOtHyuM3F3GIzGcjPw8pqKVTuAKNRaChNwN83HORPb4nGNLoh2/5zx8Lsgx1FYQLcz+FLMMnJwklXiTCljqC3LoJI56ivs04OXnSMt8cfJIohxKN5acxyZYxRlxXyGoqlBj0NJcshz3ug7J6S3el+/1Mgu1lh0PLSAnv8YOfFExHTQnWRj4bwkK8z5poLeBgUBgBAp2FVQq/uf7Y/iwAtEj/e7IiN+yZmk15NkKp/sPQZoK/5XeoqQMomSAYBGAGNGrld85vgBt7NJKgb3eEV6RC6giSdEUabZUkseoadCj7Ypj1y9ndzmFhiH2ln8Go2n6dnthN+zte/zqWHqzAqLIEmMCFUtCD55yhwDXoWjazDcz4cULjIPLz2lpuKVIPNpZtc7phWbn5/YhKPVvrYZMdDkSlq2/hiIh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR01MB8049.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(39850400004)(136003)(451199021)(8676002)(8936002)(52116002)(41300700001)(6666004)(4326008)(66946007)(66476007)(66556008)(6916009)(86362001)(38100700002)(478600001)(316002)(54906003)(38350700002)(6486002)(2906002)(2616005)(5660300002)(6512007)(6506007)(26005)(1076003)(186003)(107886003)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hyDaNepua0btCUmUvTcfaalBahXbTujF5LR4LVD4TF97Ak01T5xGpzgDO0bo?= =?us-ascii?Q?3G8arZAqPb46t9e/g51yAkGOQazBfysrfpaxmGtWDbYR2DZiu6VvyH5/UnNY?= =?us-ascii?Q?Aw+sWghQJWMRQZ1mjMe7kP5OI3Q0TuUls6aBQvGasuvk08QQbzA+zzpB3e0e?= =?us-ascii?Q?VTnlJp0w0hZ8nYhVCI33jIGI1wHK2ojOCPcdBoEisOoDLy+QQQLCOlYzk77Y?= =?us-ascii?Q?PL/38WAsIaO7P4NvCRpIoIrv1yDfA32cZAByjloqGbfksKaWHMyKuzLFrWbt?= =?us-ascii?Q?OsdF+PaCVR2IwwUyr465wVbuy1wYRJr80FAMKEV5lztWUkFw5CJ0BvRip39v?= =?us-ascii?Q?ceD3B+E1P3wkxSEvOq/yuLRMvHAY+GRT/EomWd+bX7CFvu4SU7GFiHKaPloN?= =?us-ascii?Q?QQSLowHYItt+6Jq74PLRH8Zu6ooLbYP8ZD3JBXVzL7+4JHHMDyoH2jHM5yMD?= =?us-ascii?Q?/TK+b6dKeC4TGLmLVtoJw/m6Cl7okIJCRGFdXdhQcln4YViNYFsQDP8gW2nf?= =?us-ascii?Q?eo8i8/MSMbf9nKW0wZFLy3M5mtcaG6HlhDyMe330zwiQqZ9rfsaopR5gSuRY?= =?us-ascii?Q?UVWq3F12w0khXbhK8B33Nh4V+Yp8n3cqZjfQM0Y7WCCPD2GMGa8KyZS21B0/?= =?us-ascii?Q?8W922+nqPQHJ7O3LvoxNBm0NjNAZRFqA9GsHTqlNUSX+J1cK5oC9pC/mCsK2?= =?us-ascii?Q?pWMHFdNpC1DwPOsXF2Gj0w232HoyuJEUzDtHgseTfI7u//tDEa31nakji1nx?= =?us-ascii?Q?sUS2YME4ftcJQbpeJzCnAX38yrteOWklMmyGlnyNaXrFg/7YSOFQSmtzuq12?= =?us-ascii?Q?xS55YgI2NZPRCPJJaHF7fpR2ZKd6UH5Ng46L0LSOgK7KwSvcLRSR/r3rGowN?= =?us-ascii?Q?+BNoHTpmJTfI+MQuuZeDRg/MQgeVG2VB/wv/CL1hz/ouYyQtoJ2IaNVuyzLP?= =?us-ascii?Q?O6ufZNHUNq0zWRRa96LAtj5ZWB9FZ8X9m5P63lx2Nmq5YaLBkZr8uU79+owv?= =?us-ascii?Q?MJVVGwrvvFmtPH0hKtTrKFp05V2zTjWk7ZyMmDg5TMeLkPkb79TTYYHMX2Xt?= =?us-ascii?Q?yv9XE10NjINzcZYLt4Qo2oOZ1Gk6cFdCCuRhse2z14vSinGkpdoNu9pvpbo/?= =?us-ascii?Q?MDtaSmHalsQxsv6OBjvSL5OhqoIvtQ5QVVQ4SY5utcOjJ3/dkvL1S3Hq5TWI?= =?us-ascii?Q?uKvRMcbYSVypsQkOUk/uotqzj8SW8TILjsCEVE67nW7UqypbCNEiQPXidZVf?= =?us-ascii?Q?0y6G8zs9P/5vMKzg9uKknli4d1zPiPVv9yXgRv3IdCuId9fKzBlTjjADrbjS?= =?us-ascii?Q?Ju8Ae7wU/EOdjPyX4ffo0zFSPCx6VyFxFgtcvL+9Q9SiJ8RbXlpMGnA1CdkC?= =?us-ascii?Q?EI9ZokesoNARC1UEl8MmfPFZQza0+2f+jvWZkUjT9lybxZiSYYPk8swG5aMa?= =?us-ascii?Q?2+gJvRJLanTg9OlX4UbGTZri9AeA4O+m67qh4z5JfXm+pJa92f/Z5DGiW28L?= =?us-ascii?Q?8RP/+CzfOMfykUqo+F6fFCdJdlHvm4ZvwxiAB7LaxUBfVo2ewWBFtATFESoa?= =?us-ascii?Q?vuq5MWn432hnhp9IdcTPBTqrDtnhEFwmYefG5r30XW+jCaWf890DlfhyPOmV?= =?us-ascii?Q?v5S+O68y7SvvveXCcbCEARE7YxH9Pdw3m3/Gtz00fvK5?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdf3f2b1-5ce8-489b-dded-08db4c431144 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8049.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 01:58:34.3008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wVuq+YeKcbJ1biZTsoOhcjQHGUW5cmR7iRwgDRCQqrDS20rRUiEEVPteyxti+bSyyX1EJw84T/ZEUetRyp6Rh/yvmicmetSq7sVS/YMXyhIvxXWIkoVKR78Rtv8VDA3M X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5978 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Vu Nguyen This change fixes condition checking of error status, the condition should be compared with TRUE status to be identical with an error message. Signed-off-by: Minh Nguyen --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 583c6f78e19c..a247bfed9e34 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -5,6 +5,7 @@ (C) Copyright 2021 Hewlett Packard Enterprise Development LP
Copyright (c) 2022, AMD Incorporated. All rights reserved. Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -926,7 +927,7 @@ AddAndSignalNewRedfishService ( } =20 Status =3D gBS->SignalEvent (Instance->DiscoverToken->Event); - if (!EFI_ERROR (Status)) { + if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); } } --=20 2.39.0